Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88783FF8875 for ; Wed, 29 Apr 2026 19:07:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wIAEe-0001tu-Qy; Wed, 29 Apr 2026 15:06:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wIAEd-0001rR-BE for qemu-arm@nongnu.org; Wed, 29 Apr 2026 15:06:11 -0400 Received: from p-west3-cluster3-host3-snip4-3.eps.apple.com ([57.103.72.174] helo=outbound.ms.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wIAEa-0000Qy-Nl for qemu-arm@nongnu.org; Wed, 29 Apr 2026 15:06:10 -0400 Received: from outbound.ms.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-3a-60-percent-6 (Postfix) with ESMTPS id 6057B18000C9; Wed, 29 Apr 2026 19:06:04 +0000 (UTC) X-ICL-Out-Info: HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJB01fDl4fBBdGGVUERx5dVl4eGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQVKA18BWwZCAEkKXQJYAF4LTgZeD0YDQBQVXAVWBlcUeQ1dHUUOVhlaDFIPWw4cFktGExlOG1dNWg1AGVgGbRRWFVIEWQ== Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1777489567; x=1780081567; bh=3GBd+wzXPvXAfwwpmBMTeRFAqIZ+OnkzHsNQbsVw3JM=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme; b=G/OvQXpj1uqXQ7lVsEldRfz3g/v+Q5m1zYUo+7THZHLnya2yuUcy9Fh/geWcsAgGpU526L/TgZZPaRbcnitsl6NPL8AYaFhq5B4fgsPzqEecPhMRJ1Wp5zqRvGHVxIjR123FheNBPlugZlWCJOSklKvL/e3duzv88/rwjykGNcyX5/Fx0P1tXbJMK5FJ0R8S63mVmO2JlX0kWpY03/EpH6gGB0M4CK+R18MnnEu7KVDkaXjKpVoEqAXXRStGMODzBXnPr6WT3+LnxSjoZ7Hh6WRbaez4cq6lMii9k4tMwMKZUW03CHqwHtHof3kss39Ich4DP3v9HJNrsO41gebGVg== mail-alias-created-date: 1752046281608 Received: from localhost.localdomain (unknown [17.57.154.37]) by p00-icloudmta-asmtp-us-west-3a-60-percent-6 (Postfix) with ESMTPSA id 2406018005D7; Wed, 29 Apr 2026 19:06:00 +0000 (UTC) From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: Phil Dennis-Jordan , Yanan Wang , Paolo Bonzini , Roman Bolshakov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Zhao Liu , Alexander Graf , Eduardo Habkost , Marcel Apfelbaum , Peter Maydell , Mohamed Mediouni , Mads Ynddal Subject: [PATCH v21 09/15] target/arm: hvf: add asserts for code paths not leveraged when using the vGIC Date: Wed, 29 Apr 2026 21:05:26 +0200 Message-ID: <20260429190532.26538-10-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260429190532.26538-1-mohamed@unpredictable.fr> References: <20260429190532.26538-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: izGodYcf8rqy80C6eMLj4K96NaM5y_eU X-Proofpoint-ORIG-GUID: izGodYcf8rqy80C6eMLj4K96NaM5y_eU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI5MDE5MCBTYWx0ZWRfXw5BCQZ0e8q1h YT8yLU3QJ3PDMl0lVMcXYEtqPLF9bH12dxpkfDeFMShfPGzRqZcYANrErDBVQZp4w61JxlOq7Y8 9e4Ot7aZ61qwgoWruolEXqUsxFkxtU5one3j0bBxQ/NbfnVToOd/ZOKBhZguO3vX0ejH72M3Slo PEnE3+EErX6WLu875xfQsNP0ZEkoimXkGfJHCfc3z8HlC8MQjpd6VFM/8l8c72ZmSTJpuRiGUyo k0JXGOWwPjVAskBd3cWiuvDl1b7fFfMX35ya4ohk/iCLQ+NiJVOsQhcRwOFXgHa1WTflE/Iof/T JECgbUJlORXvgd2k7Qr5pBT2dvpdFQ/3zBPvTMPEGPzca5AEc3xQPPXkT/y/ms= X-Authority-Info-Out: v=2.4 cv=Ce0FJbrl c=1 sm=1 tr=0 ts=69f2569d cx=c_apl:c_pps:t_out a=qkKslKyYc0ctBTeLUVfTFg==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=vbFX7M0ab_H1AmF9bzsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 Received-SPF: pass client-ip=57.103.72.174; envelope-from=mohamed@unpredictable.fr; helo=outbound.ms.icloud.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org When using the vGIC, timers are directly handled by the platform. No vmexits ought to happen in that case. Abort if reaching those code paths. Signed-off-by: Mohamed Mediouni Reviewed-by: Mads Ynddal Reviewed-by: Philippe Mathieu-Daudé --- target/arm/hvf/hvf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 390a3529ff..38f88c1a80 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1696,6 +1696,7 @@ static int hvf_sysreg_read(CPUState *cpu, uint32_t reg, uint64_t *val) case SYSREG_ICC_SGI1R_EL1: case SYSREG_ICC_SRE_EL1: case SYSREG_ICC_CTLR_EL1: + assert(!hvf_irqchip_in_kernel()); /* Call the TCG sysreg handler. This is only safe for GICv3 regs. */ if (hvf_sysreg_read_cp(cpu, "GICv3", reg, val)) { return 0; @@ -1986,6 +1987,7 @@ static int hvf_sysreg_write(CPUState *cpu, uint32_t reg, uint64_t val) case SYSREG_ICC_SGI0R_EL1: case SYSREG_ICC_SGI1R_EL1: case SYSREG_ICC_SRE_EL1: + assert(!hvf_irqchip_in_kernel()); /* Call the TCG sysreg handler. This is only safe for GICv3 regs. */ if (hvf_sysreg_write_cp(cpu, "GICv3", reg, val)) { return 0; @@ -2393,6 +2395,7 @@ static int hvf_handle_vmexit(CPUState *cpu, hv_vcpu_exit_t *exit) ret = hvf_handle_exception(cpu, &exit->exception); break; case HV_EXIT_REASON_VTIMER_ACTIVATED: + assert(!hvf_irqchip_in_kernel()); qemu_set_irq(arm_cpu->gt_timer_outputs[GTIMER_VIRT], 1); cpu->accel->vtimer_masked = true; break; -- 2.50.1 (Apple Git-155)