Received: from mx.ssi.bg (mx.ssi.bg [193.238.174.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42CC83FA5FA; Thu, 30 Apr 2026 07:48:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.238.174.39 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777535305; cv=none; b=eEgBWRnUFSrdTr3dx6yksAvxLJrECTj0QNKA++3vX01ORAV6v9WliyLXtZ+Xb0x1g60CjyaIJGmmStYCkiai32qGPM967rhQYscMV2nW4BGY8Ge+gFbNjkWTT4wPX7DPs5zouX4nvtnF2mTPffTZ4/NCZzxlNHhcN5XGLJf2ONw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777535305; c=relaxed/simple; bh=C2hWpN7sSjdGkm4rOVk6n/xWQGh7Kysu6wMLYYWievA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KE18zgPGK8ZcMR4ZkDhm7G6qcLamQesV4tE/fwH1oD0v8sX3AKs7qgrFCKZ2MD5HOUtAlEshGh0+rjlPCykcabLlGmDd7g9/D3YJ8Z1M6xNm7netFfHTPNAM33chCVCvxmqhJTdP72f59yOKOfuIhARkSLdIYE2MrMmk9syvvvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ssi.bg; spf=pass smtp.mailfrom=ssi.bg; dkim=pass (4096-bit key) header.d=ssi.bg header.i=@ssi.bg header.b=CEh5f4GD; arc=none smtp.client-ip=193.238.174.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ssi.bg Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ssi.bg Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=ssi.bg header.i=@ssi.bg header.b="CEh5f4GD" Received: from mx.ssi.bg (localhost [127.0.0.1]) by mx.ssi.bg (Potsfix) with ESMTP id 127892292E; Thu, 30 Apr 2026 10:47:55 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ssi.bg; h=cc:cc :content-transfer-encoding:date:from:from:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=ssi; bh=Uqax325+N5JDs/S0EJd8JLZMGuyA5PI6DaXMbKDlAP4=; b=CEh5f4GDo9s0 hrY2APBtEq1mtRLihUwrP1iEC4NzVCCiqNb/uXkMBMD1dDlfmV3bCi9+I1g2c3Kb 164dYHYPY3urvIqu1UtHuVaw1do1wX7GOeQEx/QBDWPCPXZntM/aBTxhgECwm8nY Go4rwEgypJ2n4jH+O57fhqWP+28KevpGLmmdCyZ4bZV+fQWAst1cLdTSlOtUIq7p g87K+esT2aQxzwr20G6f4EZdu+++vNdeBFYLTxTgYyTivn/evVcV2U1YBHkBiDYl tE5qLGWi1T9e0rwIcGzs63Q6nNg4rZX37+mUNJ0Wyk2Zvr/A1nfCZa5AHWyF1xMy YFI8IMajbxS+LGaOAk6oTwgONtKyzTn1Rde06lUYVR8EcNLVjVgcT4FKdWvesHy0 SUvLnjzfIGbeDYXYZi6tKXxdX8/UvxnESR0kZQzm3H0XS0VjMkdUfya9ij0VbJN5 SHJCsD0EF5xRjnvJLyFt0t+8tTK9ni6HMqxO00SUgLBSpbaamG4uOyYREQQc78Th nrLsbrADVZbrYd8xJRSUotd/d2gBLgq9tAuXZNqQsCmThp5JhDmuUnSUn6rMW98Z BjmD/4EUYfJAiDCEw0sVSFmJdTJUGS2d4MxjPCnZX/NA2py5pmGNBHeSbujbSRX1 jB5VTqBEgmmKf2boR2YtVod412MnWrU= Received: from box.ssi.bg (box.ssi.bg [193.238.174.46]) by mx.ssi.bg (Potsfix) with ESMTPS; Thu, 30 Apr 2026 10:47:53 +0300 (EEST) Received: from ja.ssi.bg (unknown [213.16.62.126]) by box.ssi.bg (Potsfix) with ESMTPSA id 8F03660980; Thu, 30 Apr 2026 10:47:52 +0300 (EEST) Received: from ja.home.ssi.bg (localhost.localdomain [127.0.0.1]) by ja.ssi.bg (8.18.1/8.18.1) with ESMTP id 63U7ixD9027474; Thu, 30 Apr 2026 10:44:59 +0300 Received: (from root@localhost) by ja.home.ssi.bg (8.18.1/8.18.1/Submit) id 63U7ixTa027473; Thu, 30 Apr 2026 10:44:59 +0300 From: Julian Anastasov To: Simon Horman Cc: Pablo Neira Ayuso , Florian Westphal , Waiman Long , lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: [PATCHv3 nf 6/8] ipvs: fix shift-out-of-bounds in ip_vs_rht_desired_size Date: Thu, 30 Apr 2026 10:44:18 +0300 Message-ID: <20260430074420.26697-7-ja@ssi.bg> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260430074420.26697-1-ja@ssi.bg> References: <20260430074420.26697-1-ja@ssi.bg> Precedence: bulk X-Mailing-List: lvs-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Calling roundup_pow_of_two() with 0 has undefined result: UBSAN: shift-out-of-bounds in ./include/linux/log2.h:57:13 shift exponent 64 is too large for 64-bit type 'unsigned long' CPU: 1 UID: 0 PID: 77 Comm: kworker/u8:4 Not tainted syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/18/2026 Workqueue: events_unbound conn_resize_work_handler Call Trace: dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120 ubsan_epilogue+0xa/0x30 lib/ubsan.c:233 __ubsan_handle_shift_out_of_bounds+0x385/0x410 lib/ubsan.c:494 __roundup_pow_of_two include/linux/log2.h:57 [inline] ip_vs_rht_desired_size+0x2cf/0x410 net/netfilter/ipvs/ip_vs_core.c:240 ip_vs_conn_desired_size net/netfilter/ipvs/ip_vs_conn.c:765 [inline] conn_resize_work_handler+0x1b6/0x14c0 net/netfilter/ipvs/ip_vs_conn.c:822 process_one_work kernel/workqueue.c:3302 [inline] process_scheduled_works+0xb5d/0x1860 kernel/workqueue.c:3385 worker_thread+0xa53/0xfc0 kernel/workqueue.c:3466 kthread+0x388/0x470 kernel/kthread.c:436 ret_from_fork+0x514/0xb70 arch/x86/kernel/process.c:158 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245 Reported-by: syzbot+217f1db9c791e27fe54a@syzkaller.appspotmail.com Fixes: b655388111cf ("ipvs: add resizable hash tables") Signed-off-by: Julian Anastasov --- net/netfilter/ipvs/ip_vs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index f5b7a2047291..d40b404c1bf6 100644 --- a/net/netfilter/ipvs/ip_vs_core.c +++ b/net/netfilter/ipvs/ip_vs_core.c @@ -237,7 +237,7 @@ int ip_vs_rht_desired_size(struct netns_ipvs *ipvs, struct ip_vs_rht *t, int n, { if (!t) return 1 << min_bits; - n = roundup_pow_of_two(n); + n = n > 0 ? roundup_pow_of_two(n) : 1; if (lfactor < 0) { int factor = min(-lfactor, max_bits); -- 2.53.0