Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C37E13DB99C for ; Wed, 20 May 2026 13:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779285465; cv=none; b=UVEpNucegyYswc0PQWQEfeC2kYGuamet6BiqDgSxx/k/Z0Ksa0jBDN2VWO3Zq7+TjF/foe8Zp4Lq/TKEDXE576xSE5aw0/YA3uyPdExNPg+Aru4AE2WxxwwXOPaM7S4KsMu7cROHKjt691GXpODgNnkTwv16sXzf3l3RrEqaAdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779285465; c=relaxed/simple; bh=NJrZZSi0o9VWzREhhBEGRggS+ScI0rgS2bTlC1O7Evw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qgaTa1sREOKFz/5IKV9ByNt0LhHg86hci9aCZpnXmgMsH5b7bo7Eg/nbeMdn5V3wX7ldC1L9yjekzBJy1A5B+95eo8LpcJUGfHlbKkLWms35Ca+tpliE4mnpDhL0dp1uE3z4D7xMXqVJpPOZPGQcuPWZ7lJ8328uoXwk0nyvjzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OUZSvaYR; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OUZSvaYR" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3684a6f3b0bso2478686a91.1 for ; Wed, 20 May 2026 06:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779285463; x=1779890263; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TFCXqSHrRWZZKbLGMzbhUrsRJwY3I6y6cobGCV3nNZc=; b=OUZSvaYR8RTwyR9XMw4EhDOwBwaJQBdD4QbFQoU9tTljTaXKfN6H/aJE7QBLVsXS9s R96B4qmg3+IyqOOCli5vWDTWSKvX4oNJs5xqTRFVkSdyBqVNWNeWF6vxv85Nxjr4icZx 6bpiVOymdSrVUzYFFiTC1UoGhrwZPIigdnmtKLwiYwmVB/lvhG96rKYm2v4H3QRVQzyA usTOMY+3JwD33c/QbX8F3QEy71JgwdeyxkNV72CS968Li72K42aOJGyVx4YU23Ynuv06 RT77d0IwhFkQpXF4lwQGnfhpLtAen+31pTqjdjUqRjaLgWOUBcfJZ6rnf3g/PF7bccwG V6mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779285463; x=1779890263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TFCXqSHrRWZZKbLGMzbhUrsRJwY3I6y6cobGCV3nNZc=; b=nVCn5LCC4lAzfXEOVMYSQSkFrEmF98E07oISpxV5lBKP/FJ4Q/QMIMCW0ktKV7/WD5 n62rjE20UxPYAedK5HG6nn9IddEzynT2XHA1vy8euAUEt69XYGJThf5GKjFeuxk5RM/y Q1EapxHomzh4+/jkJj6Kjz5h/GjIVMmqiNPIX6Bz3XlYq5yIeGspqj2gQmPEn5oOKNmv fGXWmJcYI+gWItmntWs4EjF8FRg88HgYYaGa7wRNtyuBqxoRpJ/dJ0ejk4L91zCQOElY EryJSfGzYnRLQtKfMdpfgIfrN49cwOJJlrjdy0Ej6sl/GeGYgwfBNaH5vqVgl68ACnyt hOQQ== X-Forwarded-Encrypted: i=1; AFNElJ81BuO99bRIgAqJClUJCkE3aG2/3K3G6FmO4NZA/Q0QbHPNjI1i8C65Fcp5HqrMs8uw5noH2Ro2HJZA@vger.kernel.org X-Gm-Message-State: AOJu0YzrHVBXmUqB2VG29FDsP+AtpJb1igXJZ2zwUyJurFQglhcCxOPM ulKYLhw7M1FidSaQQ9y91SG0ywQWBeG03fl6oBbC8EVXiRwFX1/9bk9R X-Gm-Gg: Acq92OGCy/Sljmpcl+G1QE6turJDZD8zKU4jk/KaGOHo03MhgVoe08cX1W4OHmTM/qo sakxgODQviG7lx87SRJKphgEExAaYcpPgo3kpVnz52sKeXArmL+13XuWzTB5QhAiBe197JyEkRT dtL1Tp8FUTOaU9jrZbWPJwOaeA+KXTQHe3hh7BtWtGepPyM+qxH6Vp/WGIKlfwwHtCGicLJvKBd fJC9pZF5+hdKVsqFt0DhNIO/zAG5sPzPO8xMro8DTPEstkBUWDnWOoBHOHMoH/231lFdziROsE3 /OG2FZVftOtX0wS/wyKehaLtv3qhKVgBeOAinSCkW9B1buJwcEPDb0hOiSl2h+ZVgpVqmlWNrZ5 ZJuy7XtctCy4O1tG9d4ubdorAfQx0DBT7knhu38SwBD0f3Ycd2jJI4jZeOM64xjPx3Mz8Me76Ev 9CK8taKbfl6S23nSUEF3FF7M9UCjEPyXWI+Ru2MK8NFovPuCuGnA== X-Received: by 2002:a17:90b:4a42:b0:368:3830:a8bd with SMTP id 98e67ed59e1d1-3692345e3eamr25930138a91.7.1779285463062; Wed, 20 May 2026 06:57:43 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:5b11:a58f:5208:2fa7:bba5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-369572e1007sm7480867a91.6.2026.05.20.06.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:57:42 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v7 6/6] leds: is31fl32xx: Move pwm frequency setting to init_regs() Date: Wed, 20 May 2026 21:56:59 +0800 Message-ID: <20260520135659.1430008-7-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520135659.1430008-1-jerrysteve1101@gmail.com> References: <20260520135659.1430008-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit commit a18983b95a61 ("leds: is31f132xx: Add support for is31fl3293") swapped the order of is31fl32xx_parse_dt() and is31fl32xx_init_regs(). This causes the PWM frequency configuration programmed in is31fl32xx_parse_dt() to be overwritten by the register reset operation performed in is31fl32xx_init_regs(). Move the PWM frequency setting logic from is31fl32xx_parse_dt() to is31fl32xx_init_regs() and separates device tree parsing from hardware initialization. Fixes: a18983b95a61 ("leds: is31f132xx: Add support for is31fl3293") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl32xx.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 2d7ff4c5a08c..c545a3b7a05a 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -63,6 +63,7 @@ struct is31fl32xx_priv { struct i2c_client *client; struct gpio_desc *powerdown_gpio; unsigned int num_leds; + bool pwm_22khz; struct is31fl32xx_led_data leds[]; }; @@ -346,6 +347,14 @@ static int is31fl32xx_init_regs(struct is31fl32xx_priv *priv) if (ret) return ret; + if ((cdef->output_frequency_setting_reg != IS31FL32XX_REG_NONE) && + priv->pwm_22khz) { + ret = is31fl32xx_write(priv, cdef->output_frequency_setting_reg, + IS31FL32XX_PWM_FREQUENCY_22KHZ); + if (ret) + return ret; + } + /* * Set enable bit for all channels. * We will control state with PWM registers alone. @@ -420,7 +429,6 @@ static struct is31fl32xx_led_data *is31fl32xx_find_led_data( static int is31fl32xx_parse_dt(struct device *dev, struct is31fl32xx_priv *priv) { - const struct is31fl32xx_chipdef *cdef = priv->cdef; int ret = 0; /* Driving this GPIO line low takes the chip out of shutdown, @@ -431,17 +439,7 @@ static int is31fl32xx_parse_dt(struct device *dev, return dev_err_probe(dev, PTR_ERR(priv->powerdown_gpio), "Failed to get powerdown gpio\n"); - if ((cdef->output_frequency_setting_reg != IS31FL32XX_REG_NONE) && - of_property_read_bool(dev_of_node(dev), "issi,22khz-pwm")) { - - ret = is31fl32xx_write(priv, cdef->output_frequency_setting_reg, - IS31FL32XX_PWM_FREQUENCY_22KHZ); - - if (ret) { - dev_err(dev, "Failed to write output PWM frequency register\n"); - return ret; - } - } + priv->pwm_22khz = of_property_read_bool(dev_of_node(dev), "issi,22khz-pwm"); for_each_available_child_of_node_scoped(dev_of_node(dev), child) { struct led_init_data init_data = {}; -- 2.54.0