Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 993AD366075; Wed, 20 May 2026 17:13:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779297192; cv=none; b=J/sZBQ75L2vmUFwAQSFif+VHLB2b8mSOiLdXtkT7U8XPSYUKaaZ7jA0gYJiY9tVYofXyY8M2EXHIOSH3nlUU/8oF3Bgjjv4S8D05bRHU2rwkX97tKlvgQoG6FIgp3YNNw5rYurdV0kj+CD1u1Xn5VLWTfBZ7eJ+0e/ltC3JWhUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779297192; c=relaxed/simple; bh=8JkDuIbHKsec7QC6vcQYCZi8rXjeBqCd1TKgXR9yzWg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BzWJE0SoEB3Bq7E8BSZGEd0Cqqopo57y23JmzmRmBlg5XIeBu0z6MHXhRPmBxLSVUYsBLSljCMCX8C5jAMgPVOUs32F8FSanmV9sSKnrqB37MJoTfDSH4Lfh7O7z2d4oo/DWzv5zUm1L3NBATwkHEmWMi6ZXfJb223iBIjgtP/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=S3P0fnso; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="S3P0fnso" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF8A11F000E9; Wed, 20 May 2026 17:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779297191; bh=Vtf7IKcxofoa4/HPlI+A6CzBBVYAZwF0CStp2QlKtmY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=S3P0fnsoMZ6VDmIAjVSNEPkV3xFXtPcfzN2O6wiz8k1YaqFZe6+JzJDIktFq5JHYk p1tG5WEYrBkAt6l4zpHUvB7tvNtDgxm/XpiAPmhNwuMjPfN7redpjGiN/lyfwZbNON D7LaL2RF3EHFZza5OM8/33xLz8BXJVeK7+i71MU0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mark Pearson , Rong Zhang , "Derek J. Clark" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH 7.0 1083/1146] platform/x86: lenovo-wmi-other: Zero initialize WMI arguments Date: Wed, 20 May 2026 18:22:13 +0200 Message-ID: <20260520162212.744819955@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162148.390695140@linuxfoundation.org> References: <20260520162148.390695140@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Derek J. Clark commit 816fbd5dacee977ca56bab79bf97f71f2f7ac24e upstream. Adds explicit initialization of wmi_method_args_32 declarations with zero values to prevent uninitialized data from being sent to the device BIOS when passed. No functional change intended. Reviewed-by: Mark Pearson Fixes: 22024ac5366f ("platform/x86: Add Lenovo Gamezone WMI Driver") Fixes: edc4b183b794 ("platform/x86: Add Lenovo Other Mode WMI Driver") Reported-by: Rong Zhang Closes: https://lore.kernel.org/platform-driver-x86/95c7e7b539dd0af41189c754fcd35cec5b6fe182.camel@rong.moe/ Cc: stable@vger.kernel.org Reviewed-by: Rong Zhang Tested-by: Rong Zhang Signed-off-by: Derek J. Clark Link: https://patch.msgid.link/20260510042546.436874-5-derekjohn.clark@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/lenovo/wmi-gamezone.c | 2 +- drivers/platform/x86/lenovo/wmi-other.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) --- a/drivers/platform/x86/lenovo/wmi-gamezone.c +++ b/drivers/platform/x86/lenovo/wmi-gamezone.c @@ -200,7 +200,7 @@ static int lwmi_gz_profile_set(struct de enum platform_profile_option profile) { struct lwmi_gz_priv *priv = dev_get_drvdata(dev); - struct wmi_method_args_32 args; + struct wmi_method_args_32 args = {}; enum thermal_mode mode; int ret; --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -165,7 +165,7 @@ MODULE_PARM_DESC(relax_fan_constraint, */ static int lwmi_om_fan_get_set(struct lwmi_om_priv *priv, int channel, u32 *val, bool set) { - struct wmi_method_args_32 args; + struct wmi_method_args_32 args = {}; u32 method_id, retval; int err; @@ -772,7 +772,7 @@ static ssize_t attr_current_value_store( struct tunable_attr_01 *tunable_attr) { struct lwmi_om_priv *priv = dev_get_drvdata(tunable_attr->dev); - struct wmi_method_args_32 args; + struct wmi_method_args_32 args = {}; struct capdata01 capdata; enum thermal_mode mode; u32 attribute_id; @@ -835,7 +835,7 @@ static ssize_t attr_current_value_show(s struct tunable_attr_01 *tunable_attr) { struct lwmi_om_priv *priv = dev_get_drvdata(tunable_attr->dev); - struct wmi_method_args_32 args; + struct wmi_method_args_32 args = {}; enum thermal_mode mode; u32 attribute_id; int retval;