Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D802CD5BA4 for ; Wed, 20 May 2026 17:30:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9DD3A10F112; Wed, 20 May 2026 17:30:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JXyB3GGr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id C786410F109 for ; Wed, 20 May 2026 17:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779298213; x=1810834213; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=E4ANuDXJJo9pYbQTi9QJnK07ZECUxytc09AWrvjBa3o=; b=JXyB3GGrVspcIXU3iFBuP4d5+EhFST6B58faOqRsaQBYHvSppSH8ZyxO 4VX1ly+9PBJcSi+crBD8241ajt0IVxiqdzvsQv4HGxcIgcZ3VBPKiNxnk /WFVDy0eAgDsP7HQqXYSUMTvc26JNW/r8y7GdpiR6oRSRFBrL8kN/OeRh IHs8j5yuSeorh3Gk8KPLq07wS6ecBkz3UmYPz8+iOCwHa9N3RkAEDpCMN UMVGbqgi3kavq0vU8HcRlpCLXIrCm0wXb5jxmQiL5C44FCeSItUN81row Jqx43dtjmyvfs66I4VechbrPHvWQrKEXgusdLXj15eJj7XjkpfjAoDty9 w==; X-CSE-ConnectionGUID: 9nmfL48WTh+avifNIGh5cg== X-CSE-MsgGUID: xz+7oX6OSpmJID4mETBnsA== X-IronPort-AV: E=McAfee;i="6800,10657,11792"; a="105667665" X-IronPort-AV: E=Sophos;i="6.23,244,1770624000"; d="scan'208";a="105667665" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2026 10:30:13 -0700 X-CSE-ConnectionGUID: kCZHSq1xRXiYQOHq+tAhTQ== X-CSE-MsgGUID: /FkP+X7BR7KSibc0dcN/YA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,244,1770624000"; d="scan'208";a="270598173" Received: from smoticic-mobl1.ger.corp.intel.com (HELO mwauld-desk.intel.com) ([10.245.245.159]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2026 10:30:12 -0700 From: Matthew Auld To: intel-xe@lists.freedesktop.org Cc: Daniele Ceraolo Spurio Subject: [PATCH 10/10] drm/xe/guc: toggle paging engine support for NVL-S+ Date: Wed, 20 May 2026 18:28:57 +0100 Message-ID: <20260520172846.291708-22-matthew.auld@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520172846.291708-12-matthew.auld@intel.com> References: <20260520172846.291708-12-matthew.auld@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" NVL-S with newest GuC should be the first platform combo to support the special GUC_PAGING_CLASS feature. TODO: Check the final GuC ABI version before merging Signed-off-by: Matthew Auld Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/xe/xe_guc.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c index cdbcad79b060..16a9ea8deeb3 100644 --- a/drivers/gpu/drm/xe/xe_guc.c +++ b/drivers/gpu/drm/xe/xe_guc.c @@ -1848,6 +1848,9 @@ bool xe_guc_using_main_gamctrl_queues(struct xe_guc *guc) bool xe_guc_has_paging_engine(struct xe_guc *guc) { + struct xe_gt *gt = guc_to_gt(guc); + struct xe_device *xe = gt_to_xe(gt); + /* * On newer platforms the GuC now has a dedicated engine class for the * special PAGING engine, which is the driver reserved BCS engine used @@ -1856,9 +1859,8 @@ bool xe_guc_has_paging_engine(struct xe_guc *guc) * engine here, this purely a sw view in the GuC itself, which we need * to respect. */ - - /* TODO: Have some way to query this from the GuC? */ - return false; + return GUC_SUBMIT_VER(guc) >= MAKE_GUC_VER(1, 35, 1) && + xe->info.platform >= XE_NOVALAKE_S; } #if IS_ENABLED(CONFIG_DRM_XE_KUNIT_TEST) -- 2.54.0