Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27B49375AD0 for ; Wed, 20 May 2026 21:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779310831; cv=none; b=qmu2CZqolHe61znoDck7PjsT6IRTtjOsqRxC+JyjTZU3BKfgGN5IBxha9AQJt60RqA9AniOTDBdMoK78y/g3sI+iwKB4Qw93zrIyCDs/fc8tyInZJKaj12WcZa4Vvgu/Va72aZaJxGjNFFZBh5OKTMUuml0c2PDk4Fdai88efws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779310831; c=relaxed/simple; bh=ZGOU1vQ/drVWDurk8croKUjP74FWpTfm1pbAYUn2Okw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sN4UMWwVa31faUUCXQiXB6HjZGQYfQDA/ASSvEKy9hklk0HkeoI2cOoDrbEzPQdGv0dT5OBUNuLojwL8OgcWCqfYwaY3iiAVq9vzsaDUAKxD0VZrshJ34kfnA3ja7Rcghc7ELjw4pyfnOfb6xfHtKbQktxVCzS3s7dmXn8qhht4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hCT7yubU; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hCT7yubU" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ba21d32776so38455365ad.2 for ; Wed, 20 May 2026 14:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779310829; x=1779915629; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0+w/6O06al13m4KjZS8ZlckD5KFM3OymOCn+QhhhktM=; b=hCT7yubU14sisJ8ogDAqTxUyrQ9e2zndSFKIS0xuKgCruYqiywnrssVmgtV0AQSdD0 Lf1sgF3Scj/68MgpcqeVxr91muuQJ3EvoABzRgMrYwtjd3solPZnpuvfz4cIgi+7hgeS FG/KPnvqVAIYloJxMD9bY6wupwzYyXSr/MrAaYyHI3QTkTonj+7IfC7PPHK3o99WEbve J004zRRHbf0f491Wds58n8QqC+FiSU4uR5FxxuQLE0+Iwcvon+BK9PN4D1IFsn1Q0WEc 2rA6Gjt2HhGXMuBRIDr1FbSTe4bPZkqVX0ruORqebzyAZWzQg0t1Ci5hfB3jdu25vPBa /DiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779310829; x=1779915629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0+w/6O06al13m4KjZS8ZlckD5KFM3OymOCn+QhhhktM=; b=ZJ++lUJnZt9rum674cgSHZCiS1I7Jhxh+fbpar94O0FVTWRAS3W1kEONzQ5InfL1xY Onp2A1G1Y5czSxB3eUTRfvfvAPT+UG29tWUpdteXDzigFYuhwAg9N6iojVlK+0qwyY7R RvmiUnYgle696L2uGh22sGRl7X2MhaZ+ehg+yCJsSklLkVDkx8ztchaBruKYEKoRhn2s B9LruSZQTNZNwT8s+CFMYzX3KcuA4UTuWwORvBps2UFJ8AEx2oe2HkdiTcHbGm9ZliBq qea0k4JMEwF+SNehIQFtEIvDeSxBxE/L8crDe8ROaYU1UosRq3JWI3/weGiNp5aIeqUq lXZQ== X-Gm-Message-State: AOJu0YzpaSBSxr0eJhiW7qTKs0pF1ZpjXYXwdltHoG1ghACHm1y8K0ED pyXomZNURgMhtkSsVq+zVB+qjEK3v3hf4oW02ugr75nslqdPLPSCzmJD X-Gm-Gg: Acq92OFoVKsLK9AkuczNUNDR25UmYAcysd/q9wXk/iZG4rZ0w059qPgd2Rmk62WnPe+ zo8NdapF3AIVNfboajqocHG1IEMDq654BdFFJhDtdjt4wHsgu2+E/QJVqA6ETiruAw6IFgUc1Z3 WzrXduuQM2doKGmz0HSB007sktuFdDT4rvYV89bqsN3GIfx+Ht9el6ic/I0JNsk+nGBfIR18nkv f7cnFxT4vlvkoXagLvbyfbW4w8dExLclnWOBCEwz78B3L4iPo27Iw3jgNdw0kjcqu6zN6xHx1Nh svz+RC6aD2j/kb7jhn6+bvRa9KAJMGCQ/VXZdwG+YRui+jTqElbEKGM4gvJaD9A8ix/txVov0dX L9DA1k6s7SoroF2VNH3R4y9A5adA1/7LmwjeC8xs1x+agcN3T164PdJTZ9I7NVpCdAlBirytN// Nampoo2v2cxrcfJd1cAJIhref6g44ErIs5OroAaUEmKB6VprayPStb2StZb2gZHJ5W+0aKNsi/U iiS5XzEQOdOKCID5C25gk1/O80VEHOR7xwwUUWpgPhTW74SMIXhMa8eOvc5fAyVfA6kUCoahhOL OD+nFcr4OfQrMHo= X-Received: by 2002:a17:903:3c30:b0:2bd:7ff4:ab0b with SMTP id d9443c01a7336-2bd7ff4b216mr270260545ad.39.1779310829236; Wed, 20 May 2026 14:00:29 -0700 (PDT) Received: from codespaces-78f0a7.2t4prynt4dlezbzls5ze3dxsqg.rx.internal.cloudapp.net ([4.240.18.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fc47sm222229175ad.10.2026.05.20.14.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 14:00:28 -0700 (PDT) From: Muhammad Bilal To: puranjay12@gmail.com Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org, eddyz87@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH bpf-next] selftests/bpf: Fix zero batch_hash on CPU 0 after batch_gen wraparound Date: Wed, 20 May 2026 21:00:14 +0000 Message-ID: <20260520210014.43330-1-meatuni001@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, May 20, 2026 at 4:53 PM Puranjay Mohan wrote: > A single batch runs for 10ms, and batch_gen is incremented for every > batch, so for it to wrap we need to run the benchmark for 1000+ years > with a single producer. You're right, the wraparound argument is not practically relevant here. > On CPU 0, consecutive batches with | 1: > batch_gen=2: (2 + 0) | 1 = 3, batch_hash = 3 * KNUTH > batch_gen=3: (3 + 0) | 1 = 3, batch_hash = 3 * KNUTH This is a valid issue. The proposed change introduces unwanted collisions between consecutive batch_gen values on CPU 0, which is worse than the current behavior. I'll drop this patch. Thanks for the review. Muhammad Bilal