Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 056AC308F23 for ; Sun, 31 May 2026 05:55:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206930; cv=none; b=iMCJGZdnTAAWrKxbpIyQc5f9Nh8K+DsXAoKyGP9Ksy6c7Na4d3Y1sp7wWGWV4/mskNZ+ciEUmzMZceLQpk+Lj6uQBYOn6pPObc/vp+XUQ8GpA4WSA28CVOB/OcrSalrp6KGtBmzG7Sj2Jr0cH4rViRA3LEJ3WZS3xfeXkVSrgvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206930; c=relaxed/simple; bh=aWWHzgXXbLhAdPIfZkTluIIEU0fJsmuZG+EK0Mb9zUY=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=WU1WtCcrEHAgMo754FuXpqE9qsS31X/tPtL7ITtP394rZFwCJtfbtzYMGp4xSHt8SCLW7ZVn5vjGYHF736jQEFJX4S4r4Z7KnZrJCIFD5ifYMg6DmR+r1SKH4ICrGjljWGc0cIPjY/3fQljQv90QgjEQRlc3pc05V8Ojxt8lh4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LJZfuWf3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ri1P7tvD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LJZfuWf3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ri1P7tvD" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V3o5fn644707 for ; Sun, 31 May 2026 05:55:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=gDsluyIYqDzR/a+ynOYZLg EdTtTH0lfZipUYx9zJWus=; b=LJZfuWf3PvImEjmJ3K7K/vTm9ea4e5PmEyJleJ bLrkVTBxfnqBE1n4UvvwAVC97wccoNEY9KajsRzPgCnPBwhyxzFKTS9ll6E1VAJs 9t/hvuPM8Az5o5vP1toHRShddYm8fVhw/7gAYC+tJoChgXqrVzgbl0gq0b3q7ICp VttrSkIMQ0XMfMB5rlIctkEMNOdizFxymIWMORncL+888Qw6R675EgdGv72VQyX0 7hRDqrrqdAnHykJuE70bZEviM/vUOY/UWBOqsGjXKix8ihiY5wP6FSS6Ov3gvneq Rn2PQRFNeE601Ky/thE6sbWKQ5UYVO3KVFQgn2s6z6BvAn1g== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efqyutvj3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:27 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bf3636d6c0so12163225ad.2 for ; Sat, 30 May 2026 22:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206927; x=1780811727; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=gDsluyIYqDzR/a+ynOYZLgEdTtTH0lfZipUYx9zJWus=; b=Ri1P7tvDQYzlsryMy8hP4GUQ5YKAgYS8JlaGvBAVWlZnHQqKdZatbQVviYWebnz/wJ 8Va/R73BqbgoK34TlY21swbRn+znCNrF/xmf4qFtdKkTyTtiiMclAXtmRhQDaRFiqo3M D02SXPwuxbLNh9JBZVcJhO9mg8NMHgc9KZDiAwNyFqK0zlHBUoLdxNlBIGpO4cHNdbj8 nBWRV5SRSB8svpNI3el5A2Jeu164d6x28Xz1ybGR0FWTZaIAWZIEPgiNL1oNZscnImfi Rbg1paElpwyL7EDl1eb0iap0N5O1uWNylSUsVGYQdiZMgIcYdu7f/CM1n2un/4yYlCeq Fopg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206927; x=1780811727; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gDsluyIYqDzR/a+ynOYZLgEdTtTH0lfZipUYx9zJWus=; b=lnEKaj/LWm5zqpLa9ULbllNfl1pehGc2J+dv/3ksEUhDB+t4P7jFYnPf3OHXl1RkEZ PT9fk7RC4p39+9FiRgsIpQco7lCIA6VLXyFTvAiC+vBH3v+sYCV0hcVOLd8p9WZcwc3c pC369f7zttAgEjUgzU0Nk+MBNLERNMZS61ui2/LpGSgo7v+Vy8aubROqcywLTTluC5az AzRrneo7azgN9D99XCcBmxiGYBcF9h08usS0tVV+Tv6WG2/X+CI9FwMUD0zDWP7oDmKg tTHQp37OfaV0HMedo4hNuezM8bANxBVYVW4lm5RtW8INSd++iWMoC76NCYEMB/sl51Oa YAig== X-Forwarded-Encrypted: i=1; AFNElJ84dK/AOWt6AhiIEfcvW3PenGJaDDyg+UzNbmsg/jM1N4k2NSiOwxDaMmNJLw2TaesNwdIh4Ua702pyISKi@vger.kernel.org X-Gm-Message-State: AOJu0Yx0TFmal1VuOPzgfp+NbS7dupv0mKrPseyMOSBhaF2G4CYxZeJ/ BV/iBs1a5aozfc9f0ci9BRFKx9Pn1u33QeNwrDtyuzxINOYrvsQhA6+Sy7mnpWY3v5u+s03zwR2 m2BL+V4SDxPagl5wBsoA3gjhW1rEGmSCHOjbRBFmI6gT/ePypiDV94MRe2yYcfWbDYchlLNT9mg 6p X-Gm-Gg: Acq92OFf8HhPHccADJqkOohEYizpAwT78//mbhxzIbRiczLFLJgEwr3J7e5omwcVfvM 7HikVnX8npgNq7LKN6SaQvt1zjj3+ypgK5ER724OT5kTEP0KI50pqJNxONa6m911k0lTj5hOc0a QFMLfyP5+EYHtyRlRGDJH2RDawHuM88yFP080UaouJpbnspX3QmzfHn0s93UUMeoYm8a5CacHVL kWULGshVCf28RCEyLL0jOqQ4QV8RdoygUhuFRQKLw5/8/p1uRkrWRQgc/PbkgVCwVPUpSvEf/9L bATdmocBDC5ZHcb678mboPPUJk6+ZJIQRsCHBIkJsbBo+fiJ6karnudROV9HjNvbJnSInHamOyn 3ALSEaf6jwnaKHjxdWQMGvkxrq2mtXV7Go0SVFJM5uil/IXhr3AgTEjHT27JpgF1K6g== X-Received: by 2002:a17:902:d4ce:b0:2be:3626:dd42 with SMTP id d9443c01a7336-2bf36793909mr72969555ad.6.1780206926766; Sat, 30 May 2026 22:55:26 -0700 (PDT) X-Received: by 2002:a17:902:d4ce:b0:2be:3626:dd42 with SMTP id d9443c01a7336-2bf36793909mr72969275ad.6.1780206926294; Sat, 30 May 2026 22:55:26 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:25 -0700 (PDT) From: Vishnu Reddy Subject: [PATCH v3 0/7] media: qcom: iris: miscellaneous code-quality fixes Date: Sun, 31 May 2026 11:20:34 +0530 Message-Id: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIACrMG2oC/x2MywqAIBAAf0X2nGD2IPqV6GC61h7UWCOC8N+Tj sMw80JGJswwixcYb8qUYoWuEWAPE3eU5CqDVnpUQ9dKYsrSJldFODndGDBesp+M8QZtv7UOans yenr+77KW8gFChORDZwAAAA== X-Change-ID: 20260531-iris-code-improvement-48aafaec4b1d To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1857; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=aWWHzgXXbLhAdPIfZkTluIIEU0fJsmuZG+EK0Mb9zUY=; b=OORsXq3AGT0po37yjAg5EC8K4ArUSATmU9qRxgmdPS9f0JiQYawNF2ixwY19woAdf/8Iv6gxU LQY4RIGm2SRCOTodSB+LMrZi2Jdwki79UetRXLF00xO1OFw1gavoQe7 X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfX5fhO7vdPOnEH rO99Gof5xgHwzOPmtpO22aREiKMFO4pm8a3Mszr5NTxdRfAvggyUyRlJNvZiVvST5i9MKcTV7pU dxmHbsvuFIMIh8yXQ4rxQOh8K7nqp8/TTq9ENJz5PkvofAYf5NLNK+fB0fp2WznMmmwTjkrVui2 lW8lqqxo5Ld9sB9mXAdDITjBq674yoEv4ic9yUIj7dnjqSjp6xk3L4V6gRqWS5kSsII0K//Avzl XGoSrDBIUk4PvgxHatoYap9E5auJ1BfSqReMSOdYI764Y8pNlYSaVfecbiLjt6Kb5SlG91d/L0k H1UOZ//r7nb8I9yB0cuKDmn3MOlCAAXw0/2Gn5HG9aWeD7qIRPZVXLxF7A9peJ5bkHd6n6MASqg LnmacVd4bYZrQcOBQA3+EyTSXFj9TEw+VIG8Q443IQ0OESZ2P3qjMiiIB19WtcZxEcPWY3JoFXx byWp/J/A64NCF+wAk4A== X-Proofpoint-ORIG-GUID: IM4lj6UtiDJJduRFvuVB-MW6pmoxyggY X-Proofpoint-GUID: IM4lj6UtiDJJduRFvuVB-MW6pmoxyggY X-Authority-Analysis: v=2.4 cv=B5uJFutM c=1 sm=1 tr=0 ts=6a1bcd4f cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Z3I29kXYegTyEPjnXUAA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 This series addresses a set of independent code-quality issues found during review of the Qualcomm iris video driver. No functional changes are intended. Signed-off-by: Vishnu Reddy --- Changes in v3: - Rebased and resolved merge conflicts (Bryan) - Link to v2: https://lore.kernel.org/r/20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com Changes in v2: - Updated variables names for iris_get_int_buf_tbl helper (Bryan) - Removed un-necessary fixes tags (Bryan, Konrad) - Addressed other comments (Bryan, Konrad) - Link to v1: https://lore.kernel.org/r/20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com --- Dikshita Agarwal (7): media: qcom: iris: Centralize internal buffer table selection media: qcom: iris: fix state-change debug log printing stale value media: qcom: iris: Fix bitmask test in iris_allow_cmd() media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec() media: qcom: iris: Make iris_destroy_internal_buffer() return void drivers/media/platform/qcom/iris/iris_buffer.c | 123 +++++---------------- drivers/media/platform/qcom/iris/iris_buffer.h | 2 +- .../platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- .../platform/qcom/iris/iris_hfi_gen2_command.c | 7 +- .../platform/qcom/iris/iris_hfi_gen2_response.c | 4 +- drivers/media/platform/qcom/iris/iris_state.c | 4 +- 6 files changed, 40 insertions(+), 102 deletions(-) --- base-commit: a96fcde9fa9a6696991d1f172a8bc2bade82a6d9 change-id: 20260531-iris-code-improvement-48aafaec4b1d Best regards, -- Vishnu Reddy