Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76593322B8F for ; Sun, 31 May 2026 05:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206943; cv=none; b=pyyS4JFNYOJkJAW1v1Sg+lX0pC+9Y3GLuoln+pWb3PAwkhmMelgvpTJ8r184DfQx1MZ88+PIkAr3E8sPYhXdFhS2FmwD3iphTs5SFwa7h4FSfEoGvm7j0rZ4+Kdnk7Xzpyw2As1HGKtL+Z5qaUS9zVuxeUQ46zCX8yZdpmH0RqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206943; c=relaxed/simple; bh=XrExrogGyNY8zefzhUS+pWbzmqCVYgThgf2zASOamL8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mzobjzCov22/5oQYEofxS3pxbeRVNa+EegvR17QcFhxM8isFDJ4ADXiW1+n2drAU/0heAMZawkqNTe/iLwATFuTEPT70kRQE9/Dl5qf/Uop7XnITwQEAY2AAUW3uUdkh3wHjd77QudfQh94D8VYYRNxc0/7zHMdWO6S74gMzE1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z9335Ei2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g492gi1u; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z9335Ei2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g492gi1u" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V1inNP3115919 for ; Sun, 31 May 2026 05:55:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=Z9335Ei2cE9IT7R9 B0ZWeVG8LC/oACCwxbnVG8y/sXZ/gVBXtRY6uGKvKytbQnQ5ug3C0P7cFndGKcqP qRvGEPAfKqfqn0B0oVEmDmHuPM4tGbr/MPNvHJXZZecJpPUIloTPqpbDna7860fS UUDRIb1Grt0YbJkM+oP+RpCOmm1JOEqHJKwnancsZvNe2UzAVPJhm969c3QGMdAO Hi7xlQke/qodnS9rjpNcWWR853coBFEd648QDvz02tjQrZ/Q23hGSHhvBZJ5Ybaf 1InvIpFl5hZZ75pPUafHo1gE6kmsFwxwBA/siv7lz3if7lF3D5i4fgb6K9h1wuO8 59GTeA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efr41ax71-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:41 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2c0c20f7581so3510855ad.0 for ; Sat, 30 May 2026 22:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206941; x=1780811741; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=g492gi1udpsyo/idnz5wAVzOUBoJkr9yrDpdzufOjg2OUHG4cWjse7wQe+DSBnPqQm P5kb6UbArLyuqQFaJykC6iKOh7O05wt86vXj0eY5snuj3FYOeGkFLyxQzsVEt7bVM0Bc iEAAHUtI4c2ME4ESCydXAmWpHx5/xwyZehpti23ZZp9FhJAwywnBYnYtFgZJcjwz8TwZ lpVh/uZqSV2Du04PDATrJ/u7gGXK8X1LbzggVAm8GTFNe9HV45qC6FQL8vS1V4qvOXFe owln1XxLh6XmrpPC/I8vvO1S6ZCuevvVqR5VG7oYUiOHQ1igODYRc9qL1wzlW+x2wdpW YqOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206941; x=1780811741; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=NUzz8pvjzNph1rtwQO2L3Sj1DO95Ac8QBeY51SsHYlnHvQa7ulSgGhEOUWLAO+Bgxm b284E/3aIDgRNN2BYxQYVGZi9s/0aJ9bVddMFW7eMTXyc6NOvNcgsZi027AZ4Pe92Qnd TBOG76AVNW0ibe2IwMmmr3iAy0mebeO1ofpeueTA+mCt2yfrch07ZO+LiYbfX0QMpZBO yIZAABYZHgt5ttJlEDDmqJ49vB0KbVJsHYBUgfycmApGLMgc+4OVeqbIZfUOd0Haamth 8TycrmHe/G9INhv2rVPWkuYlisrvoVUV/DYoxqUMsDqA7xYJgHEZ32LLe5AB64K4+Z27 OdJQ== X-Forwarded-Encrypted: i=1; AFNElJ8HO5hRRZT2LZg8n3aNk80yoBRXQDl4CApgB0qr7rMVfh2a4eJEm8BHUNnWp4PG0tUjCWkOeu5BwHZ04xGm@vger.kernel.org X-Gm-Message-State: AOJu0YzQZdoIAEmv62f/NST21hluPd9qSapXYKOP3CLLTZZIo+5QxmTe bSbhInoLLj5+0qigQGkdllZp97+CMC4n/xVkhsEyiXSwuys1JffAxarHLIqeES2xJcLJXEJ5YT1 +/bw/MhhRStL+EP/52pgEhDzZtyO7J1xTrDRWnQLHrfng+gi2Wv0DOA3wHCNULfFHtlPVCS9jlw mq X-Gm-Gg: Acq92OHnpQIKIJBvdk0OfpJclgf41pBE1nYrx9kw09PBnfOMHRntbkCRA3lyF7whotP P9C7uP7+xt2eL/HxgHVx34SWoxyEwJdmWOfqbdUCBHYQ8erh1HvB/pR1MMR+WWKKA/NAY2STM4k OMcPsEICxlL+UmrRLqZn4JNACD3HEvfIAAxRQfh2oM8fGaGfOOjCUjUcp7mzKEHPVuwxMmSxEkZ lBb2U51QqGaktHTOTa3/cXJzuCfxehKPVYoJhLsREBwdPmrMDbhX1fiRcS8Hfb30xun7p/HolWb Q1qix4kE4QJfDWgdU42oilZW+CpuOrmN4fJrdUDg+55oa/Udj08MqFaYthjy6FQOz3diMxaLTAa Xe9/XDWNvX53NS/iDf8TfEOamdFNwZYtdPzqCTw3EugbUipjo00RGv9KgllWKbgPzSg== X-Received: by 2002:a17:902:e887:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c0a7467f47mr54864265ad.24.1780206941176; Sat, 30 May 2026 22:55:41 -0700 (PDT) X-Received: by 2002:a17:902:e887:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c0a7467f47mr54864035ad.24.1780206940705; Sat, 30 May 2026 22:55:40 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:40 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:37 +0530 Subject: [PATCH v3 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260531-iris-code-improvement-v3-3-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1251; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=iUPNcmr9LcDxjiMweUrnUvGUJcwSJce63MellJNuucw=; b=ezIbKToaQmXP9xrtCwyXd3cvyElME/u6McvNG0gJrzRBMRPzxp9VgdhzZ1lVOin6PB/Y4Q1uf KI5UOD0wO2NDhzuNfub60AKW9lZcLUwelb8Wff/DO4ktese6hNlqfQw X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Authority-Analysis: v=2.4 cv=fOEJG5ae c=1 sm=1 tr=0 ts=6a1bcd5d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=qiYeaxkneK40FgSAABkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: gcc-Ql2dDGLWJM7qmQj4-r4ZK9MS9sqv X-Proofpoint-GUID: gcc-Ql2dDGLWJM7qmQj4-r4ZK9MS9sqv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfX1rWEDx7e6z7v 2u91L8tbmH0IGgjuC/TWXjAbqthqdQVrUGbfHUu5yKc41mdHQ8MpVz4yuHo1nncpSNTxOYVBynv lqzTaOg0efhJ+uxwhtNr44nhZ5DoVZ5nIWmtFdxOTcQ+f/SJEf7V5nKbmmccetrb1KTTScqp4pY b4mW1Pc4bKs+b0AOU1pggv/gbujW1zbsBkMYb1ZEgx8XDzVoqddVYcUCEjTfUxxj1TYvwbsvE5p hpyu4RMEWA4vHfdvxqnPqQJtU2VuRvN7LItFTBy/rrRP4ws+Dw7S1wojPauAnzLTa4dFqs1sAst zHtA9inZ3mXTTPRFVktGxEOrWFLQbPbQIo2XFOxxXU4AxpjIfvTB41B/IVgLxBMNUSvcjEAwPXL TSeb+NbQfXszZO5PkNDhsnV+47Q3mm2QWWP4DiAcZGqcDRooVCGm/ZCU9P9kCMGz6fjxBDdxLQL OtFQrbnDUFLPx5AgM+Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal iris_allow_cmd() incorrectly checks a sub‑state flag using a logical equality comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c index e991f34916ec..5552725c614e 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd == V4L2_DEC_CMD_STOP || cmd == V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state != IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } -- 2.34.1