Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF6E0CD6E52 for ; Sun, 31 May 2026 12:47:37 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3B8353C86D9 for ; Sun, 31 May 2026 14:47:36 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id BC4053C743F for ; Sun, 31 May 2026 14:45:52 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 0B2FD14000A9 for ; Sun, 31 May 2026 14:45:51 +0200 (CEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V8jA5H2415657 for ; Sun, 31 May 2026 12:45:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=4jcCa3dDYXmzlp9ex T4NfU0Pzg+uDKotkGkGeDcTcmc=; b=q/2N3X0sFEFs7ozTgFHcETS2rSG7aYRBG aNMj8fMQAEsmjGLC2pAaVzZFh9NJVs2xRBJy58mtfspF//TWF1482DrTIyOpTG24 sryQcjym1cD9YqD4rvcYS3UZHooIlgNxAsWZuc6n++ZAEBgeT7HX6PhWlkXBn0uN r9Sj8wTP/s3pDeHMHWjBakgfX+fy+spSZEa5fyeXCc2PqK5EncWXTO/0/3XNXODp qkfwjaD8sGdiLFmseik0dJCh5enyTLcf635oMcW2C0uQhVMzrh55Y8qwQ5Ny35pz Ay+aLsGDBNvEkW2lOI9vD/uIZSVm+T4a+Uk1rK0AIwCZTVFKL6f2A== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4efnahcm46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 31 May 2026 12:45:49 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64VCO8OV031805 for ; Sun, 31 May 2026 12:45:49 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4egcwy1dye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 31 May 2026 12:45:49 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64VCjlJ327328996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 31 May 2026 12:45:47 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F16820043 for ; Sun, 31 May 2026 12:45:47 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C677920040 for ; Sun, 31 May 2026 12:45:46 +0000 (GMT) Received: from localhost.localdomain (unknown [9.43.54.110]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP for ; Sun, 31 May 2026 12:45:46 +0000 (GMT) From: Sachin Sant To: ltp@lists.linux.it Date: Sun, 31 May 2026 18:15:38 +0530 Message-Id: <20260531124540.70788-7-sachinp@linux.ibm.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260531124540.70788-1-sachinp@linux.ibm.com> References: <20260531124540.70788-1-sachinp@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDEzOCBTYWx0ZWRfX3jzF26pgweUl iKSeSfWxILlmZMqFC8oYP4n2Tt+0NHB2RmdGnW5YYSadUqBbS+AD6KBfmpJytnrm0+E+CHzKnPR 30Tx+F95+/v8y7hXb4SOQ27YZhsiEgViG8ibeI9n2679+0u7eU3keU/54E9yg/ZPsVCx1aVt+g2 hgmeMfESiR7THQ9UKQ2QB6nMH+WvMHLIWzHi6piJt5fqerEmMkyoNHtmcseUIc+Wi08wHejnN0U PHVVlDfp5OrxFmtgvxtElf7QNHc4mlnAfHsvr89v6yh9XyDaBFrhiQMew/9SgRuTp0CRdNKzTDs ABudNWXsca+usiYgH7gO6eDnoa2HuhtO1+qoXgoOzwuENSEcXrL6gfKsdZPEiO75uo67fU28+Ma lWiifs5Qy99SduZpyC0kdeqc3GZo3F0Ub4LzWFJ9t3sTgCO0xF21ibAOJJ+ZpdhnE1ubG5tskRJ v3Opfe2NjqfLfBAaLOw== X-Proofpoint-ORIG-GUID: AA9vGYJ0-1Fu7WO9_sVpnbeJAldgC-wD X-Authority-Analysis: v=2.4 cv=cOzQdFeN c=1 sm=1 tr=0 ts=6a1c2d7d cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=xKed2aWcXDJh0S5wpoUA:9 X-Proofpoint-GUID: AA9vGYJ0-1Fu7WO9_sVpnbeJAldgC-wD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310138 X-Virus-Scanned: clamav-milter 1.0.9 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [RFC][PATCH 6/8] fs/acl: Add symlink ACL operations test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Add acl_link01 test to validate that ACL operations on symlinks follow the symlink to the target file. The test verifies that: - acl_set_file() on a symlink sets ACL on the target file - acl_get_file() on a symlink retrieves ACL from the target file - ACL operations follow symlinks rather than operating on the link itself This test creates a file and symlink, sets ACL via the symlink path, and retrieves ACL via the symlink path to confirm both operations work on the target file. Returns TCONF if ACL on symlinks is not supported by the filesystem. Signed-off-by: Sachin Sant --- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_link01.c | 124 +++++++++++++++++++++++++++ 3 files changed, 126 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_link01.c diff --git a/runtest/fs b/runtest/fs index 2364a8564..89d26e086 100644 --- a/runtest/fs +++ b/runtest/fs @@ -93,3 +93,4 @@ acl_mask01 acl_mask01 acl_other01 acl_other01 acl_inherit01 acl_inherit01 acl_file_ops01 acl_file_ops01 +acl_link01 acl_link01 diff --git a/testcases/kernel/fs/acl/.gitignore b/testcases/kernel/fs/acl/.gitignore index eb4b4a227..4a071d516 100644 --- a/testcases/kernel/fs/acl/.gitignore +++ b/testcases/kernel/fs/acl/.gitignore @@ -3,3 +3,4 @@ /acl_other01 /acl_inherit01 /acl_file_ops01 +/acl_link01 diff --git a/testcases/kernel/fs/acl/acl_link01.c b/testcases/kernel/fs/acl/acl_link01.c new file mode 100644 index 000000000..c1136c0c0 --- /dev/null +++ b/testcases/kernel/fs/acl/acl_link01.c @@ -0,0 +1,124 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) IBM, 2026 + * + * Original shell test by Kai Zhao (ltcd3@cn.ibm.com) + * Converted to C by Sachin Sant + */ + +/*\ + * Test ACL operations on symlinks. + * + * Verify that ACL operations on symlinks follow the symlink to the target + * file. When setting or getting ACLs through a symlink path, the operation + * should affect the target file, not the symlink itself. + * + * Note: Some filesystems may not support ACLs on symlinks and will return + * EOPNOTSUPP, which is treated as TCONF (test not applicable). + * + * [Algorithm] + * + * 1. Create a regular file + * 2. Create a symlink pointing to the file + * 3. Set ACL through the symlink path + * 4. Verify the ACL was set on the target file + * 5. Get ACL through the symlink path + * 6. Verify we can read the ACL through the symlink + */ + +#include "acl_lib.h" + +uid_t user1_uid, user2_uid, user3_uid; +gid_t user1_gid, user2_gid, user3_gid; +int users_created = 0; + +static void run(void) +{ + acl_t acl; + int fd = -1; + int err; + + tst_res(TINFO, "Testing ACL operations on symlinks"); + reset_test_path(); + + fd = SAFE_OPEN(TESTFILE, O_CREAT | O_WRONLY, 0644); + SAFE_CLOSE(fd); + + SAFE_SYMLINK("testfile", TESTSYMLINK); + + acl = acl_init(3); + if (!acl) { + cleanup_testfile(); + tst_brk(TBROK | TERRNO, "acl_init failed"); + } + + add_acl_entry(acl, ACL_USER_OBJ, ACL_READ | ACL_WRITE); + add_acl_entry(acl, ACL_GROUP_OBJ, ACL_READ); + add_acl_entry(acl, ACL_OTHER, ACL_READ); + + err = acl_set_file(TESTSYMLINK, ACL_TYPE_ACCESS, acl); + if (err == -1) { + safe_acl_free(acl); + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + if (errno == EOPNOTSUPP) { + tst_res(TCONF, + "ACL on symlinks not supported"); + return; + } + tst_brk(TBROK | TERRNO, "acl_set_file on symlink failed"); + } + + safe_acl_free(acl); + + acl = acl_get_file(TESTSYMLINK, ACL_TYPE_ACCESS); + if (!acl) { + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + tst_brk(TBROK | TERRNO, "acl_get_file on symlink failed"); + } + + safe_acl_free(acl); + + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + tst_res(TPASS, "Symlink ACL operations work correctly"); +} + +static void setup(void) +{ + init_test_users(); + reset_test_path(); +} + +static void cleanup(void) +{ + cleanup_test_paths(); + cleanup_test_users(); +} + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .cleanup = cleanup, + .needs_root = 1, + .mount_device = 1, + .mntpoint = MNTPOINT, + .forks_child = 1, + .filesystems = (struct tst_fs[]) { + {.type = "ext2", .mnt_data = "acl"}, + {.type = "ext3", .mnt_data = "acl"}, + {.type = "ext4", .mnt_data = "acl"}, + {.type = "xfs"}, + {.type = "btrfs"}, + {} + }, + .needs_cmds = (struct tst_cmd[]) { + {.cmd = "useradd"}, + {.cmd = "userdel"}, + {} + } +}; -- 2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp