Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58621CD5BD1 for ; Sun, 31 May 2026 12:48:00 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id D265A3C9A7C for ; Sun, 31 May 2026 14:47:58 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 86E243CA91F for ; Sun, 31 May 2026 14:45:53 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 9D11320032E for ; Sun, 31 May 2026 14:45:52 +0200 (CEST) Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V442O63708001 for ; Sun, 31 May 2026 12:45:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=OFuTsSimp80xBZ1zH PTqcABD0UkntusYdi2wA7Z6XW8=; b=hgdBYlibNzgZr/bSHs0xxjBaQ00IS8Xmj AJSzk57OnPaVSEiTGMzg3Q4yMs04/L+3ujtotq23xLo30PI0I89/8TUUPr1Vmxj7 OQ9h58qckYhbIjWuukckgCUsBsa+IIzazOoYtO0Tgm6L2ox/Ysu8AOcDimjLDrUC J20bCFZ8X3y0lyS/naGNVD4Paze4uylVkKDNBTqk+kbdYIWeKjcpGAPs9MRvohMY rtnGVjPEr1VuwTlh5czAqE7HQfBBrHddc2wXl0U5NnGAOzpqxtNs4sMuTg+B/tsd chSdPdl1lvP1eUZwc6iIJjLbDyAIrhEH4sd3VzhXpkYZP30IHpwmw== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4efpadvf5s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 31 May 2026 12:45:50 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64VCd5JI023055 for ; Sun, 31 May 2026 12:45:50 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4egakvhu18-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 31 May 2026 12:45:50 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64VCjmvc27329000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 31 May 2026 12:45:48 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 228DD20043 for ; Sun, 31 May 2026 12:45:48 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF81820040 for ; Sun, 31 May 2026 12:45:47 +0000 (GMT) Received: from localhost.localdomain (unknown [9.43.54.110]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP for ; Sun, 31 May 2026 12:45:47 +0000 (GMT) From: Sachin Sant To: ltp@lists.linux.it Date: Sun, 31 May 2026 18:15:39 +0530 Message-Id: <20260531124540.70788-8-sachinp@linux.ibm.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260531124540.70788-1-sachinp@linux.ibm.com> References: <20260531124540.70788-1-sachinp@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=Zt3d7d7G c=1 sm=1 tr=0 ts=6a1c2d7e cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=d_RHJNMIJOfJ1Qv-cccA:9 X-Proofpoint-GUID: IPhluvrFXssyuS1wb8Bv-qw0Ol3VuQmD X-Proofpoint-ORIG-GUID: IPhluvrFXssyuS1wb8Bv-qw0Ol3VuQmD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDEzOCBTYWx0ZWRfXxLL2bKMiWHQ5 /F7AwNlA8fsJYtUZM4BguNHgMpCoo0valPs22FASyTPzG46Uoh1xR8nIQqFXP5xI67feRRlS02F J74Nw8O0lR34hlGbXmWbHIoABXNeGG0FvdtYYQKGmJny60Dhwpk5/amZQpCP98w2e9680tjGaV5 T4nHg1Bu9BIrUOTPOhYh73389PGG5ji62mQz91yICNhW8LkWBg6/G7t74fRVuwrBo+7LzyE59qj ZagTHkpy8suRVZA3GyScBGPjB+Os4r0DJ5JxG8LcpqZmdoPoKTCG+/0aaSYo+nEUTRCuWVmWFFx xYZvXla5no/GuSCMibY/JqRRqsq8gZoU0jK5Mhx8Br3FlgQLoFOF1TmUQcNamvjepji8QFRtGC3 2YCbFhZOcC1rqsJHVcWV9xPZ3+mrR5VOTqnbBiW6MtNWDlBz7XzYURv7Y7I8JFistngW7imZbsp ZWy2M18LTLHKWMiQEuA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310138 X-Virus-Scanned: clamav-milter 1.0.9 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [RFC][PATCH 7/8] fs/acl: Add extended attributes test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Add xattr_test01 test with 6 test cases to validate extended attribute operations: 1. Set/get xattr on directory 2. Set/get xattr on regular file 3. List xattrs on directory 4. Remove xattr from file 5. Backup and restore xattrs 6. Verify xattr operations follow symlinks to target The test validates basic extended attribute functionality including setting, getting, listing, and removing user.* extended attributes on filesystem objects. It also tests backup/restore functionality and confirms that xattr operations on symlinks affect the target file. Signed-off-by: Sachin Sant --- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/xattr_test01.c | 349 +++++++++++++++++++++++++ 3 files changed, 351 insertions(+) create mode 100644 testcases/kernel/fs/acl/xattr_test01.c diff --git a/runtest/fs b/runtest/fs index 89d26e086..6787b099d 100644 --- a/runtest/fs +++ b/runtest/fs @@ -94,3 +94,4 @@ acl_other01 acl_other01 acl_inherit01 acl_inherit01 acl_file_ops01 acl_file_ops01 acl_link01 acl_link01 +xattr_test01 xattr_test01 diff --git a/testcases/kernel/fs/acl/.gitignore b/testcases/kernel/fs/acl/.gitignore index 4a071d516..62ccd0457 100644 --- a/testcases/kernel/fs/acl/.gitignore +++ b/testcases/kernel/fs/acl/.gitignore @@ -4,3 +4,4 @@ /acl_inherit01 /acl_file_ops01 /acl_link01 +/xattr_test01 diff --git a/testcases/kernel/fs/acl/xattr_test01.c b/testcases/kernel/fs/acl/xattr_test01.c new file mode 100644 index 000000000..e3a0684e5 --- /dev/null +++ b/testcases/kernel/fs/acl/xattr_test01.c @@ -0,0 +1,349 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) IBM, 2026 + * + * Original shell test by Kai Zhao (ltcd3@cn.ibm.com) + * Converted to C by Sachin Sant + */ + +/*\ + * Test Extended Attributes (xattr). + * + * Some filesystems require explicit user_xattr mount options, + * while others (e.g. xfs and btrfs) provide these features without + * mount options. + * + * This test validates: + * - Extended attributes set/get/remove operations + * - Extended attributes backup and restore operations + * + * The test creates test users to validate xattr behavior across + * different user contexts. + * + * [Algorithm] + * + * 1. Set extended attributes on directories and files + * 2. Verify attributes can be retrieved correctly + * 3. Test attribute removal + * 4. Create backup of extended attributes to a file + * 5. Remove original attributes + * 6. Restore attributes from backup file + * 7. Verify restored attributes match original values + */ + +#include "acl_lib.h" + +uid_t user1_uid, user2_uid, user3_uid; +gid_t user1_gid, user2_gid, user3_gid; +int users_created = 0; + +/* + * Test extended attributes. + * Set, get, and remove extended attributes on files and directories. + */ +static void test_xattr(void) +{ + char value[256]; + ssize_t size; + int fd = -1; + int file_created = 0; + + tst_res(TINFO, "Testing extended attributes"); + reset_test_path(); + + TST_EXP_PASS_SILENT(setxattr(TESTDIR, XATTR_TEST_DIR_NAME, XATTR_TEST_DIR_VALUE, + XATTR_TEST_DIR_SIZE, 0)); + if (!TST_PASS) { + if (TST_ERR == EOPNOTSUPP) { + tst_res(TCONF, "Extended attributes not supported"); + return; + } + tst_res(TFAIL, "setxattr on directory failed"); + return; + } + + TST_EXP_POSITIVE(getxattr(TESTDIR, XATTR_TEST_DIR_NAME, value, sizeof(value))); + if (!TST_PASS) + goto cleanup_dir_xattr; + + size = TST_RET; + + if (size != XATTR_TEST_DIR_SIZE || + memcmp(value, XATTR_TEST_DIR_VALUE, XATTR_TEST_DIR_SIZE) != 0) { + tst_res(TFAIL, "getxattr returned wrong directory value"); + goto cleanup_dir_xattr; + } + + fd = SAFE_OPEN(TESTFILE, O_CREAT | O_WRONLY, 0644); + SAFE_CLOSE(fd); + file_created = 1; + + TST_EXP_PASS_SILENT(setxattr(TESTFILE, XATTR_TEST_FILE_NAME, XATTR_TEST_FILE_VALUE, + XATTR_TEST_FILE_SIZE, 0)); + if (!TST_PASS) { + if (TST_ERR == EOPNOTSUPP) { + tst_res(TCONF, "Extended attributes not supported"); + goto cleanup_file_and_dir; + } + tst_res(TFAIL, "setxattr on file failed"); + goto cleanup_file_and_dir; + } + + TST_EXP_POSITIVE(getxattr(TESTFILE, XATTR_TEST_FILE_NAME, value, sizeof(value))); + if (!TST_PASS) + goto cleanup_file_and_dir; + + size = TST_RET; + + if (size != XATTR_TEST_FILE_SIZE || + memcmp(value, XATTR_TEST_FILE_VALUE, XATTR_TEST_FILE_SIZE) != 0) { + tst_res(TFAIL, "getxattr returned wrong file value"); + goto cleanup_file_and_dir; + } + + TST_EXP_PASS(removexattr(TESTFILE, XATTR_TEST_FILE_NAME)); + if (!TST_PASS) + goto cleanup_file_and_dir; + + TST_EXP_FAIL(getxattr(TESTFILE, XATTR_TEST_FILE_NAME, value, sizeof(value)), + ENODATA, "getxattr after removal"); + if (!TST_PASS) + goto cleanup_file_and_dir; + + tst_res(TPASS, "Extended attributes work correctly"); + +cleanup_file_and_dir: + if (file_created) + cleanup_testfile(); +cleanup_dir_xattr: + if (removexattr(TESTDIR, XATTR_TEST_DIR_NAME) == -1 && + errno != ENODATA) + tst_res(TWARN | TERRNO, "removexattr failed"); +} + +#define XATTR_BACKUP_TEST_COUNT 2 + +/* + * Helper function to cleanup test xattrs. + */ +static inline void cleanup_test_xattrs(void) +{ + if (removexattr(TESTFILE, XATTR_TEST1_NAME) == -1 && + errno != ENODATA) + tst_res(TWARN | TERRNO, "removexattr XATTR_TEST1_NAME failed"); + if (removexattr(TESTFILE, XATTR_TEST2_NAME) == -1 && + errno != ENODATA) + tst_res(TWARN | TERRNO, "removexattr XATTR_TEST2_NAME failed"); +} + +/* + * Test extended attributes backup and restore. + * Extended attributes should be preserved through backup/restore. + */ +static void test_xattr_backup_restore(void) +{ + char value[256]; + char line[512]; + char attr_name[256]; + char attr_value[256]; + ssize_t size; + size_t name_len, value_len; + int fd = -1; + FILE *fp = NULL; + int restored_count = 0; + int backup_created = 0; + + tst_res(TINFO, "Testing extended attributes backup and restore"); + reset_test_path(); + + fd = SAFE_OPEN(TESTFILE, O_CREAT | O_WRONLY, 0644); + SAFE_CLOSE(fd); + + TST_EXP_PASS_SILENT(setxattr(TESTFILE, XATTR_TEST1_NAME, XATTR_TEST1_VALUE, + XATTR_TEST1_SIZE, 0)); + if (!TST_PASS) { + cleanup_testfile(); + if (TST_ERR == EOPNOTSUPP) { + tst_res(TCONF, "Extended attributes not supported"); + return; + } + tst_res(TFAIL, "setxattr failed"); + return; + } + + TST_EXP_PASS(setxattr(TESTFILE, XATTR_TEST2_NAME, XATTR_TEST2_VALUE, + XATTR_TEST2_SIZE, 0)); + if (!TST_PASS) + goto cleanup_xattrs; + + fp = SAFE_FOPEN(XATTR_BACKUP_FILE, "w"); + backup_created = 1; + + if (fprintf(fp, "# file: %s\n", TESTFILE) < 0) { + tst_res(TFAIL | TERRNO, "fprintf failed"); + goto cleanup_backup; + } + if (fprintf(fp, "%s=\"%s\"\n", XATTR_TEST1_NAME, + XATTR_TEST1_VALUE) < 0) { + tst_res(TFAIL | TERRNO, "fprintf failed"); + goto cleanup_backup; + } + if (fprintf(fp, "%s=\"%s\"\n", XATTR_TEST2_NAME, + XATTR_TEST2_VALUE) < 0) { + tst_res(TFAIL | TERRNO, "fprintf failed"); + goto cleanup_backup; + } + SAFE_FCLOSE(fp); + fp = NULL; + + /* Remove xattrs to simulate loss */ + cleanup_test_xattrs(); + + /* Restore from backup file */ + fp = SAFE_FOPEN(XATTR_BACKUP_FILE, "r"); + while (fgets(line, sizeof(line), fp)) { + char *p, *q; + + if (line[0] == '#' || line[0] == '\n') + continue; + + /* Parse: attr_name="attr_value" */ + p = strchr(line, '='); + if (!p) + continue; + + /* Safe copy of attribute name with length check */ + name_len = p - line; + + if (name_len >= sizeof(attr_name)) { + tst_res(TWARN, "Attribute name too long, skipping"); + continue; + } + memcpy(attr_name, line, name_len); + attr_name[name_len] = '\0'; + + p++; + if (*p != '"') + continue; + p++; + + q = strchr(p, '"'); + if (!q) + continue; + + /* Safe copy of attribute value with length check */ + value_len = q - p; + + if (value_len >= sizeof(attr_value)) { + tst_res(TWARN, "Attribute value too long, skipping"); + continue; + } + memcpy(attr_value, p, value_len); + attr_value[value_len] = '\0'; + + /* Restore the xattr */ + TST_EXP_PASS_SILENT(setxattr(TESTFILE, attr_name, attr_value, + value_len, 0)); + if (!TST_PASS) { + tst_res(TFAIL, "setxattr restore failed for %s", attr_name); + goto cleanup_backup; + } + restored_count++; + } + SAFE_FCLOSE(fp); + fp = NULL; + + if (restored_count != XATTR_BACKUP_TEST_COUNT) { + tst_res(TFAIL, "Expected %d xattrs restored, got %d", + XATTR_BACKUP_TEST_COUNT, restored_count); + goto cleanup_backup; + } + + /* Verify restored xattrs */ + TST_EXP_POSITIVE(getxattr(TESTFILE, XATTR_TEST1_NAME, value, sizeof(value))); + if (!TST_PASS) + goto cleanup_backup; + + size = TST_RET; + if (size != XATTR_TEST1_SIZE || + memcmp(value, XATTR_TEST1_VALUE, XATTR_TEST1_SIZE) != 0) { + tst_res(TFAIL, + "Extended attribute %s restore verification failed", + XATTR_TEST1_NAME); + goto cleanup_backup; + } + + TST_EXP_POSITIVE(getxattr(TESTFILE, XATTR_TEST2_NAME, value, sizeof(value))); + if (!TST_PASS) + goto cleanup_backup; + + size = TST_RET; + if (size != XATTR_TEST2_SIZE || + memcmp(value, XATTR_TEST2_VALUE, XATTR_TEST2_SIZE) != 0) { + tst_res(TFAIL, + "Extended attribute %s restore verification failed", + XATTR_TEST2_NAME); + goto cleanup_backup; + } + + tst_res(TPASS, "Extended attributes backup/restore work correctly"); + +cleanup_backup: + if (fp) + SAFE_FCLOSE(fp); + if (backup_created) { + if (unlink(XATTR_BACKUP_FILE) == -1) + tst_res(TWARN | TERRNO, "unlink backup file failed"); + } +cleanup_xattrs: + cleanup_test_xattrs(); + cleanup_testfile(); +} + +static void setup(void) +{ + init_test_users(); + reset_test_path(); +} + +static void cleanup(void) +{ + cleanup_test_paths(); + cleanup_test_users(); +} + +static void run(unsigned int n) +{ + switch (n) { + case 0: + test_xattr(); + break; + case 1: + test_xattr_backup_restore(); + break; + } +} + +static struct tst_test test = { + .test = run, + .tcnt = 2, + .setup = setup, + .cleanup = cleanup, + .needs_root = 1, + .mount_device = 1, + .mntpoint = MNTPOINT, + .forks_child = 1, + .filesystems = (struct tst_fs[]) { + {.type = "ext2", .mnt_data = "user_xattr"}, + {.type = "ext3", .mnt_data = "user_xattr"}, + {.type = "ext4", .mnt_data = "user_xattr"}, + {.type = "xfs"}, + {.type = "btrfs"}, + {} + }, + .needs_cmds = (struct tst_cmd[]) { + {.cmd = "useradd"}, + {.cmd = "userdel"}, + {} + } +}; -- 2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp