Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69A60CD6E4A for ; Wed, 3 Jun 2026 06:59:45 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 5F83F3E5543 for ; Wed, 3 Jun 2026 08:59:43 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 01B203E3095 for ; Wed, 3 Jun 2026 08:57:59 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 8B1E3600075 for ; Wed, 3 Jun 2026 08:57:58 +0200 (CEST) Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6534xm963100564 for ; Wed, 3 Jun 2026 06:57:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=Nwasxq3jwzfeGl5cP 7+NkCZRVYgvR+7a31yqEr6cCvE=; b=g6Vhc7MnereJV4eUee9buixqCUHKUx4nM m+MTti0q76a/FNQBkqc0mpbS+A7lIVB+A0ajxHvKEyBQpfdt+Q0oYmuhkvwLsDpC Z9PSf9hlM05bx9EZBo22WAXtglbYz5Co461OL8tudTSexTLyYHeWyHsxT9ccfE8j v1tQZmOgOTyKPFsGP++iNVskqOQ3JwlVVU7vRCDHa9wl8PQspo5pd+yLHyn6d76k xbbjXCVHd5Jp8zAd5J1DdCDPPcRiT+P0sM26+tHE56cwRUK/VoKimDKXfiK2mKLo Rnj7U1TWsj2o9tSKQxaiAuCzzRunw3X/gz0Qglmbog02TU2/qAVJw== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4efqht9227-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 03 Jun 2026 06:57:57 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 6536s8Bh006958 for ; Wed, 3 Jun 2026 06:57:56 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4egcegpr41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 03 Jun 2026 06:57:56 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6536vsO746137842 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 3 Jun 2026 06:57:54 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E137C2004E for ; Wed, 3 Jun 2026 06:57:53 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3AB3E2004B for ; Wed, 3 Jun 2026 06:57:53 +0000 (GMT) Received: from localhost.localdomain (unknown [9.43.45.245]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP for ; Wed, 3 Jun 2026 06:57:53 +0000 (GMT) From: Sachin Sant To: ltp@lists.linux.it Date: Wed, 3 Jun 2026 12:27:42 +0530 Message-Id: <20260603065744.47106-7-sachinp@linux.ibm.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260603065744.47106-1-sachinp@linux.ibm.com> References: <20260603065744.47106-1-sachinp@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TW5fIFQpEM07wh8HBtXydbX7yemr4O-P X-Authority-Analysis: v=2.4 cv=fv/sol4f c=1 sm=1 tr=0 ts=6a1fd075 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=i9eS0XM8Ku2lYutoKxcA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDA2MSBTYWx0ZWRfX+YFPFnvgKbGJ XvKmST0BICg0RaDWSuSLVE+uubgqiM8q9e8z7RIc3lDp7JRKzLq76I8mA5x2bU9rFgp0u2RYPs3 b7qu6yTjl/3nwEzzWz3U4xhA5Ci687FFeEJSLxNuzYo2J7XVX1nl5w8Kq5ObdvhS6m09gQRffk3 2zP8hjVsFKuF/qfNtVojk+6j1eXKXVDyuhCvfsjskRZUy7hGD4A/WgfqQ7Z38/xVSap21V9V6KQ MHs0DTOHT6AOVJ9MxIsqh64aNq2Zbhem58nzLT2pYQHbNZUpzIceVfrwxfTfBa95/v6GysQwZJM GuAUqv3Exx8aqrnBXowtIYZfkw/24KAV5T9Vmd1UlGK7jJx84fMm878x4cONmPdfy3zNeX//qUq LgmxbBT/xs+/ZYI1a/3yvPzIX8yWZOONGp2tW4T00mUK+BHFPgXfmEEImXlTZXNCtCO5flRGaya Br9mGa9dCXPOeqIumvQ== X-Proofpoint-ORIG-GUID: TW5fIFQpEM07wh8HBtXydbX7yemr4O-P X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030061 X-Virus-Scanned: clamav-milter 1.0.9 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v2 6/8] fs/acl: Add symlink ACL operations test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Add acl_link01 test to validate that ACL operations on symlinks follow the symlink to the target file. The test verifies that: - acl_set_file() on a symlink sets ACL on the target file - acl_get_file() on a symlink retrieves ACL from the target file - ACL operations follow symlinks rather than operating on the link itself This test creates a file and symlink, sets ACL via the symlink path, and retrieves ACL via the symlink path to confirm both operations work on the target file. Returns TCONF if ACL is not supported by the filesystem. Signed-off-by: Sachin Sant --- V2 changes: - Updated incorrect TCONF message and description text - Updated commit message to remove incorrect symlinks wording - Use reset_test_path_no_chown variant to skip chown step and removed needs_cmd tag to avoid useradd/userdel dependency - v1 link https://lore.kernel.org/ltp/20260602121958.27494-1-sachinp@linux.ibm.com/T/#t V1 changes: - Use HAVE_LIBACL guards in .c code - Report TCONF when libacl is not available - rfc link https://lore.kernel.org/ltp/477836fd-80c8-4168-bfe6-00b374bb2534@linux.ibm.com/T/#t --- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_link01.c | 119 +++++++++++++++++++++++++++ 3 files changed, 121 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_link01.c diff --git a/runtest/fs b/runtest/fs index f1eea055b..64deb56e6 100644 --- a/runtest/fs +++ b/runtest/fs @@ -94,3 +94,4 @@ acl_mask01 acl_mask01 acl_other01 acl_other01 acl_inherit01 acl_inherit01 acl_file_ops01 acl_file_ops01 +acl_link01 acl_link01 diff --git a/testcases/kernel/fs/acl/.gitignore b/testcases/kernel/fs/acl/.gitignore index eb4b4a227..4a071d516 100644 --- a/testcases/kernel/fs/acl/.gitignore +++ b/testcases/kernel/fs/acl/.gitignore @@ -3,3 +3,4 @@ /acl_other01 /acl_inherit01 /acl_file_ops01 +/acl_link01 diff --git a/testcases/kernel/fs/acl/acl_link01.c b/testcases/kernel/fs/acl/acl_link01.c new file mode 100644 index 000000000..35c171058 --- /dev/null +++ b/testcases/kernel/fs/acl/acl_link01.c @@ -0,0 +1,119 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) IBM, 2026 + * + * Original shell test by Kai Zhao (ltcd3@cn.ibm.com) + * Converted to C by Sachin Sant + */ + +/*\ + * Test ACL operations on symlinks. + * + * Verify that ACL operations on symlinks follow the symlink to the target + * file. When setting or getting ACLs through a symlink path, the operation + * should affect the target file, not the symlink itself. + * + * Note: Some filesystems may not support ACLs on the target file and will + * return EOPNOTSUPP, which is treated as TCONF (test not applicable). + * + * [Algorithm] + * + * 1. Create a regular file + * 2. Create a symlink pointing to the file + * 3. Set ACL through the symlink path + * 4. Verify the ACL was set on the target file + * 5. Get ACL through the symlink path + * 6. Verify we can read the ACL through the symlink + */ + +#include "acl_lib.h" + +#ifdef HAVE_LIBACL + +static void run(void) +{ + acl_t acl; + int fd = -1; + int err; + + tst_res(TINFO, "Testing ACL operations on symlinks"); + reset_test_path_no_chown(); + + fd = SAFE_OPEN(TESTFILE, O_CREAT | O_WRONLY, 0644); + SAFE_CLOSE(fd); + + SAFE_SYMLINK("testfile", TESTSYMLINK); + + acl = acl_init(3); + if (!acl) { + cleanup_testfile(); + tst_brk(TBROK | TERRNO, "acl_init failed"); + } + + add_acl_entry(acl, ACL_USER_OBJ, ACL_READ | ACL_WRITE); + add_acl_entry(acl, ACL_GROUP_OBJ, ACL_READ); + add_acl_entry(acl, ACL_OTHER, ACL_READ); + + err = acl_set_file(TESTSYMLINK, ACL_TYPE_ACCESS, acl); + if (err == -1) { + safe_acl_free(acl); + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + if (errno == EOPNOTSUPP) { + tst_res(TCONF, + "ACL not supported by this filesystem"); + return; + } + tst_brk(TBROK | TERRNO, "acl_set_file on symlink failed"); + } + + safe_acl_free(acl); + + acl = acl_get_file(TESTSYMLINK, ACL_TYPE_ACCESS); + if (!acl) { + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + tst_brk(TBROK | TERRNO, "acl_get_file on symlink failed"); + } + + safe_acl_free(acl); + + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + tst_res(TPASS, "Symlink ACL operations work correctly"); +} + +static void setup(void) +{ + reset_test_path_no_chown(); +} + +static void cleanup(void) +{ + cleanup_test_paths(); +} + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .cleanup = cleanup, + .needs_root = 1, + .mount_device = 1, + .mntpoint = MNTPOINT, + .forks_child = 1, + .filesystems = (struct tst_fs[]) { + {.type = "ext2", .mnt_data = "acl"}, + {.type = "ext3", .mnt_data = "acl"}, + {.type = "ext4", .mnt_data = "acl"}, + {.type = "xfs"}, + {.type = "btrfs"}, + {} + } +}; + +#else +TST_TEST_TCONF("libacl or ACL headers are not available"); +#endif -- 2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp