Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE84FCD6E4A for ; Thu, 4 Jun 2026 06:56:26 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3482F3E489E for ; Thu, 4 Jun 2026 08:56:25 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 516EB3E548A for ; Thu, 4 Jun 2026 08:54:30 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 769A71A007E3 for ; Thu, 4 Jun 2026 08:54:28 +0200 (CEST) Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653IPruk691739 for ; Thu, 4 Jun 2026 06:54:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=D8xAPvOCVz4wCkHep dVRTdDCdJCHtOGl6g4bQzhlxI8=; b=Ml36+0BWd3yPI8w1XFhd/jqUZBJhe+MtR mEjtllFkIQ5wY3lGHBfBgIJhzHcPMbyW04LqZoQ8w/vLJ+OverTdL57I1denSJk8 VELY8Yr2LBTcoDps4OipoygWcPQnuqnlzWulJ/kYG0dyu+pOH3PJD02v7x52c6Sr 2fCCWsMCDa5JXJSM7M595YC4OidEU2GSRQ1x58Tg6JKlBSGaIG71/81Fy2a527lF Wqh0Qw0kxO99l7rG3SRY5loFJCSupcNH8Vrwr1xawkyDGabphoCzY87xbaD1ivYJ Ah9Hojxfvy6jEhOQpf9VARfomar2YoC44e67aTzOiCXXle5mR+AAA== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4efqm56hx0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 04 Jun 2026 06:54:26 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 6546sFt6013879 for ; Thu, 4 Jun 2026 06:54:25 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4egcwykkpa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 04 Jun 2026 06:54:25 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6546sNwu50528608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 4 Jun 2026 06:54:23 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8523420043 for ; Thu, 4 Jun 2026 06:54:23 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03D1120040 for ; Thu, 4 Jun 2026 06:54:23 +0000 (GMT) Received: from localhost.localdomain (unknown [9.43.32.72]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP for ; Thu, 4 Jun 2026 06:54:22 +0000 (GMT) From: Sachin Sant To: ltp@lists.linux.it Date: Thu, 4 Jun 2026 12:24:15 +0530 Message-Id: <20260604065417.25924-7-sachinp@linux.ibm.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260604065417.25924-1-sachinp@linux.ibm.com> References: <20260604065417.25924-1-sachinp@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: c48SkeqytnwR552I5Gfi_vC21ZLIz6FA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDA2MiBTYWx0ZWRfX0li8pRrNNsPy zLuJEhIxrIQbDilR3fawXo9VJiF5lkq0P8IOJCkxb2Y1srvyGusj4RFgqunOTHFeLx4TGqgDAVS 4vZPo2l0UQJboNTBCs0GFG48ELB4udIbzNACYcbJoIjto99cy9zEmEo4e384yJydIX0JL09bWFE OWiKoiu1y2zVBKsxK1wdjjXmKNCaWXeZyY+mym4WahJetSJ0R7UFZwjF6AAw4ue6tQnwjVpNhze ePRr/WhbIeJBVKclnXKEuZTWXU7g6FYediDRyTwF4l1eHzFSOxWUZvNqo2/MOBi8sC0M+lsENSt Rlx0GLYLKvhyU+JVBiDm+D+tRwV7022AOlAVOYIYR6MBFIKNYLF9uy9topgBlCI+hru1I3GtTz9 uPDzt1xk396xd4o4LaCVMPdyTkqmt3WYvfJKJjTP0DjGxAy3rl7M8n3nsRl7pn92eMQzuogDMyK 4zFDi5iSwVn2lpLky7Q== X-Proofpoint-ORIG-GUID: c48SkeqytnwR552I5Gfi_vC21ZLIz6FA X-Authority-Analysis: v=2.4 cv=Vf3H+lp9 c=1 sm=1 tr=0 ts=6a212122 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=2ttLokU99P05ITrab2QA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040062 X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v4 6/8] fs/acl: Add symlink ACL operations test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Add acl_link01 test to verify that ACL operations on symlinks follow the symlink to the target file. The test validates that setting and getting ACLs through a symlink path affects the target file, not the symlink itself. Test coverage: - Create regular file with mode 0600 (rw-------) - Set distinct ACL (rwxrw----) through symlink path - Verify ACL was set on target file by reading directly - Get ACL through symlink path - Verify both ACLs match and differ from initial 0600 mode The test uses distinct permissions to ensure it can detect if symlink-following fails. Test returns TCONF if ACL is not supported by the filesystem. Signed-off-by: Sachin Sant --- V4 changes: - Rewrite test logic to use distinct ACL (rwxrw----) that differs from initial mode. - Update commit message to reflect the implementation. - v3 link https://lore.kernel.org/ltp/20260603140147.50738-1-sachinp@linux.ibm.com/T/#t V3 changes: - Updated the test to read the ACL from both TESTSYMLINK and TESTFILE, and verify the expected entries/permissions match. - Updated commit message to reflect this change. - Updated copyright header as per LTP format. - v2 link https://lore.kernel.org/ltp/20260603065744.47106-1-sachinp@linux.ibm.com/T/#t V2 changes: - Updated incorrect TCONF message and description text - Updated commit message to remove incorrect symlinks wording - Use reset_test_path_no_chown variant to skip chown step and removed needs_cmd tag to avoid useradd/userdel dependency - v1 link https://lore.kernel.org/ltp/20260602121958.27494-1-sachinp@linux.ibm.com/T/#t V1 changes: - Use HAVE_LIBACL guards in .c code - Report TCONF when libacl is not available - rfc link https://lore.kernel.org/ltp/477836fd-80c8-4168-bfe6-00b374bb2534@linux.ibm.com/T/#t --- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_link01.c | 148 +++++++++++++++++++++++++++ 3 files changed, 150 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_link01.c diff --git a/runtest/fs b/runtest/fs index f1eea055b..64deb56e6 100644 --- a/runtest/fs +++ b/runtest/fs @@ -94,3 +94,4 @@ acl_mask01 acl_mask01 acl_other01 acl_other01 acl_inherit01 acl_inherit01 acl_file_ops01 acl_file_ops01 +acl_link01 acl_link01 diff --git a/testcases/kernel/fs/acl/.gitignore b/testcases/kernel/fs/acl/.gitignore index eb4b4a227..4a071d516 100644 --- a/testcases/kernel/fs/acl/.gitignore +++ b/testcases/kernel/fs/acl/.gitignore @@ -3,3 +3,4 @@ /acl_other01 /acl_inherit01 /acl_file_ops01 +/acl_link01 diff --git a/testcases/kernel/fs/acl/acl_link01.c b/testcases/kernel/fs/acl/acl_link01.c new file mode 100644 index 000000000..f4460a591 --- /dev/null +++ b/testcases/kernel/fs/acl/acl_link01.c @@ -0,0 +1,148 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2026 IBM + * + * Original shell test by Kai Zhao (ltcd3@cn.ibm.com) + * Converted to C by Sachin Sant + */ + +/*\ + * Test ACL operations on symlinks. + * + * Verify that ACL operations on symlinks follow the symlink to the target + * file. When setting or getting ACLs through a symlink path, the operation + * should affect the target file, not the symlink itself. + * + * Note: Some filesystems may not support ACLs on the target file and will + * return EOPNOTSUPP, which is treated as TCONF (test not applicable). + * + * [Algorithm] + * + * 1. Create a regular file with mode 0600 (rw-------) + * 2. Create a symlink pointing to the file + * 3. Set a distinct ACL through the symlink path (rwxrw----) + * 4. Verify the ACL was set on the target file by reading it directly + * 5. Get ACL through the symlink path + * 6. Verify both ACLs match and differ from the initial 0600 mode + */ + +#include "acl_lib.h" + +#ifdef HAVE_LIBACL + +static void run(void) +{ + acl_t acl, target_acl, symlink_acl; + int fd = -1; + int err; + + tst_res(TINFO, "Testing ACL operations on symlinks"); + reset_test_path_no_chown(); + + fd = SAFE_OPEN(TESTFILE, O_CREAT | O_WRONLY, 0600); + SAFE_CLOSE(fd); + + SAFE_SYMLINK("testfile", TESTSYMLINK); + + acl = acl_init(3); + if (!acl) { + cleanup_testfile(); + tst_brk(TBROK | TERRNO, "acl_init failed"); + } + + add_acl_entry(acl, ACL_USER_OBJ, + ACL_READ | ACL_WRITE | ACL_EXECUTE); + add_acl_entry(acl, ACL_GROUP_OBJ, ACL_READ | ACL_WRITE); + add_acl_entry(acl, ACL_OTHER, 0); + + err = acl_set_file(TESTSYMLINK, ACL_TYPE_ACCESS, acl); + if (err == -1) { + safe_acl_free(acl); + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + if (errno == EOPNOTSUPP) { + tst_res(TCONF, + "ACL not supported by this filesystem"); + return; + } + tst_brk(TBROK | TERRNO, "acl_set_file on symlink failed"); + } + + safe_acl_free(acl); + + target_acl = acl_get_file(TESTFILE, ACL_TYPE_ACCESS); + if (!target_acl) { + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + tst_brk(TBROK | TERRNO, "acl_get_file on target failed"); + } + + symlink_acl = acl_get_file(TESTSYMLINK, ACL_TYPE_ACCESS); + if (!symlink_acl) { + safe_acl_free(target_acl); + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + tst_brk(TBROK | TERRNO, "acl_get_file on symlink failed"); + } + + err = acl_cmp(target_acl, symlink_acl); + if (err == -1) { + safe_acl_free(symlink_acl); + safe_acl_free(target_acl); + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + tst_brk(TBROK | TERRNO, "acl_cmp failed"); + } + + safe_acl_free(symlink_acl); + safe_acl_free(target_acl); + + if (unlink(TESTSYMLINK) == -1) + tst_res(TWARN | TERRNO, "unlink symlink failed"); + cleanup_testfile(); + + if (err != 0) { + tst_res(TFAIL, + "ACL via symlink differs from ACL on target file"); + return; + } + + tst_res(TPASS, + "ACL set via symlink was applied to target file (rwxrw----)"); +} + +static void setup(void) +{ + reset_test_path_no_chown(); +} + +static void cleanup(void) +{ + cleanup_test_paths(); +} + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .cleanup = cleanup, + .needs_root = 1, + .mount_device = 1, + .mntpoint = MNTPOINT, + .forks_child = 1, + .filesystems = (struct tst_fs[]) { + {.type = "ext2", .mnt_data = "acl"}, + {.type = "ext3", .mnt_data = "acl"}, + {.type = "ext4", .mnt_data = "acl"}, + {.type = "xfs"}, + {.type = "btrfs"}, + {} + } +}; + +#else +TST_TEST_TCONF("libacl or ACL headers are not available"); +#endif -- 2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp