Received: from mail-dy1-f195.google.com (mail-dy1-f195.google.com [74.125.82.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B79F3C4561 for ; Thu, 4 Jun 2026 07:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780558126; cv=none; b=Zzil4XfJ/cnROMQeInxXPdJNihjbHGk1mbBZF+wwD8nqGMZaTHzaDgQOnRIFTeP/pLusAO65kJwuqosO2o9tUwgY+BcnLt1hiYCEfOvMRfZwaGWc0v+NJEp+FAxXekIFs8l1rmyu+hTVBvLC+rWfghlvBlcanw35ry8yrIhqqmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780558126; c=relaxed/simple; bh=vEj8EI5oExPm7tMbsZS/Ju8S071XB3QnI2EedtVwxa0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bAUGYZIwlF5EfOsmd9OTxjHsjr+6M4GGdQl0G/z4tCG0FbW0O0o3naV6EeR5yTsIRYvb111IVFr6UlKLxGy6Oso80/KuEL9kOSCgdcPNPqPGMCRwFIWZgVD7MYI27kjQ3O2NpmYdJHx0LGdQI/7goE2LuH5yRssNnJr2hlLUx5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JJSXRrni; arc=none smtp.client-ip=74.125.82.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JJSXRrni" Received: by mail-dy1-f195.google.com with SMTP id 5a478bee46e88-3045c195251so298389eec.1 for ; Thu, 04 Jun 2026 00:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780558124; x=1781162924; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EUjaUGFNcoZHdC3YZeiMHCy05kdsPltvsJJXov2Ftec=; b=JJSXRrniQd7Xp1fx6hze/t/bk2uZ6xnRSlNTRU1EiAT283ysYfAF+D0xckGmTrOzkP eXb1V5Qm2S1P8s6LV8bWAANThiJGPBSRvwYgJsN01SBj74Lnbu2Bc/xhMhvwgq+yyVu2 K/4V7o6WuaDN0OFhNdYYMegdnW7cra6wO9/1gJ1tVDJLjD6HBN64rfTR5Qaig9+LVpZr k0HUsFY3cwd7RAApzdBT5gcZOCnO21o1RtzAcdLxbRAr+ZMAbgQ7xa21KK1mlec6uPal WycN5f1MtQ6xtGEQAiOcAcS+M3QFuoQjx8bdMJG/i4Nqs32aD0KW+ImWkbqsrzaSTqvN UGwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780558124; x=1781162924; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EUjaUGFNcoZHdC3YZeiMHCy05kdsPltvsJJXov2Ftec=; b=dHr8ixS7NtBc6M9NH9xATStZxWAw5YERQ6BGxrKhT1x8ruNGOmlZZBAic5L7E0sNEi or13OJ2J3F1oiZfQRxRDzK/AhABwSB9ft1+7KKWHRacDsTmQ9mcbyVlE8K3i9jKbXRWw XebKJh5NrsakcBHm/lL5CbgOXgCh5lOgdGTc6YDWDlsk7i0EEJpZWmnZuSzrZ8KDWhC0 JRhCFRXgDaTWwRpX8wJ8RHJYYVK48hGH228hr9+5OSUdp18oYNN2/OqMsXgApSheXXIv EIMkClBtyF1BnZvqiysenfPeoAGI4IFttEpfB7iY4j/oj3OQ24KanDZQaLjF6ouYqIi4 Tr7A== X-Forwarded-Encrypted: i=1; AFNElJ9L9BEAMdr3AHjF7HdXiXvs4WMxHCQXdYl/Vd0b0ssCJJ7g0kdbf0HBzTOfA9mcE4LotIeRf7WrANeF8TZB@vger.kernel.org X-Gm-Message-State: AOJu0YwA7+9rkL5wKG3rmB9jPGqoCV6gOYt2odl/kdTUkBRwW4Ou94qx MsH3yYGnMH93D0fiYYyhCdCo3Zy7ALoyN8G0aKasKMPirdrPO2F3kZCg X-Gm-Gg: Acq92OEPupKI1WOx3upwbTv/WHzE3dapB/a/3etk/YmsmPQF/gPXHg185ahvyu0jqLI 4GZDKer3u+lkzgDdOqVxCLR8mO11bhaMI0VTOSuSV2tQPBZ05/T+wcIu9+Vao1Td1Z8bzEUXhOj YU+2Eu/Y3E31bBzcA8TsHFgM3VabY3Oy9RM6Ky37OXx+B8iNfhDxiu5HHjJrZ4ElbYhmP+JW4tr RuHv7e7wmM92bDZxKj8TD8HY4wUzucJYUNesZaiRCAr3wUJPVfsQ6HHYdPif0ogyD15lTXBueBO 6fKu2Vxl/B8POqJesLmdHgCfl6w+xEYf8Fe9k2mH1f5eD3b0QQ+6zVRX0oByGpNtTdiI9B53Z7s o4x7cpkBAqDnREYb9OuakOTuUcvxBvSBvjhQpmPN5lgH3wrsid4g7t2Ho0rcTUuFykQUAy/FgzD XEPSTrLTBjkg990FLtU/NcqwW+xkhY0qMQQCK9PAytfau9EjXzZQQxkH0P/FHo6J/nXA== X-Received: by 2002:a05:7301:6787:b0:303:a1af:5042 with SMTP id 5a478bee46e88-3074f703362mr4245372eec.0.1780558124494; Thu, 04 Jun 2026 00:28:44 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074db55f60sm5797164eec.6.2026.06.04.00.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 00:28:44 -0700 (PDT) From: Hungyu Lin To: Vikash Garodia Cc: Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2] media: qcom: iris: guard IRQ handler with runtime PM check Date: Thu, 4 Jun 2026 07:28:24 +0000 Message-Id: <20260604072824.45448-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use pm_runtime_get_if_active() before accessing hardware registers in the threaded IRQ handler. Skip interrupt processing when the device is not active. Signed-off-by: Hungyu Lin --- v2: - Use pm_runtime_get_if_active() instead of pm_runtime_get_if_in_use() - Handle negative runtime PM return values correctly - Return IRQ_NONE when interrupt processing is skipped drivers/media/platform/qcom/iris/iris_hfi_common.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.c b/drivers/media/platform/qcom/iris/iris_hfi_common.c index 621c66593d88..1c05f83986fe 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_common.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.c @@ -100,10 +100,17 @@ irqreturn_t iris_hfi_isr(int irq, void *data) irqreturn_t iris_hfi_isr_handler(int irq, void *data) { struct iris_core *core = data; + int ret; if (!core) return IRQ_NONE; + ret = pm_runtime_get_if_active(core->dev); + if (ret <= 0) { + enable_irq(irq); + return IRQ_NONE; + } + mutex_lock(&core->lock); pm_runtime_mark_last_busy(core->dev); iris_vpu_clear_interrupt(core); @@ -111,6 +118,8 @@ irqreturn_t iris_hfi_isr_handler(int irq, void *data) core->hfi_response_ops->hfi_response_handler(core); + pm_runtime_put_autosuspend(core->dev); + if (!iris_vpu_watchdog(core, core->intr_status)) enable_irq(irq); -- 2.34.1