Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E53133314C3 for ; Sun, 7 Jun 2026 23:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780874947; cv=none; b=s4SOFlicTYpV1nV1FxnqzSF1HiElTWHrwbUDrOoLsmzRipeuIMoP17E+OgbbzfbbI2zJ+dqWp/B8hmvZKrW2EMRiYfSjPih9sKhIKZGLM1HgxS0HbARCV92kePr9sqB1wdKtAJCmDXU/h1Pbe85Z4BxYUn8/Eqa9YnrxPXaCQvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780874947; c=relaxed/simple; bh=uF2wjp27XrM7kHX8L5fBcMf7DUs8iOROkUMfrrvG244=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZAVbzGqhAYoCPHxO4g87emSP8hlZl/kBh+vRVwqsA9eEWO47wZR3KWXbPHKbj0WQUvmw3L2zsklgNKcYYNqYfvQ+OM3gLbahMP65whpO1Ul5CMzCJtjDTaTYNREd5NcuABfc2V6+xh/PKeQFKxL1bdszzO49Wq4VvJq4dvTfPR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tdr5/Ljw; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tdr5/Ljw" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-13809ed8fbeso4771211c88.0 for ; Sun, 07 Jun 2026 16:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780874944; x=1781479744; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=47lZbQjzRT+z7mXqB+2Qw4HmxmsdDinlE58vVE96Z3M=; b=Tdr5/LjwLn9OzOyOnFElgchxqVxbkztJW9iR+j+Ka7a1ge6jSD6IgCP2s+5Lqu9LFk jZM674W8tqT/oSBH1P+XllqSlFBT3zSk8zKxNVdidHPDPWWJZFxR0HJrl72zzeWbxle4 XiQWplFeAmtXcQpOuiqOLh+WoHNGLpxtJbNb4IgP4xS+7xnct3T6KZGypnaNBhs7/Hvp oyI0DteJ9l4TxW8Lg9KXso02Md7AFP/BEIc1d+xA/lCeZS5p2Y687io/2hWeNm7MP3nj m2fX14qpoPZ3KWNgrddE704YjZb1TpDSN9RJPTjpb24QpPn0UiJZhDvK9oEf9MIfIgId 2ktA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780874944; x=1781479744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=47lZbQjzRT+z7mXqB+2Qw4HmxmsdDinlE58vVE96Z3M=; b=cmRDr3gjmTQPucpt9BFnWladB6+xTzHno4W0/geGhLdYo3r9W/Qh1aVOrmRGaf/oo8 AziUZ44MQYYczwFl1uMkCp8tNwmrMqTGu4tWTVcxtukeE9NzTOW/WeO/JAnCn6s8LWkr ZcivZXBAaO26Dfco456KRP2OBNgpGPxdR5NqgqPgVqefW38PwUG2Cltd5hyrs7B8fZWH gfgXSgy0aBVfzbHJneP2zYogf7waTLw7yXI+ajhM91dmfy1+NXXRwky7NwZGPTFWQ1Ed xN/2p7/DEAOPCHd/RCMMjZWwLZAOfMeEbnhMRWu8aD1ilUHrHmSeR2ojlnGvsrqdZ8wO bjhQ== X-Gm-Message-State: AOJu0YysKt5k86Pten0Fg1BkIL/2JJHEcd5POhcthCR7Wbn7TtNMC+gX Mz0VtXxmRocgxYyFOvEDYSphb0JwmvOk6JCz+G2Xi7RpxLXVvr8a6Xvz X-Gm-Gg: Acq92OEoiRCaKD1G9rFcwhHl2KMoIZabjSo52RJctbEibCEoSntQLqc8szUSMVBkPo2 J5QM8R197pzQ4CwX/zbLgBzX0I3NCrjUvH3ajtjGXq1Ys0bpglFwNtefoJgYu5umnuOU6ZZooPj 1ag6oBeMah1p5eQnEe6cXeJfn/ZkSKvpNrWJo6v0xhvl3MQhpPo8puYMPI1+0k40pjNHHZJ4wPc PR9liKy29/4sYoBwE3JmLQyHEgU1VJKfQ7dxYmfIyUrv9vU8bjbd7ycOYtHeG4cQLcq73U1THYJ 1PZstWoNoNQtD8CqYaVBBc7TY3ymoMe6KYNtlKQypu/NfrxHQ7Z2pWM+5XOLFV4Apt9gR7w20WI Uq+v1CptDkTXFrKPh+1BSHjxforgcdjLQjP2u6qIvxWX3DR3AWaSVhKcT0Ng0kMyXXBATd+T3tg qU8TFl60nuNpdgZG8SJmBTJehuzlh5AaFiwlnGYvr4zhonV1HrziT/RHXC1QveN3nImQ== X-Received: by 2002:a05:7022:3d84:b0:130:9b78:b17b with SMTP id a92af1059eb24-1380673ac40mr6778942c88.38.1780874944050; Sun, 07 Jun 2026 16:29:04 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-137f5539035sm11324554c88.11.2026.06.07.16.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 16:29:03 -0700 (PDT) From: Hungyu Lin To: linux-media@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vikash.garodia@oss.qualcomm.com, abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org, hverkuil@kernel.org, stefan.schmidt@linaro.org, Hungyu Lin , Dmitry Baryshkov Subject: [PATCH v4 1/2] media: qcom: iris: fix runtime PM reference leaks Date: Sun, 7 Jun 2026 23:28:40 +0000 Message-Id: <20260607232841.79275-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260607232841.79275-1-dennylin0707@gmail.com> References: <20260607232841.79275-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use pm_runtime_resume_and_get() in iris_enable_power_domains() to avoid leaking a runtime PM usage count on failure. Also ensure pm_runtime_put_sync() is always called in iris_disable_power_domains(), even when iris_opp_set_rate() fails, so runtime PM references remain balanced. Fixes: bb8a95aa038e ("media: iris: implement power management") Reviewed-by: Dmitry Baryshkov Signed-off-by: Hungyu Lin --- Changes in v4: - Added Dmitry Baryshkov's Reviewed-by tag. drivers/media/platform/qcom/iris/iris_resources.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c index 773f6548370a..f5e3341e1430 100644 --- a/drivers/media/platform/qcom/iris/iris_resources.c +++ b/drivers/media/platform/qcom/iris/iris_resources.c @@ -78,11 +78,11 @@ int iris_enable_power_domains(struct iris_core *core, struct device *pd_dev) if (ret) return ret; - ret = pm_runtime_get_sync(pd_dev); - if (ret < 0) + ret = pm_runtime_resume_and_get(pd_dev); + if (ret) return ret; - return ret; + return 0; } int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev) @@ -90,12 +90,10 @@ int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev) int ret; ret = iris_opp_set_rate(core->dev, 0); - if (ret) - return ret; pm_runtime_put_sync(pd_dev); - return 0; + return ret; } static struct clk *iris_get_clk_by_type(struct iris_core *core, enum platform_clk_type clk_type) -- 2.34.1