Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 201D2425CC4 for ; Mon, 8 Jun 2026 15:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780931093; cv=none; b=Aejpp0d6jj4Uhz1agRq64lEx70m7wy6S8CfwfLyasp5QQr6jKdWtGb+d1RnjWcHsYkMFlDILYFNOdhWScy9MV0BUMvZJ2rK029Dsej2Sd1NZzwmuR3zECjEaFcCok6tcDFMUjJIKQSPi4t4tTDLq2zFctxJ4o1fDGEDeMwaMPkI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780931093; c=relaxed/simple; bh=LkP4EAY2VlweKldvR5b9AXxrurMPRlrJm3hv4Xtyrrs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=o98z3EwP3G6NKLR8Y+Yznp4Awe0UUUeD4YBLXPUbZP+g57mCh/WLjpE9XrX9v9IOn5QqF+YR1SOK75LFlxglrQwJGME1z//ce1j/wVK69llcnDtyu0r/DisJcsqKHAznKHMteSOdwmFfrHDPVQzfZK/NrXZ2k2e4j+6EU9yQFOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HKnpPhCe; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HKnpPhCe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780931092; x=1812467092; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LkP4EAY2VlweKldvR5b9AXxrurMPRlrJm3hv4Xtyrrs=; b=HKnpPhCemI16mTMOuWJrfaNlOC6Z9lvpBgqcogWv2MJqm4CbGgKAGpSL LJLC+sA33QUgh8+ixPKfnCd48npb47PXGtAtVjoTYYY6peRlLR2YpXn58 1Bok1f/lIvm7sifh8tn0jC5AmOh4HvcaqKOuOcXFLhz+sxe2vUBRNV94h /wSYI3cPuiGWoK8haZ0KIiLM6Mb7u2GQMr8EFOqf1mONYWZ52aUj5dZHT GhsJ7SmCnmmy2Wv0yhDWEUsNJceddhpkjaauEVtyXHY01iFYLrwi5RXqb Za9LvVpO8VgKgEiJ+35txwBJUPpLP8zNgimbYJY8ODVF0x21fcXWt3A2B A==; X-CSE-ConnectionGUID: 2OBcU/sKRk6UoXpdu4KbnQ== X-CSE-MsgGUID: x/Z24fafSEWa3VOxjNuxKg== X-IronPort-AV: E=McAfee;i="6800,10657,11811"; a="93057220" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="93057220" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 08:04:51 -0700 X-CSE-ConnectionGUID: 5cR6uXzeRpqetyPLMl72cw== X-CSE-MsgGUID: UjVtFJb3QOyZXo4IdoWk6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="275782617" Received: from silpixa00401971.ir.intel.com ([10.20.226.106]) by orviesa002.jf.intel.com with ESMTP; 08 Jun 2026 08:04:50 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Giovanni Cabiddu , Ahsan Atta Subject: [PATCH] crypto: qat - clear AES key schedule from stack Date: Mon, 8 Jun 2026 16:04:20 +0100 Message-ID: <20260608150441.136014-1-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland Content-Transfer-Encoding: 8bit qat_alg_xts_reverse_key() expands the forward XTS AES key on the stack. That schedule contains key material and can remain in the stack frame. Clear the temporary crypto_aes_ctx with memzero_explicit() after the copy. Fixes: 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices") Signed-off-by: Giovanni Cabiddu Reviewed-by: Ahsan Atta --- drivers/crypto/intel/qat/qat_common/qat_algs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/intel/qat/qat_common/qat_algs.c b/drivers/crypto/intel/qat/qat_common/qat_algs.c index 7f638a62e3ad..91663805d9e6 100644 --- a/drivers/crypto/intel/qat/qat_common/qat_algs.c +++ b/drivers/crypto/intel/qat/qat_common/qat_algs.c @@ -405,6 +405,7 @@ static void qat_alg_xts_reverse_key(const u8 *key_forward, unsigned int keylen, memcpy(key_reverse + AES_BLOCK_SIZE, key - AES_BLOCK_SIZE, AES_BLOCK_SIZE); } + memzero_explicit(&aes_expanded, sizeof(aes_expanded)); } static void qat_alg_skcipher_init_dec(struct qat_alg_skcipher_ctx *ctx, base-commit: 36d82ddc0f8a88444e8d65646a3c43147005ed35 -- 2.54.0