Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44884CD8CAD for ; Mon, 8 Jun 2026 18:31:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CBEF710F886; Mon, 8 Jun 2026 18:31:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CRZyjmSM"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id EAE6310F886; Mon, 8 Jun 2026 18:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780943468; x=1812479468; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YezZB7JsIh5BuBWPJEGraTZMw5MNQ6UUalq531g+gIQ=; b=CRZyjmSMimBC1yt9G8NNPSary/5COwwGi91c/ei6cXJUku24wWV8Bbhy yiF0uCzFfoILIbHuSIVCcD1cG+tjj6eOCxFM77XoL1uH4kAguA98BaGzH ZiVDC6nYKp20Zl5tSu8+dPIHRo/oO/DUGQUv7L0mtlUJC/BKukY2OZtJD NKuElGvEwkyMpUWqXh5xuWGjWKwWKqao5OeCMpii2jHKFERUPAPS9a2jn f+ZL+7G51rrECTxI9yemAPtihAEazDjuGtBEBLZs/8498MTC/sFN8LDxW 4alDtiLixLR/PN338NSu5q3rHwbCZt71jkLn/w4RBVNXX0AGi/lit094c A==; X-CSE-ConnectionGUID: TsWg0Vn4StKXFkOuKSVaSw== X-CSE-MsgGUID: vVYwtI90Seuu8sSWDUmTIQ== X-IronPort-AV: E=McAfee;i="6800,10657,11811"; a="85544004" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="85544004" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 11:31:08 -0700 X-CSE-ConnectionGUID: +WH5iEKaRNmutOyrOCRbhg== X-CSE-MsgGUID: RSijedb1QVWdrWuudFb+bw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="249542055" Received: from osgc-sh-dragon.sh.intel.com ([10.239.81.44]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 11:31:05 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, raag.jadav@intel.com, Michal.Wajdeczko@intel.com Subject: [PATCH v4 4/5] drm/i915: Refactor generic_handle_irq_safe() error messages Date: Tue, 9 Jun 2026 02:30:49 +0800 Message-ID: <20260608183050.3875235-5-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260608183050.3875235-1-jonathan.cavitt@intel.com> References: <20260608183050.3875235-1-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Refactor all error messages resulting from generic_handle_irq_safe() failures in I915 for clarity. v2: - Use drm_err_ratelimited() correctly (jcavitt) v3: - Use xe_err_ratelimited() instead (Jadav) - Split into patch series (jcavitt) v4: - Use suggested phrasing (Wajdeczko) v5: - s/PTR_ERR/ERR_PTR (jcavitt) Suggested-by: Raag Jadav Suggested-by: Michal Wajdeczko Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +- drivers/gpu/drm/i915/gt/intel_gsc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_lpe_audio.c b/drivers/gpu/drm/i915/display/intel_lpe_audio.c index 022ad18044bf..ff2cf479d8e1 100644 --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c @@ -265,7 +265,7 @@ void intel_lpe_audio_irq_handler(struct intel_display *display) ret = generic_handle_irq_safe(display->audio.lpe.irq); if (ret) drm_err_ratelimited(display->drm, - "error handling LPE audio irq: %d\n", ret); + "LPE audio: irq handling failed (%pe)\n", ERR_PTR(ret)); } /** diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c index 050d909fb4f8..1c06bf76568a 100644 --- a/drivers/gpu/drm/i915/gt/intel_gsc.c +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c @@ -286,7 +286,7 @@ static void gsc_irq_handler(struct intel_gt *gt, unsigned int intf_id) ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq); if (ret) - gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret); + gt_err_ratelimited(gt, "GSC: irq handling failed (%pe)\n", ERR_PTR(ret)); } void intel_gsc_irq_handler(struct intel_gt *gt, u32 iir) -- 2.53.0