Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B31FCD8CAE for ; Mon, 8 Jun 2026 22:36:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0217C10FA04; Mon, 8 Jun 2026 22:36:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MyeiNygF"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9ACDF10F9EA for ; Mon, 8 Jun 2026 22:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780958189; x=1812494189; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gPqtMNIMEQu5c6xvL1aaYg7PzendU7EaR7OMrf61AD0=; b=MyeiNygFm9TX1oR/QcFR13zlazT3uN/u/pUc+KznPixrpuKe3s6eybxX 4wG5dxIJ8m9kX/JQNOOWpSTDrNekqdx/6iA5UUXIe/qCowFZjheM+FLiF /JpnyDZWnj7gvdyTjRo0zST3oY30pz0r/kuqClXS5BS9GMtn5K05YRwNH LBxekwiBqhZ9BLVneeUezbcke4zjRFixaWy8HEZwSOxDPxmPThtkgpldQ N98NKILv5kgObkeYxc8YMmx363+qtDCzmSpeQMKK06L1ukffK8YogQjB1 QVLlq1Mk7jw5wCva+b99lxpPvqgdbEFIAF4kTOLW5C0FCdHsfWUNBwvo7 Q==; X-CSE-ConnectionGUID: qlALz70PSHW1sNp+3MDi0Q== X-CSE-MsgGUID: PvhBLjzSQfCTuxcK+A6tdg== X-IronPort-AV: E=McAfee;i="6800,10657,11811"; a="81750981" X-IronPort-AV: E=Sophos;i="6.24,195,1774335600"; d="scan'208";a="81750981" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 15:36:29 -0700 X-CSE-ConnectionGUID: 6FQCNL9TSbKZEglt3pQX8Q== X-CSE-MsgGUID: 5zF4yEFYSrexOFhW0TPbkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,195,1774335600"; d="scan'208";a="269684762" Received: from orsosgc001.jf.intel.com ([10.88.27.185]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 15:36:29 -0700 From: Ashutosh Dixit To: intel-xe@lists.freedesktop.org Cc: Umesh Nerlige Ramappa Subject: [PATCH v2 8/9] drm/xe/oa: (De-)whitelist OA registers on OA stream open/release Date: Mon, 8 Jun 2026 15:36:23 -0700 Message-ID: <20260608223624.3711760-9-ashutosh.dixit@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260608223624.3711760-1-ashutosh.dixit@intel.com> References: <20260608223624.3711760-1-ashutosh.dixit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Whitelist OA registers on stream open and de-whitelist on stream close/release. Whitelisting is only done when 'stream->sample' is true. 'stream->sample' is only true when (a) xe_observation_paranoid is set to false by system admin, or (b) the process is perfmon_capable(). This therefore enforces the OA register whitelisting security requirements. Signed-off-by: Ashutosh Dixit Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/xe/xe_oa.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c index 9fbd21b0ef974..b3acbcd678b7c 100644 --- a/drivers/gpu/drm/xe/xe_oa.c +++ b/drivers/gpu/drm/xe/xe_oa.c @@ -37,6 +37,7 @@ #include "xe_oa.h" #include "xe_observation.h" #include "xe_pm.h" +#include "xe_reg_whitelist.h" #include "xe_sched_job.h" #include "xe_sriov.h" #include "xe_sync.h" @@ -885,6 +886,9 @@ static void xe_oa_stream_destroy(struct xe_oa_stream *stream) mutex_destroy(&stream->stream_lock); + if (stream->sample) + xe_reg_dewhitelist_oa_regs(stream->gt); + xe_oa_disable_metric_set(stream); xe_exec_queue_put(stream->k_exec_q); @@ -1886,6 +1890,9 @@ static int xe_oa_stream_open_ioctl_locked(struct xe_oa *oa, goto err_disable; } + if (stream->sample) + xe_reg_whitelist_oa_regs(stream->gt); + /* Hold a reference on the drm device till stream_fd is released */ drm_dev_get(&stream->oa->xe->drm); -- 2.54.0