Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0148CCD98C7 for ; Wed, 10 Jun 2026 09:03:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXEq6-0001jJ-09; Wed, 10 Jun 2026 05:03:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXEq2-0001iC-3e; Wed, 10 Jun 2026 05:03:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXEq0-0005hR-HI; Wed, 10 Jun 2026 05:03:05 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A2304A3404977; Wed, 10 Jun 2026 09:03:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=G3UyCHWEbX8DyajEX 8j2gvDQ4ifLJxbnkNEObsymwC0=; b=TaEhnYYI+dNAEte0CV7nZ/awD0YVMrjbk 6yqPE5Jt0hOIe/0tmiUc6Uqzd0ths7TKX25jZwLNnorjhdvEz2KpaLCDG+Ue+wGH Ti1zKvG9/MKg3FZXdbdI6m9sJkyR0xr2o9yUvVuB6cYEqE13J2+mqenVbk2Tlfyf /hQgXUVHtOPdY55182IwyLpuIpBhdpa8LXOUIu7Un8teETaxd+tvq7vVHlnmYZ7n ZeOoWU0jm09NtTF/6r6eETYsjiF58wf/soWh6vORqAgdOxDMAWiuoQs9IyUTTLB/ GrDgQFNyrKNCRrbnYYwOmKJHMjzzwAuVdKKCrWmqoe/RF/c6Yv6fw== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4em9ye7yjy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jun 2026 09:03:02 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65A8nbvj027682; Wed, 10 Jun 2026 09:03:02 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4emxvjwx37-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jun 2026 09:03:01 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65A92wpa37028290 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jun 2026 09:02:58 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33E7E20040; Wed, 10 Jun 2026 09:02:58 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9027A20043; Wed, 10 Jun 2026 09:02:53 +0000 (GMT) Received: from li-3c92a0cc-27cf-11b2-a85c-b804d9ca68fa.ibm.com (unknown [9.39.29.92]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 10 Jun 2026 09:02:53 +0000 (GMT) From: Aditya Gupta To: , , Harsh Prateek Bora Cc: Sourabh Jain , Hari Bathini , Nicholas Piggin , Miles Glenn , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , Misbah Anjum N , Shivang Upadhyay Subject: [PATCH 3/4] tests/qtest/pnv_spi: Test Power11 PNV_SPI Date: Wed, 10 Jun 2026 14:32:34 +0530 Message-ID: <20260610090235.3665904-4-adityag@linux.ibm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260610090235.3665904-1-adityag@linux.ibm.com> References: <20260610090235.3665904-1-adityag@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA4MSBTYWx0ZWRfX4QlLWM+O9uJJ rizMSdAyx7WY90a5G+KG1KYkmz+oWItibzWsgesnNAfYswrcxFMDqynBOltfg5B1AQyYec1lghb AgiXuDuJ+RxB+1CTWn8HMXASGbRTdT8wSU7WsSJNAXQhHFEyZcZ8Mf8vUlau22gVZOUdU941g2X /pQi8r7wNTZUdr3klVQ1Xny5dfk6hXELjQZZt+PqnB5qyHEBfa4Y8CLaXln4R5omWGTEkTz3l8Y J1huapJaugkHEzEE3RLTU+zejEqzWtRCvyT3yl5Zay5Ss2wFV88t9ium/Oz6qFkbc7SXD1a0CrF b5DPibH/lIoNmVAirq7jGbc1K9sVqUM5ER/jsAg+hmBP5RZtUCeoJP5OcXSHH6GcXgN3Q8TWNee J1Qy23e3ML/PgXlIEBHAndAw28PeYOaU/6EC77279Kqqz+rDNuEzLPEOz4c1K7Cso8wnscLlx0q vvYN5QHzO9WyDGqYs0w== X-Authority-Analysis: v=2.4 cv=QKhYgALL c=1 sm=1 tr=0 ts=6a292847 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=gL735G7rtJRJJwX7cZEA:9 X-Proofpoint-GUID: Ap97qSWHnuoB0hfIx1SRTPbIzDKwQvxT X-Proofpoint-ORIG-GUID: QoKQGjGwplxbtfHdodvkvOn5g7PVWS20 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100081 Received-SPF: pass client-ip=148.163.158.5; envelope-from=adityag@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Currently pnv-spi-seeprom-test was hardcoded to test the 4th chip in pnv_chips (power10 as of now). Iterate over all the chips instead, similar to other tests in pnv-xscom-test.c and pnv-host-i2c-test.c, but skip older chips, since TYPE_PNV_SPI only exists from Power10 onwards, hence skip older machines This has 2 advantages, of not needing to update that the hardcoded index 3 in pnv_chips matches the machine type used, and that it tests all the pnv_chips similar to other qtests Signed-off-by: Aditya Gupta --- tests/qtest/pnv-spi-seeprom-test.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/tests/qtest/pnv-spi-seeprom-test.c b/tests/qtest/pnv-spi-seeprom-test.c index 44e0b92730b4..b4eead8e3c60 100644 --- a/tests/qtest/pnv-spi-seeprom-test.c +++ b/tests/qtest/pnv-spi-seeprom-test.c @@ -77,9 +77,14 @@ static void test_spi_seeprom(const void *data) const PnvChip *chip = data; QTestState *qts = NULL; g_autofree char *tmp_path = NULL; + const char *machine = "powernv10"; int ret; int fd; + if (chip->chip_type == PNV_CHIP_POWER11) { + machine = "powernv11"; + } + /* Create a temporary raw image */ fd = g_file_open_tmp("qtest-seeprom-XXXXXX", &tmp_path, NULL); g_assert(fd >= 0); @@ -87,11 +92,11 @@ static void test_spi_seeprom(const void *data) g_assert(ret == 0); close(fd); - qts = qtest_initf("-machine powernv10 -smp 2,cores=2," + qts = qtest_initf("-machine %s -smp 2,cores=2," "threads=1 -accel tcg,thread=single -nographic " "-blockdev node-name=pib_spic2,driver=file," "filename=%s -device 25csm04,bus=chip0.spi.2,cs=0," - "drive=pib_spic2", tmp_path); + "drive=pib_spic2", machine, tmp_path); spi_seeprom_transaction(qts, chip); qtest_quit(qts); unlink(tmp_path); @@ -100,9 +105,17 @@ static void test_spi_seeprom(const void *data) int main(int argc, char **argv) { g_test_init(&argc, &argv, NULL); - char *tname = g_strdup_printf("pnv-xscom/spi-seeprom/%s", - pnv_chips[3].cpu_model); - qtest_add_data_func(tname, &pnv_chips[3], test_spi_seeprom); - g_free(tname); + + for (int i = 0; i < ARRAY_SIZE(pnv_chips); i++) { + /* TYPE_PNV_SPI is not instantiated for older Power8/9 machines */ + if (pnv_chips[i].chip_type < PNV_CHIP_POWER10) { + continue; + } + + char *tname = g_strdup_printf("pnv-xscom/spi-seeprom/%s", + pnv_chips[i].cpu_model); + qtest_add_data_func(tname, &pnv_chips[i], test_spi_seeprom); + g_free(tname); + } return g_test_run(); } -- 2.54.0