Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65CA3CD98C7 for ; Thu, 11 Jun 2026 16:17:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AE3310F001; Thu, 11 Jun 2026 16:17:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="f6bC/K+C"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AAFB10EFF7 for ; Thu, 11 Jun 2026 16:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781194677; x=1812730677; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vrCPSA8yvOtm51WfOpDP750QW0r4MfJH2mGPYdVzOtU=; b=f6bC/K+Ctk30dYr9bP5X5i2o6Z7PciyH7ukTfFLMBsnnmnVUwZZhPM6G 1k2cUeBlQs2nKzdZ0uhhVC5zovMOg2gE9Je4NVrJMg+2SDE03cpivhIRt dXbdbe6MFADp1CAJ4LbdtcB2EXFBYauBc8isOg7AXj70ae4fIbHei6r39 8l4VXgDbU3dt6tza7yIf0kF7U3bNHpv8JJOKyFE5ZS2S0o+IOYmp2MBCZ VN5heZtydZaH4BeQRyuOF369g89c6bYnPsYwu2KI4BI2Ae2CFbcl/daCV O91VtsTlw+pAz4l6Xi+G8VY5fiz01r/EwWFULumNC+uIMXiHV1fk0uO7O A==; X-CSE-ConnectionGUID: 75AcPe9XSqCi7aqsQNf56g== X-CSE-MsgGUID: YEuqwcqAQu6xYIX9fY/DUA== X-IronPort-AV: E=McAfee;i="6800,10657,11813"; a="93403012" X-IronPort-AV: E=Sophos;i="6.24,199,1774335600"; d="scan'208";a="93403012" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2026 09:17:57 -0700 X-CSE-ConnectionGUID: Dqm17E/aSqm7wKr9ozpUlg== X-CSE-MsgGUID: eNuVXjuKSzerqegFa3CDng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,199,1774335600"; d="scan'208";a="251617082" Received: from ettammin-mobl3.ger.corp.intel.com (HELO mwauld-desk.intel.com) ([10.245.244.170]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2026 09:17:56 -0700 From: Matthew Auld To: intel-xe@lists.freedesktop.org Cc: Daniele Ceraolo Spurio , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Matthew Brost Subject: [PATCH v6 09/10] drm/xe/hw_engine: document top-down paging requirement Date: Thu, 11 Jun 2026 17:16:44 +0100 Message-ID: <20260611161634.506476-21-matthew.auld@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611161634.506476-12-matthew.auld@intel.com> References: <20260611161634.506476-12-matthew.auld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" We were doing this anyway, but going forward for paging engines, agreement is to always reserve BCS instances in top down fashion. This hopefully future proofs things for VFs, where in some low-level places it might only have the physical BCS instance from the hw pov. If we stick to a consistent mapping scheme, it should make it possible to determine if this is a special paging engine, or not. v2 (Daniele) - Give a concrete example, like with page fault descriptor Signed-off-by: Matthew Auld Cc: Daniele Ceraolo Spurio Cc: Thomas Hellström Cc: Matthew Brost Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/xe/xe_hw_engine.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c index 1227b9e66fd6..9db6acc4f88c 100644 --- a/drivers/gpu/drm/xe/xe_hw_engine.c +++ b/drivers/gpu/drm/xe/xe_hw_engine.c @@ -663,7 +663,6 @@ static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (hwe->class == XE_ENGINE_CLASS_COPY) num_copy_engines++; - /* We just reserve the highest BCS instance for USM */ if (num_copy_engines && xe->info.has_usm) num_paging_engines = 1; @@ -688,6 +687,18 @@ static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines)) return -EINVAL; + /* + * On PF, we just reserve the highest BCS instance for USM. + * + * Note: This is now a requirement going forward. The PF must ALWAYS + * reserve BCS instances in top-down order, that way the VF has a chance + * of discovering the physical BCS instance mappings for paging engines, + * in conjunction with vf_num_paging_engines. In some places we might + * only have the physical instance, and from hw pov there is no such + * thing as a paging engine. For example, the page fault descriptor, + * which comes directly from the hw, will use the physical engine + * instance. + */ reserved_logical_bcs_start = num_copy_engines - num_paging_engines; /* FIXME: Doing a simple logical mapping that works for most hardware */ -- 2.54.0