Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D035CD8CA8 for ; Fri, 12 Jun 2026 17:21:57 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B63533E6B30 for ; Fri, 12 Jun 2026 19:21:55 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 801F43E6B4B for ; Fri, 12 Jun 2026 19:19:41 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 310CD1A00A45 for ; Fri, 12 Jun 2026 19:19:39 +0200 (CEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CECWwE1363971; Fri, 12 Jun 2026 17:19:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=KFuu8cYh7wL/uOAzl IyYtQv5H8h2IUeAXeziHZqrpuw=; b=Kquhb3MnS04tKRFH6vOBGRFFgeDBrcRk6 cdZeGh5brs1TyeUbwsUjayhKkbPW4uVkNjrhqj4RZiTiy/08m0Abb/NnTp/jQ+2N sJRMbykEyn+a3a0k3vBwBRFXjiHuD7PG1hp0ezzFTdE6SYnovtZSbWbfFsWASH0h /AXamUWl6jZsiWn6DgWemNiZf5OMjW+MJqht9ZcAVmlm4+1SEKaeX/25CqGLBGsN CSEh+DVFtZ+wyYarAgMp8xSPHGAlwnqjbIM/6CramPwKU//j684VuloaX+rZyx3b ml01KaMZGA5jhU8BAXmPN2R9ptFF5wsgkKvFYObU1ERbKRfPvpf0A== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4eqe8e1prt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jun 2026 17:19:38 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65CGncjp025503; Fri, 12 Jun 2026 17:19:37 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4eqe0a8ufb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jun 2026 17:19:37 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65CHJZca62325108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jun 2026 17:19:35 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 637232004D; Fri, 12 Jun 2026 17:19:35 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B02D42004B; Fri, 12 Jun 2026 17:19:34 +0000 (GMT) Received: from localhost.localdomain (unknown [9.43.87.219]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 12 Jun 2026 17:19:34 +0000 (GMT) From: Sachin Sant To: ltp@lists.linux.it Date: Fri, 12 Jun 2026 22:49:25 +0530 Message-Id: <20260612171930.11964-4-sachinp@linux.ibm.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260612171930.11964-1-sachinp@linux.ibm.com> References: <20260612171930.11964-1-sachinp@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 77YuXLLsfev6S5Q0Pe-BAE2f-83eIahL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE1OSBTYWx0ZWRfX2xiBaMoV/34L 27fotF5C1XaNjcsu9vb+xomNUmcuMDPQ/WTPNmj9lz1itB0ui4X9Tgp6q1sRRs5FxZct7ddRbjl gULlMvjEHNsUonUaMmYsZd7CsgKwYDsBPA7l4dKym0/lPAY4zpReo5AEJsHJVPy3IHfNc7rFBcJ yU+TonD+dL7HrQZyq3Du8u6M8KEzQ6bqp7tr67hQ2jQ3kgFpLOsfGHiL3p6Vmo/eHlgbCQKIAPa FoSfnDxMm6gF5uahHh5nlBFWIJTPzkonydgPjI8N+7/VHQpb5mipUK2yEQxzn57GvIEKzPy65Qz az8g9zNx82CQjfR2d93tYc0siyLGJwQx9M8kQx7xKpyZclY/Vun2ObzW44X4M5UuLFEso2h0wQf /v8U6pfjqQzS6QmEDjP3c7cel8zAJFKcvSi7WzlQiOvruE6VNv8sxdwvUIU9PFDueqhlMY/+g43 7wWnwsVgvJuAfLLy+7w== X-Authority-Analysis: v=2.4 cv=DPu/JSNb c=1 sm=1 tr=0 ts=6a2c3faa cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=4r56s12NWv49vHn13p0A:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE1OSBTYWx0ZWRfX0DTQu4gegzte DgzGsU1K5/7c/YcxUok5lW+KH57T2gS3VjuuOAkkJIoT+1Yu5SelAHlnh22u86wHnicRCbBZVWH hYWlN2uNZiF19nLgTRyJU3eWi2EmbkI= X-Proofpoint-ORIG-GUID: 77YuXLLsfev6S5Q0Pe-BAE2f-83eIahL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 suspectscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120159 X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v7 3/8] fs/acl: Add ACL_OTHER permission test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Add test to verify ACL_OTHER permissions work correctly and are not restricted by ACL_MASK. The test sets up an ACL with: - ACL_OTHER with rwx permissions - ACL_MASK with no permissions (---) - Verifies that a user matching ACL_OTHER can still create files This validates that ACL_OTHER permissions are applied directly without mask restriction, as specified in POSIX ACL semantics. Suggested-by: Cyril Hrubis Signed-off-by: Sachin Sant --- V7 changes: - No change V6 changes: - Added HAVE_SYS_XATTR_H guard - Removed redundant error checking, relying on library functions - Updated algorithm documentation with correct format - v5 link https://lore.kernel.org/ltp/20260608092200.92827-1-sachinp@linux.ibm.com/T/#t V5 changes: - Switch to kernel only test validation to remove dependency on libacl and useradd/del commands. - v3 link https://lore.kernel.org/ltp/20260604065417.25924-1-sachinp@linux.ibm.com/T/#t V4 changes: - No change V3 changes: - Updated copyright header as per LTP format. - v1 link https://lore.kernel.org/ltp/20260602121958.27494-1-sachinp@linux.ibm.com/T/#t V2 changes: - No change V1 changes: - Use HAVE_LIBACL guards in .c code - Report TCONF when libacl is not available - rfc link https://lore.kernel.org/ltp/477836fd-80c8-4168-bfe6-00b374bb2534@linux.ibm.com/T/#t --- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_other01.c | 104 ++++++++++++++++++++++++++ 3 files changed, 106 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_other01.c diff --git a/runtest/fs b/runtest/fs index 69ecb8647..f25487a33 100644 --- a/runtest/fs +++ b/runtest/fs @@ -91,3 +91,4 @@ squashfs01 squashfs01 # Run the acl tests acl_user_obj01 acl_user_obj01 acl_mask01 acl_mask01 +acl_other01 acl_other01 diff --git a/testcases/kernel/fs/acl/.gitignore b/testcases/kernel/fs/acl/.gitignore index bfcdee93d..c3ec0fad3 100644 --- a/testcases/kernel/fs/acl/.gitignore +++ b/testcases/kernel/fs/acl/.gitignore @@ -1,2 +1,3 @@ /acl_user_obj01 /acl_mask01 +/acl_other01 diff --git a/testcases/kernel/fs/acl/acl_other01.c b/testcases/kernel/fs/acl/acl_other01.c new file mode 100644 index 000000000..41349223e --- /dev/null +++ b/testcases/kernel/fs/acl/acl_other01.c @@ -0,0 +1,104 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2026 IBM + * + * Original shell test by Kai Zhao (ltcd3@cn.ibm.com) + * Converted to C by Sachin Sant + */ + +/*\ + * Test ACL_OTHER permissions using direct xattr manipulation. + * + * Verify that ACL_OTHER permissions work correctly and are not affected + * by ACL_MASK. The ACL_OTHER entry controls access for users who don't + * match any other ACL entry (not the owner, not in any named user entry, + * not in the owning group, and not in any named group entry). + * + * Unlike ACL_USER, ACL_GROUP, and ACL_GROUP_OBJ entries, ACL_OTHER + * permissions are not restricted by the ACL_MASK. + * + * This test uses arbitrary UIDs without creating actual users, testing + * only the kernel ACL implementation. + * + * [Algorithm] + * + * - Set up ACL with rwx permissions for ACL_OTHER + * - Set ACL_MASK to --- (no permissions) + * - Attempt file creation as a user matching ACL_OTHER + * - Verify access is granted despite restrictive mask + */ + +#include "acl_lib.h" + +#ifdef HAVE_SYS_XATTR_H + +#define TEST_UID 1000 +#define TEST_GID 1000 +#define OTHER_UID 2000 +#define OTHER_GID 2000 + +static void run(void) +{ + struct acl *acl; + + tst_res(TINFO, "Testing ACL_OTHER permissions"); + reset_test_path(); + + SAFE_CHOWN(TESTDIR, TEST_UID, TEST_GID); + + acl = acl_init(); + + acl_add_entry(acl, ACL_USER_OBJ, + ACL_READ | ACL_WRITE | ACL_EXECUTE, 0); + acl_add_entry(acl, ACL_GROUP_OBJ, 0, 0); + acl_add_entry(acl, ACL_MASK, 0, 0); + acl_add_entry(acl, ACL_OTHER, + ACL_READ | ACL_WRITE | ACL_EXECUTE, 0); + + if (acl_set_file(TESTDIR, ACL_TYPE_ACCESS, acl) < 0) { + if (errno == EOPNOTSUPP) { + acl_free(acl); + tst_brk(TCONF | TERRNO, "ACL not supported"); + } + acl_free(acl); + tst_brk(TBROK | TERRNO, "ACL setup failed"); + } + + acl_free(acl); + + try_create_as(OTHER_UID, OTHER_GID, 0644, 0); + + cleanup_testfile(); +} + +static void setup(void) +{ + reset_test_path(); +} + +static void cleanup(void) +{ + cleanup_test_paths(); +} + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .cleanup = cleanup, + .needs_root = 1, + .mount_device = 1, + .mntpoint = MNTPOINT, + .forks_child = 1, + .filesystems = (struct tst_fs[]) { + {.type = "ext2", .mnt_data = "acl"}, + {.type = "ext3", .mnt_data = "acl"}, + {.type = "ext4", .mnt_data = "acl"}, + {.type = "xfs"}, + {.type = "btrfs"}, + {} + } +}; + +#else + TST_TEST_TCONF("sys/xattr.h is not available"); +#endif -- 2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp