Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9C5FB67E for ; Sun, 14 Jun 2026 20:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781468950; cv=none; b=DGXP0WLzS77045I07NfdT1aQ1TZNN4V1FZnn62NurCt1zFB2n7cj1GD8fxi4n0yn0+xeJVnIrEirdse47HWvZugYN0b6pQcmnQrBwevS9HWrHTVDs9G3p6ea0jKHapqvxjuLLdAy77Cgxj8ZJJ1Z7sTYCT5njL9FAfgOTAmjnCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781468950; c=relaxed/simple; bh=UWqmPBb9lYmUHte5jzGL4bwmzok/E1L2sfK+HjXsU80=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cAJjPgqyea0HxSQp/LrKd3zl0CRQVK+7kWmw5Ts3Jowh0ugkbbleZ6x2OLI5sHmF7sLyCbp8kOnp34jQwktQPPAeqp/aPSfGxLXIzGMEVyq5lniuYcWU6rWKa8iKvuRZVk4XMLfbzvvUbqltn/LIalL2O9O3uQxFhQ2lGdhthwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lm7C19HY; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lm7C19HY" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-36dac5d5da0so1168978a91.2 for ; Sun, 14 Jun 2026 13:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781468949; x=1782073749; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ywqQuCxykmaaSjgy3GzHJjbLWrbgi091EGla2oDbBMo=; b=Lm7C19HYhhllzCo8SMQwlLE3mIPtw5URjNlBfuyRprUP86Q2BLV6KAy1cYuIIyix6W 3G0mXMtbZy4CVOLTu4g7dXT7iVgz/7nvmetqUNtY1s0mx7YxU5eN6o/5oxcudcOsQ73y CmiDm67U2G3RWzMUS8eMlcx+zdSqPPSAgQ9hXelkVhVWOmEQtlIW+jNrXlCYj4LD+DNn b5GKgh6bAW6B5VCVO+56JNRAVBCl8ff6sQ6KegJrtkgXntKUiLL4uhVUfmPuSiLn1z11 y6RJ5B2kL++jonCch5aVfiqKEp1maSLxpq0EybfRepklVy4kz2xrjwaVnYb515RBv/KQ kOHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781468949; x=1782073749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ywqQuCxykmaaSjgy3GzHJjbLWrbgi091EGla2oDbBMo=; b=jB6uI1PI9GwS7OeVDswFwBe0CqYvTyhlE3C4SekAWjysjF4BOu0B4SutLc5yvveLkQ j3Gbl5ggxTHfCQTftmQOjnZt+5MYD/Ouy3ntqcF/lnncIUbYidOM/gvPu3P3ku9QMdYT PfFG004JZ3RdgWUaz+AT1oZqivP1Uuz1jTIGKcA339qlpzQ3s1Mxylf8PgbU7pMyjAlT /XjLFVhwWLqqVwrYrwcGgAHVB3Iq82U0qBdVOYqfeuTSKY4lKa6q+Y37bcrrEwvHvm3v uaMOuUCv5pxN9cIdasvAd89Yvz3ZMAJNSePgj0a56at+ZYtcYErHhyEXhEkzizpgYNoU MvuA== X-Gm-Message-State: AOJu0YwO9SdLqZv5GOS5S42RWJRxwVbMvdNAc51dDS6U64tnLlfXpD5j OEuDqgcQrGvHAvVhFP0Gg/jWJ+tLaHHNjPtAlDJjpPbfu/GyCDuMqIE5NMyZ9dOO X-Gm-Gg: Acq92OFlLrZt4M7UCg0bbuqq0U/u84fu/qtw/b7/y5PYeeK5wMqhsus5H0NkunyCrbX ECQJX2NHl47kwCiPAH1ol+a5hyELDYFDjQj2JuDhvh5iFqrA8BvE7hc2dQXsER/HhJcwBKbHLZc z4hpt4ru1qtmJsTT5fkJLVaL7ndEhzFE4FBdWPV9ODKogfrxH7wwYGHEv9K/ASuu7xTyZNVPAhJ Qp10A/TyF6Yiry93wMJU71AalVl2sDymMHRdmIbF8murdWmH5uT8YFZ0oMGB7p4F/emfGKlVRTV 8DbY9ZozV2Xb/MLi6xCN2aSy7+vpU24Mch3pwkMYz/56p/4PXPbUFzfMTxFnUf2AlADvmV9joid 3cEu4jXuee3oeU2sa8/rqK0IEpkY0u5Upv9vOgU97kmaGleJvqeUrw0i5auZO1279eWTYRyV85g h3Ox/Fw34fZZR9///WNJ0KedSBjgrnMDQe3bxflGyJt6EvkqHUxVTj X-Received: by 2002:a17:90b:4f48:b0:379:1f28:cdc2 with SMTP id 98e67ed59e1d1-37a034f50e3mr11678185a91.13.1781468949119; Sun, 14 Jun 2026 13:29:09 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-379e8cc467csm5439828a91.2.2026.06.14.13.29.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 13:29:08 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: Biren Pandya , Mauro Carvalho Chehab , Hans Verkuil , Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v3 05/22] media: i2c: saa7115: Add missing media_entity_cleanup() Date: Mon, 15 Jun 2026 01:58:05 +0530 Message-ID: <20260614202835.11977-6-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614202835.11977-1-birenpandya@gmail.com> References: <20260614202835.11977-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The media_entity_pads_init() function initializes the media entity, but the driver forgets to call media_entity_cleanup() in the error paths and remove function. Add the missing calls to fix the API violation and prevent potential future memory leaks. Signed-off-by: Biren Pandya --- drivers/media/i2c/saa7115.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c index 48d6730d9271..64adfff3001b 100644 --- a/drivers/media/i2c/saa7115.c +++ b/drivers/media/i2c/saa7115.c @@ -1867,6 +1867,7 @@ static int saa711x_probe(struct i2c_client *client) int err = hdl->error; v4l2_ctrl_handler_free(hdl); + media_entity_cleanup(&sd->entity); return err; } v4l2_ctrl_auto_cluster(2, &state->agc, 0, true); @@ -1925,6 +1926,7 @@ static void saa711x_remove(struct i2c_client *client) v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(sd->ctrl_handler); + media_entity_cleanup(&sd->entity); } static const struct i2c_device_id saa711x_id[] = { -- 2.50.1 (Apple Git-155)