Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A156CD98F1 for ; Mon, 15 Jun 2026 20:19:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D48510E688; Mon, 15 Jun 2026 20:18:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=lankhorst.se header.i=@lankhorst.se header.b="RPzyHNg7"; dkim-atps=neutral Received: from lankhorst.se (unknown [141.105.120.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E9B710E672; Mon, 15 Jun 2026 20:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lankhorst.se; s=default; t=1781554725; bh=r10AAnKUQPrCjn4nwCrtFvliOfdGv8y4HVOMxu4pQsU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RPzyHNg7hvxY4KH+CHQ31ZGhf7GcHRMsSokHWc02q1Qw13qqOtCKsOw73bPl/2G1d EB865K+ml4gQDnoZHzLeIVWR5YG+4R836SDaaXrZW0oMGfRioDXVHVBGUg9gCdNqQv TbqY0xV2qie8M5vy3anRhTLnAzZxNkzMYVogdBLHZxHanMDtA9N/soqafh55CGEKog OJt8YOXCGGb62YZiEfdXzdea2vem5LfB7m2wYGEeIgfEL/TJiC9fPLMiZv7Niw5R94 Qs2REgu1+9dSQicUuzynhs0b45kwdgBw7UuA+YR8PzmqROdZgnZ7Qxup4iApMgMBLx /Zvks48Mn7VyA== From: Maarten Lankhorst To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst Subject: [PATCH v8 20/27] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Date: Mon, 15 Jun 2026 22:18:38 +0200 Message-ID: <20260615201846.307297-21-dev@lankhorst.se> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260615201846.307297-1-dev@lankhorst.se> References: <20260615201846.307297-1-dev@lankhorst.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" TODO: Grab uncore lock during entire vblank evasion before disabling interrupts, and check what breaks? Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/i9xx_wm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/drm/i915/display/i9xx_wm.c index 86d1c9f7f0ff0..e07303f0b3cc4 100644 --- a/drivers/gpu/drm/i915/display/i9xx_wm.c +++ b/drivers/gpu/drm/i915/display/i9xx_wm.c @@ -1863,7 +1863,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, struct intel_crtc *crtc) { struct intel_display *display = to_intel_display(crtc); - struct intel_uncore *uncore = to_intel_uncore(display->drm); const struct intel_crtc_state *crtc_state = intel_atomic_get_new_crtc_state(state, crtc); const struct vlv_fifo_state *fifo_state = @@ -1892,7 +1891,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, * intel_pipe_update_start() has already disabled interrupts * for us, so a plain spin_lock() is sufficient here. */ - spin_lock(&uncore->lock); switch (crtc->pipe) { case PIPE_A: @@ -1951,8 +1949,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, } intel_de_read_fw(display, DSPARB(display)); - - spin_unlock(&uncore->lock); } #undef VLV_FIFO -- 2.53.0