Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E57C335F161 for ; Mon, 15 Jun 2026 23:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781567452; cv=none; b=D5HXiY7+07NhtsKB3TVZ01du8ZHFH0JAFlp097aC6JLtawbHMs4FrhA6c6HgSQCBNXLH8acZxlHMlGoLL+F92sGUl1KNFDGUXNT7LZE2GZ/t2zGtmuQmzYbTyj5sbNvc4ZKXwCu6GOhIWHSnfm9grgH1/xutuOj4AHMxTQFH6Ys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781567452; c=relaxed/simple; bh=v4l5BP6mSyjUVIp0jSkZQ5FNJamGyYJzyXE/hmgYprs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TvmPhiVT/c7BTKSMXRhf+Yit7FUHqoMQfJ4CfOQLMvxszKVSmxrQTdH8f8RL/SY+6kWUydPknwkW5BzbUNM9N+ggg7/u+8iJ0iicLqvRT0h0i8FDfdk3uTb7l6nn3NIr8PnjYG8qQvdUSIiZhhHR/2MswsHGRgyqSJLRnAsDv7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--praan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CQc/eWkR; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--praan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CQc/eWkR" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-8422b544a4bso2685843b3a.3 for ; Mon, 15 Jun 2026 16:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781567448; x=1782172248; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ghCN2ryt2ezJV5YU5b84fUdE6lXkqtPvhPQAH6Ew2wA=; b=CQc/eWkRcQR1rJimY91pkqwtPef74itQn7Li8qr4Ugde66Y5xClW6QB+z4RnAXjO7G ygMLykKTHHCPuzPgF/5KOTqNgd8LxQqlUTfig5TzM2Kjw1eXKisp0tGhX+KT5p/H6J71 UFUV6347lRdek76mFSBXKvvcqfQdhjCJWcFaMlDWRFHkvTVcbu6KfGVkIBBBKQXIPYF6 Ybm2oEz7wKupSTAKzm13CAm08Zoyq9C4l9GrZ2ugkqIQTedIxvoZhg0CM6yt0ovG2i5p 1HmOIMZ05yVr/sgzoP7DMbY0OXf6PvfvrRthTMeW3Df+Jp73driUQZsGhG4xErk/IxDh 5IMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781567448; x=1782172248; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ghCN2ryt2ezJV5YU5b84fUdE6lXkqtPvhPQAH6Ew2wA=; b=cF+YHRAUUb5Ykk8gchSuwveH0Cxgav1Q8GozCEDOzg01A7Qj74IGTKISDcXNEwBgiM tob/cMqXfOMC0i+dkeWRfMvsR2Nh7Sx56zkyz/R/ViJXGQZimwPR/1Iv/pc+1FutnVLk 57alaAtbxVEHNCm4vVYxKMYoDmEo7uSwi7S4aa7R4E08TRUoTob5Z4oP22h/IGBLuViB xHZizOyVP6EpK+QWOsIgdSFnghKJA9K3AgZhOnzkh6b25n2fNyfujjuhRFxMBlKu3ZYt S8MkMO12vHYgIl6RtpdSNspKjO4yVhXVkimuATJ8941Fth7T+Egy3ehYJ0p7dPIU7N9C QhZw== X-Forwarded-Encrypted: i=1; AFNElJ8gb9P1zYvMCrVVwCHjpHQd2sMAmdogV61Lmlp9SOrvemyaTjJOTKHU308i1kK0PmiDXmJwpXg7/k8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0NGJOoW+ZZ8Xh/HZAe3UmHU/DNKC/0fHDciTEu8hPd4fQd976 0qqaXGqj5RYeoDYcML9qkA//59c32S84jJN9mSXRw/6qJc9rywgwJui9lTaHZ9m0b/oxjR116QU 6Wg== X-Received: from pfbha13.prod.google.com ([2002:a05:6a00:850d:b0:83f:682:48d5]) (user=praan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2d01:b0:842:708f:39be with SMTP id d2e1a72fcca58-8451530d5bamr987400b3a.5.1781567447898; Mon, 15 Jun 2026 16:50:47 -0700 (PDT) Date: Mon, 15 Jun 2026 23:50:36 +0000 In-Reply-To: <20260615235037.259909-1-praan@google.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260615235037.259909-1-praan@google.com> X-Mailer: git-send-email 2.54.0.1136.gdb2ca164c4-goog Message-ID: <20260615235037.259909-4-praan@google.com> Subject: [PATCH v9 3/4] iommu/arm-smmu-v3: Standardize ATS enablement failure reporting From: Pranjal Shrivastava To: iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Joerg Roedel , Will Deacon , Robin Murphy , Baolu Lu , Jason Gunthorpe , Kevin Tian , Bjorn Helgaas , Samiullah Khawaja , Pranjal Shrivastava , Nicolin Chen Content-Type: text/plain; charset="UTF-8" Update arm_smmu_enable_ats() to wrap the pci_enable_ats() call in a WARN(). Since probe-time checks now preclude configuration errors any failure during hardware enablement is considered a kernel bug. Reviewed-by: Kevin Tian Reviewed-by: Nicolin Chen Reviewed-by: Samiullah Khawaja Reviewed-by: Jason Gunthorpe Signed-off-by: Pranjal Shrivastava --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index a10affb483a4..57b750ebcd3d 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -2956,8 +2956,13 @@ static void arm_smmu_enable_ats(struct arm_smmu_master *master) * ATC invalidation of PASID 0 causes the entire ATC to be flushed. */ arm_smmu_atc_inv_master(master, IOMMU_NO_PASID); - if (pci_enable_ats(pdev, stu)) - dev_err(master->dev, "Failed to enable ATS (STU %zu)\n", stu); + + /* + * Since pci_prepare_ats() has already verified the HW capability + * and programmed the STE, pci_enable_ats() should not fail here. + */ + WARN(pci_enable_ats(pdev, stu), + "%s: Failed to enable ATS (STU %zu)\n", dev_name(master->dev), stu); } static int arm_smmu_enable_pasid(struct arm_smmu_master *master) -- 2.54.0.1136.gdb2ca164c4-goog