Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EDF8CD98E4 for ; Mon, 15 Jun 2026 23:57:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D466710E790; Mon, 15 Jun 2026 23:57:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="FPlfikV/"; dkim-atps=neutral Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011010.outbound.protection.outlook.com [52.101.62.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6494D10E77F for ; Mon, 15 Jun 2026 23:57:20 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MG43p6tUEiybHcxGCZUwPrRZKLbA+CTRzaBcDsUOUFQwXHotjf+RHn6Umm+0PJ71PjH6UtJHO/zwKzVc23A5cCGRWH1ADyd8Rbmac66Du9rMlbpI85bQGGgBmjiResPhFzlhBJGKlPo2aHs/8ic81RpXnIeW3ma2iqodfihYxRKpcuvtxdVQ1T+zSGNSqG2TvEReEnn0SmkRYI60mkQl1DtDiYXl/lcNw1KqAr6Jyw9KDWHAs9Ab+xLh/SLBfpe6w/KlGBd1t0IDyeQYKzcoRIX5yw6yfvERAsHsr/t/4olVKYb54uNu1sYd0huIRXf8myK6pyuMF0vekjUaZ5nVkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n2SDti4CQllACHPNcjDpn3a3j/76Sjup95e+2oJH5BE=; b=EOUQykvJPBcVbjUHMJPEt4iIDuqGp0WZyRKttb5rvqC8NvbQVqRkVba3BoYxTuzfCXpFotanALLja0F1UVl1lXoCjfoPL58MrZOv8VmjcKTK5CueNBuSbyrdJoS237nBG6qvI8iaXRNpt/naraS5iu5vgVyUhotL4ePeIVmKkevYghDOZpw/j/csJpjCjZvXa6yevezdsqIKronjI0NqgYMjHO0/js8KR5cQPzKR+b17/8hMtfFbReb7cWRjbFDTGDTmLJqlc8upxOUYauUZ+Upjnqyzuk3w2dsD4s2NCkhvZFWblRtWlL9KKr05xdHP2lKA7gDNIAn0jCTCOp5kow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n2SDti4CQllACHPNcjDpn3a3j/76Sjup95e+2oJH5BE=; b=FPlfikV/5jkShUY/snPICtrBzxR1SNmEeBtJia3dHMg3YiGeHdI9qydAEqaqyXhre9FNW/p7mi3vSxJ3Xb+Xh4aH9PNBSHmsX+zGsTaTVi3UKKOhy0hz0l5tn6qTMNRDF6epbfsBXtWigEuMZ0Cnq8EOoAE/68pOx1JXcsHfutI= Received: from CY5PR22CA0038.namprd22.prod.outlook.com (2603:10b6:930:1d::6) by IA0PPFDDA81179A.namprd12.prod.outlook.com (2603:10b6:20f:fc04::be9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.18; Mon, 15 Jun 2026 23:57:15 +0000 Received: from CH3PEPF0000000D.namprd04.prod.outlook.com (2603:10b6:930:1d:cafe::38) by CY5PR22CA0038.outlook.office365.com (2603:10b6:930:1d::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.113.18 via Frontend Transport; Mon, 15 Jun 2026 23:57:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CH3PEPF0000000D.mail.protection.outlook.com (10.167.244.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.8 via Frontend Transport; Mon, 15 Jun 2026 23:57:15 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 15 Jun 2026 18:57:10 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 15 Jun 2026 16:57:10 -0700 Received: from p8.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 15 Jun 2026 18:57:09 -0500 From: Alex Deucher To: CC: Alex Deucher Subject: [PATCH 34/43] drm/amdgpu/psp14: replace BUG() with an error Date: Mon, 15 Jun 2026 19:56:36 -0400 Message-ID: <20260615235645.737189-34-alexander.deucher@amd.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260615235645.737189-1-alexander.deucher@amd.com> References: <20260615235645.737189-1-alexander.deucher@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000D:EE_|IA0PPFDDA81179A:EE_ X-MS-Office365-Filtering-Correlation-Id: 810beb1c-9851-423d-e7be-08decb39d35e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|23010399003|1800799024|36860700016|376014|22082099003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: sv2mEWEJcjCgdzC9zZrZIr1g317giqdGhnnrl9iiNcxAk5QbHn/AxE14NZp3FOxlIMhDNw1My6t4+yoJZXb+BsMohGeH/H0eniMdjDPAHSo1dVSxmRiySlBAsSDqFz7/DF7fc8dClKHeZYEN3okTN1fR1MNuKl3AuYUBZ3Bl3UJvz8dMVnZrw6MxbRb9hDHEqRhCB+bYgyloxKHVUukfFgW7Z48AoRAXiTesrKpnlm6d7PLc5hR2c8OgrgWs8ZdXJ0flijgYsFfKArUsAEHvIFeYzaN3HXF9ZmHttIpS875GEmwIJwc11ZiT1pMFzOkQrl8IPcpI/BkuHI0hWxEttq0iy6egpIS+7iCzFYUtS4l0DFVvldA5RFRLF/Rlh0WfgWiZUohEHvhjju3l84aJFGZnmi4MHZvGArmJthN9f1xnG2MdZFXE02DZLu8Txhn0co6sy7Z04i7iE0QOYGm5WbXNaEqO07IoP4kTO+oHMgR0YLVr4r0IuUw+ykC/2p1jV1MD7vYm2h9ocqzV7GhXHMvPhZcS+OYzV+CTdS2WnvICr6WiGowZ2qnCrSswLj0aCCEIIR2jpu3y9lYLRibCSF5aML2qtWZS9c29igjzwWkdf5h3go1XisD8S87izKP1duyfwgTeJ5bXsT2tKjrmrN3Bi7hPpwcshdII8BXMFE3iD/o+rEjMtrped8vcrOFYwmyV9x5VRGjHW4qZwwnHzU/ZtUtf4KuOlsfvBnalzus= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb08.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(23010399003)(1800799024)(36860700016)(376014)(22082099003)(18002099003)(56012099006)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4V5z6J3yronsmr+/R3xfrUO1F5Bb/7eptlx20SzryZrxx0X9onu+qsXO7ky4y5Wt7iUAJh9lzuNw3+dGtyB6KdbiDMLfWS3ZUQhqRCC1NiuQzl0CZV5cUvarTIQ5HUh4CpXH6jyFzE/147tBxez/aecJFVBwxYB+wmFqgVfq6c6rdmwES5Q9bCOjN7YSvxIT1YEvneg9AKlfpdTdESLxsov+5ucc0y8F/5vQNKhWpSNN8V37cMPluEUdAhbYG2SUcxnzyTJszWEj0TA+unyLnqtVRlv6gpuFOCmy796Ze4TElt4/I2csQffq8xRMy6NlSHjkCpikb8bUyeR97WXO12+ZN++j+zODNJtb9Ka5kYUQE0GuMmovyLpXw8VO8KSGIdBnwB/+oFuTe77rAdyh3MSKdfPB+3BjtEbsQDcm/E/hpqQ99xH2GFAVUuB8attx X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2026 23:57:15.2440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 810beb1c-9851-423d-e7be-08decb39d35e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PPFDDA81179A X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" There's no need to crash the kernel for this case. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/psp_v14_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v14_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v14_0.c index 040a61aefa866..7ed5f41969330 100644 --- a/drivers/gpu/drm/amd/amdgpu/psp_v14_0.c +++ b/drivers/gpu/drm/amd/amdgpu/psp_v14_0.c @@ -85,7 +85,7 @@ static int psp_v14_0_init_microcode(struct psp_context *psp) return err; break; default: - BUG(); + return -EINVAL; } return 0; -- 2.54.0