Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB055CD98DA for ; Tue, 16 Jun 2026 06:17:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB9D910E849; Tue, 16 Jun 2026 06:17:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="iaoK2kIY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E63910E83F; Tue, 16 Jun 2026 06:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781590654; x=1813126654; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=vakdS0RWKPdZjULWL/DtdhjQ54nVs6GvcshDC3opdUo=; b=iaoK2kIYFHKNfvHqwYIdJFRbEVNiLYwpExWcTHNYi4EsyEri2uoeRvTr oFi9RnnM5CABxP38tubUhr7MQdExoi9DzV09pARsjIszGvZWldHh7Sl5a peNMuYH4WCn4Qa9NZbS2iiudFfSPvzNdhx5K+hxIyKG7Ktd+k4/1/J4Q9 CpQpVzow9xNg/Wvy8y7aB4sI/zdmmgY01qIbX567Hgn/hosFZlJtGHFXf XTTRGW/zmyvvnIL3AaO7/rIsGXqtaBe5S2m0hJhfZ6W5YGCC0N0EdHqxr HVuaWfHkiVUN7W19GylEZdm2IJdMw04tRG6aRz2A4c48sA1wRgKwRm47z A==; X-CSE-ConnectionGUID: hzw1yD1SSkyG+yALW3d2ow== X-CSE-MsgGUID: BCwdY4BARsK5wokupdldmQ== X-IronPort-AV: E=McAfee;i="6800,10657,11818"; a="82088152" X-IronPort-AV: E=Sophos;i="6.24,207,1774335600"; d="scan'208";a="82088152" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2026 23:17:34 -0700 X-CSE-ConnectionGUID: uGqHe/mrRE+NP/4hiQjVjQ== X-CSE-MsgGUID: JY8W8yXFQMKp1LAnDjMYbA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,207,1774335600"; d="scan'208";a="251973669" Received: from srr4-3-linux-106-armuthy.iind.intel.com ([10.190.238.56]) by orviesa004.jf.intel.com with ESMTP; 15 Jun 2026 23:17:33 -0700 From: Arun R Murthy Date: Tue, 16 Jun 2026 11:45:52 +0530 Subject: [PATCH v2 2/2] drm/i915/display: Refcount for fec enable/disable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260616-fec-v2-2-49a22680138c@intel.com> References: <20260616-fec-v2-0-49a22680138c@intel.com> In-Reply-To: <20260616-fec-v2-0-49a22680138c@intel.com> To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Arun R Murthy , Stephen Fuhry X-Mailer: b4 0.15-dev X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The FEC_ENABLE bit is per port basis and is enabled/disabled on ddi pre_enable and post_disable. This fec is shared across the mst streams and can be enabled per stream basis as well. So have a refcount to track the usage of FEC and then enable/disable accordingly. Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/16073 Signed-off-by: Arun R Murthy Tested-by: Stephen Fuhry --- drivers/gpu/drm/i915/display/intel_ddi.c | 58 ++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_ddi.h | 1 + drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++ drivers/gpu/drm/i915/display/intel_modeset_setup.c | 6 +++ 4 files changed, 68 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 25314ec65ae77b91bf4d732c229f236d070e18cc..477a11a63fe8f8d6731905be21de34dcbaa895b5 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -2096,6 +2096,47 @@ void intel_ddi_disable_clock(struct intel_encoder *encoder) encoder->disable_clock(encoder); } +/** + * intel_ddi_seed_fec_refcounts - Seed per-port FEC refcounts from active CRTCs + * @display: display device + * + * intel_digital_port::fec_active_streams is the per-port refcount that gates + * programming of the shared DP_TP_CTL_FEC_ENABLE bit. After initial HW state + * readout (driver load, resume, GPU reset takeover), the persistent + * crtc_state->fec_enable values reflect what HW currently has; we need to + * align the refcount with that so the first paired disable doesn't underflow + * and the next enable doesn't incorrectly skip programming the HW bit. + * + * Must be called once after intel_modeset_readout_hw_state(), before any new + * modeset commit can run. + */ +void intel_ddi_seed_fec_refcounts(struct intel_display *display) +{ + struct intel_crtc *crtc; + + for_each_intel_crtc(display, crtc) { + const struct intel_crtc_state *crtc_state = + to_intel_crtc_state(crtc->base.state); + struct intel_encoder *encoder; + + if (!crtc_state->hw.active || !crtc_state->fec_enable) + continue; + + for_each_intel_encoder(display->drm, encoder) { + struct intel_digital_port *dig_port; + + if (encoder->base.crtc != &crtc->base) + continue; + if (!intel_encoder_is_dig_port(encoder)) + continue; + + dig_port = enc_to_dig_port(encoder); + dig_port->fec_active_streams++; + break; + } + } +} + void intel_ddi_sanitize_encoder_pll_mapping(struct intel_encoder *encoder) { struct intel_display *display = to_intel_display(encoder); @@ -2413,12 +2454,22 @@ static void intel_ddi_enable_fec(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state) { struct intel_display *display = to_intel_display(encoder); + struct intel_digital_port *dig_port = enc_to_dig_port(encoder); int i; int ret; if (!crtc_state->fec_enable) return; + /* + * FEC is link-wide: DP_TP_CTL_FEC_ENABLE is per-port while + * crtc_state->fec_enable is per-stream. For DP MST, several streams + * on this port share the bit. Only program HW on the first stream + * needing FEC; subsequent streams just bump the refcount. + */ + if (dig_port->fec_active_streams++ > 0) + return; + intel_de_rmw(display, dp_tp_ctl_reg(encoder, crtc_state), 0, DP_TP_CTL_FEC_ENABLE); @@ -2454,10 +2505,17 @@ static void intel_ddi_disable_fec(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state) { struct intel_display *display = to_intel_display(encoder); + struct intel_digital_port *dig_port = enc_to_dig_port(encoder); if (!crtc_state->fec_enable) return; + if (drm_WARN_ON(display->drm, dig_port->fec_active_streams <= 0)) + return; + + if (--dig_port->fec_active_streams > 0) + return; + intel_de_rmw(display, dp_tp_ctl_reg(encoder, crtc_state), DP_TP_CTL_FEC_ENABLE, 0); intel_de_posting_read(display, dp_tp_ctl_reg(encoder, crtc_state)); diff --git a/drivers/gpu/drm/i915/display/intel_ddi.h b/drivers/gpu/drm/i915/display/intel_ddi.h index 580ecb09b8b606e07445c7e26142a2fcfa69a2d2..3678c28a0dc952d4962428893c519fb7d41e4422 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.h +++ b/drivers/gpu/drm/i915/display/intel_ddi.h @@ -78,6 +78,7 @@ int intel_ddi_toggle_hdcp_bits(struct intel_encoder *intel_encoder, enum transcoder cpu_transcoder, bool enable, u32 hdcp_mask); void intel_ddi_sanitize_encoder_pll_mapping(struct intel_encoder *encoder); +void intel_ddi_seed_fec_refcounts(struct intel_display *display); int intel_ddi_level(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state, int lane); diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h index aa4772a1c208e4cb4bb6f51dc0dcc2349e422dd0..276d4cc21d6ecdd8c17777608e59223d9f49c554 100644 --- a/drivers/gpu/drm/i915/display/intel_display_types.h +++ b/drivers/gpu/drm/i915/display/intel_display_types.h @@ -1989,6 +1989,9 @@ struct intel_digital_port { struct ref_tracker *ddi_io_wakeref; struct ref_tracker *aux_wakeref; + /* Number of active streams on this port currently using FEC */ + int fec_active_streams; + struct intel_tc_port *tc; struct { diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c index e8730b5baf2a4bd2e5edfc5fc8fd2622a57d2a4e..4b6abcb1dd928ab2bc9b17f0521db78ebb6ef586 100644 --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c @@ -952,6 +952,12 @@ void intel_modeset_setup_hw_state(struct intel_display *display, intel_modeset_readout_hw_state(display); + /* + * Seed per-port FEC refcounts from the just-populated active + * crtc_states before anything can issue an enable/disable. + */ + intel_ddi_seed_fec_refcounts(display); + /* HW state is read out, now we need to sanitize this mess. */ get_encoder_power_domains(display); -- 2.25.1