Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83B892EB5A6 for ; Wed, 17 Jun 2026 18:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781720476; cv=none; b=vEul0+BfxbJvdf8BFeC+uaWskV+yCuKmZosMBLfqgG2AQrDiU2QRm+/cx2Z0NgKqlJNiitbSkOs9Mh5CM5gPrRdsXiFTyYElSq6T8F4bIsMClnR+cyEvDbgmkhfHHQXjRbe/NIr+QP3+io93TvJ6PyQGfRDJnadIFjjRTsQSBjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781720476; c=relaxed/simple; bh=Ez1R70u0pjTvK9RDuFXCRrYuzRwVlXAohkgLXlI7IKE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=tt8rGhCgkBTaY68zPqYyCy9wY4muAg51GIMm/8cn3Dm1NICsFUOvSF8x90x5wIjrIRkYcQkMw7ybqCaUOI153jygrCrLmzGpNQjXGTRqURyFpO8ItKAqLFjVMbJnLFPZYSALxbpawKrUiRDi4YEfMW6tOgWWlywZLV1YsllMz1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tJ2S9GuK; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tJ2S9GuK" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-30b6dad2382so223969eec.0 for ; Wed, 17 Jun 2026 11:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781720475; x=1782325275; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=pYk40mpdYuWia4WWcgsPUz1So5Kdav6fDmRlP7pHt3U=; b=tJ2S9GuKg7/2Tn+DhPtQaxk+B0PzSxJ6PUXgYKyy50JgtanYmdwfACx896rwLBy3EV JrCOPfeDljxwYLxXV7J3+3iRBvO1a3E1pqqeqIGVM5rS1pUHH8vidfgnb+6pN46t7niN c54U0YuqEYWPAWv5RKjd+JVy8VHyK9h2srgd2i0fcvbmIBhq90GD2wdWwG6k4Fe+EYk8 rTTiRJ0Hw+WDoSDBeRbmAkiW45Cu6pX7FXu5sxy5nm+b66LyxJFIyMt22JoCrEWHQnVZ wTCABOmRn5K1Lk5DD6GEE8VuqYmnOt7Cbrayf82vKbTC24k+IpUfXNclb1LbaNgqKn7O k0BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781720475; x=1782325275; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pYk40mpdYuWia4WWcgsPUz1So5Kdav6fDmRlP7pHt3U=; b=pDFfgFr+THF7+KBKF5xdIG2JquVZFyGdxWsvS8alEqiunAXxZUrXR1tUz3PdiRG4Ts QO3eNHQtktfgnLcQTQVg1BGXCvjVO/zgbLYtRX7fa1rrLlehPmM68Q14OWeRJMppYXWT OH8QrBW7oW1VGOdZKrZXEyYXu45P64JRxGUyfu1P45m0HhZYwFC1UOmby9J+zRXJFBmB kh2qPe3y21F/e9SBKq2fZOWv0QDTV7IeK49IWjMcNjVveA9N5SrapdNjPymKl1FuNtFv t/UxRryufMZzAS/ASePtH0ZZwM3tlqcpFE6VDYmeeRrs+D6ttB8jv9EC+Zf6hLIYrbao zwZQ== X-Forwarded-Encrypted: i=1; AFNElJ9rAz1wbHV2Aago84gYxCunUlJgDWOdwGeEPFn+I5BVLa/xhxyujX32e121vCRaKMmCZ/eu628OqSNKl/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxRfvz9r+GoBSNzWKYJhnFF8Lp2ELiCn2jppwSv3P7GfcGOoyf7 QHV8alqb0kg4nXG4FN1StW/WdyVXfuqnfQvdKs01gIHHp1gQ7HBsaCLT X-Gm-Gg: AfdE7cmiPsral8/jRIoGei9gsXPmla4qptdTB3A0QVj9Tt1D9k5j8RdT3KOSUkxOOm9 XYWzAm31EQZ6PAJ36+41ahWGtGgEPeROhD/9FsnxJ8JBJwQPM/tXqSpPLXO1vYAN5DaoXqzYKcU 35b+sk3pN0YUKu04TiPokKXin57ii7JLiQZn/pjX/HfpCbp1yokfrErlJxclghYVuxnHivMaCRA iZFKJZxqDx46qkcbAzLggVUk0IqtvctlsSNvFne5CJ6GdaO9azaAiAGy3O/dBhw/xIote1b4fPO 8zJAHc1VMXqbUg/iuoOnaTlI7gR4FwgPGSzvvHFJaMOm4WlCCrubJ3MGaIxqMb5u42iKGDGpuQh dyiWStxy5m0Yy2MRCKq2+86Rq1luUAh6KztCAcNL3Q8LAbbuUMDW9EKfx/NvtKnCibsNY+S5XLn sosO0cKWRHZ3bdMitg3JNA9iWqz4/Ya7+c X-Received: by 2002:a05:7300:6dac:b0:304:2eb0:2726 with SMTP id 5a478bee46e88-30bcae22973mr2899309eec.25.1781720474401; Wed, 17 Jun 2026 11:21:14 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1886:6b7a:3e78:272c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30bd23401ecsm3157945eec.25.2026.06.17.11.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 11:21:14 -0700 (PDT) From: Ruoyu Wang To: Yaron Avizrat , Oded Gabbay , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] accel/habanalabs: publish mmap buffers after allocation Date: Thu, 18 Jun 2026 02:21:08 +0800 Message-ID: <20260617182109.953680-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hl_mmap_mem_buf_alloc() inserts a new buffer into the memory manager IDR before initializing the descriptor and before running the behavior allocation callback. Handles from this IDR are used by hl_mmap_mem_buf_get() and the mmap path. A racing lookup can therefore take the buffer kref or inspect behavior-private state before the buffer is ready. Initialize the descriptor, run the behavior allocation callback, and only then publish the object in the IDR. If IDR allocation fails, release the behavior-private resources before freeing the descriptor. Signed-off-by: Ruoyu Wang --- drivers/accel/habanalabs/common/memory_mgr.c | 30 ++++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/accel/habanalabs/common/memory_mgr.c b/drivers/accel/habanalabs/common/memory_mgr.c index 9fdd34acf389f..b5b92dbbe5ddd 100644 --- a/drivers/accel/habanalabs/common/memory_mgr.c +++ b/drivers/accel/habanalabs/common/memory_mgr.c @@ -156,6 +156,17 @@ hl_mmap_mem_buf_alloc(struct hl_mem_mgr *mmg, if (!buf) return NULL; + buf->mmg = mmg; + buf->behavior = behavior; + kref_init(&buf->refcount); + + rc = buf->behavior->alloc(buf, gfp, args); + if (rc) { + dev_err(mmg->dev, "%s: Failure in buffer alloc callback %d\n", + behavior->topic, rc); + goto free_buf; + } + spin_lock(&mmg->lock); rc = idr_alloc(&mmg->handles, buf, 1, 0, GFP_ATOMIC); spin_unlock(&mmg->lock); @@ -163,27 +174,16 @@ hl_mmap_mem_buf_alloc(struct hl_mem_mgr *mmg, dev_err(mmg->dev, "%s: Failed to allocate IDR for a new buffer, rc=%d\n", behavior->topic, rc); - goto free_buf; + goto destroy_buf; } - buf->mmg = mmg; - buf->behavior = behavior; buf->handle = (((u64)rc | buf->behavior->mem_id) << PAGE_SHIFT); - kref_init(&buf->refcount); - - rc = buf->behavior->alloc(buf, gfp, args); - if (rc) { - dev_err(mmg->dev, "%s: Failure in buffer alloc callback %d\n", - behavior->topic, rc); - goto remove_idr; - } return buf; -remove_idr: - spin_lock(&mmg->lock); - idr_remove(&mmg->handles, lower_32_bits(buf->handle >> PAGE_SHIFT)); - spin_unlock(&mmg->lock); +destroy_buf: + hl_mmap_mem_buf_destroy(buf); + return NULL; free_buf: kfree(buf); return NULL; -- 2.51.0