Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CB9AE573 for ; Sat, 20 Jun 2026 08:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781942653; cv=none; b=BNVSG2zQCWdpB/fJbmLXK2oW3XNuv+YHIYEOyTFgdXmw8hKVuwnSI5TswUaP56kOfJjEliEA2SV8mWAzXD1ze5mV6tvTNOWzSSxMequmbnrje2A4Rl9suabcXPrPzuYonc8B8kHJfNI+itPhJNMHznxTf1/l/0hYq+/424TBDuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781942653; c=relaxed/simple; bh=vr+D48qZUZL4HK65fAvy4xudrWZiPByTLHbOTHkKFlE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XlAmpQJpD5XzmV2vAzNgYcroLxS2Bb49QzDwuAo8uJbVj8OQNykXCmoGScfFQ9N16GMSpU2WRQBYfS6zZMI+Au6i7GG7smaBtbatjevsTTSFYc5zLUx47qgGkXFd5v/RIa9N5cnRMEXiMCxemcRY3Tddkw3aBYMXBur/NToVVpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EVPgLndi; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EVPgLndi" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2c6bb8a5980so19536185ad.2 for ; Sat, 20 Jun 2026 01:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781942652; x=1782547452; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=heXg3yOXzX2LQOc/U/NrXde9JiDhaHN9Xy0IhhHBxTg=; b=EVPgLnditsnW4q/xYTK1+I1Il8n6UvMfeqX1Bd5IyjVRTsgn9sISketdOPw3ZbYCaa TGAZMP48YDw2BzW87+rbAH11DfPy6XQ6biBqNkBwqJg36SKkRJUIIrgvYPt1i0Gyyyzc zvG4wpv/GOjwBHk+XufenOiLWEiCX4LMd0chvPsPwtEmRD0BYaSGeLP2st6lJw3belCi 5+l1/EfvCKVzxmJFOIiBpATdU8+3BjHOMP66+ocjp0rjFnnX26LZ4qkyzZuN/r4t5xMW Pt3h5jKiprZMxeaLtGbgL4Jvhy1THug1GKziCdf+qVqiVfZV49tXywT2xTyF2WBlO/Hr +XVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781942652; x=1782547452; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=heXg3yOXzX2LQOc/U/NrXde9JiDhaHN9Xy0IhhHBxTg=; b=QDWaBmk5xn/FQWWv+UQeo76CzQuROD5zN2lUUBm/3V9WZqLjDGio/WTOjQOrBr/C9i 58ElSFvMrMhIlAfOQ6ITutgN5/mKSmnWUjHU8FYwaSfbP3GIfVIhkC+1xNJHjj+8vZHY W+lXGMKYdrFvC6cUNn9c5JIDsB0yDyIHs6NEiP8JeGGTUMxj3DlZl4sTIWhfP8rtSciS iTAJZpdtG7mdJwYLWtcmshpdbAr40ejCH6ZXQtqdyV9q5IBD17eRlY3b69w7RfGhQ52l GjaleJLqwuK4NsnZDwYmisJo+VWiga1r+HMX1arDlBtnm0G4KwmL329+vZLA4ebzl+RE eg8A== X-Forwarded-Encrypted: i=1; AFNElJ/nf2AL6hh0eUk5faJjA+4O7K78ka/fRj+a7+FoMFR+13FuCXYaTi+Bm3IAxwzhhdwwy+2mIjsPP5YwFJBr@vger.kernel.org X-Gm-Message-State: AOJu0YyJbZhd2ONIlIiOGMdJ628rcsUAAW3AskkMF5pQFvvLCwfHF1WB dDlmxNa7Z+IYZZ2fR7KU88qbBwQaqnPdyCqiOYjqazburJQW+CogTXfz X-Gm-Gg: AfdE7cnTFsqCETPrDV7eIfgE3RLiv5u7FwoukwzErbAMh9EkMEB/aT5TX4/aEu3sjQy iyEik+/hmSFFH4Z+RdEkUtJVnzP3mc9ILn72h312jlCbZZzsTTQ9ScRh2IbjdHEiaMO+8QV4X6X wdXkVVGTFj9UodPT6PnspSv3pTckzKro5D+Eue1StLMf47XNOIGg24PkHJoJ/p//igPXXBIVhQg PmygAI+H35GEzQoQ0rM/LgP81oE59jxc4V4wBQZM1+sSnNfDY2Gnea+THiQ1MI2gX5biPLkHM8e XeydlFkzVV7KKZ5jHyKvtZTZMRllPsaljx6fuL9KJCt0qK0vhpRB6h0kCcto42tYhlKD+13qggd z44X+uhH6xBlAzHeJlvGlpXNz7T48RuoB1/ExEII5gXxoW7bDWO2WQ7n8cNGr1CWFwbq57IYM6z BPz6WXzm0xoPtiMyhchRrpSIYBSRP2YkCI X-Received: by 2002:a17:902:d54a:b0:2b2:5515:661c with SMTP id d9443c01a7336-2c7190179a3mr76441265ad.31.1781942651724; Sat, 20 Jun 2026 01:04:11 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:8e0e:956e:b09c:23cd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7436d5057sm15676735ad.21.2026.06.20.01.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2026 01:04:11 -0700 (PDT) From: Ruoyu Wang To: Bjorn Andersson , Konrad Dybcio Cc: Linus Walleij , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] bus: qcom-ebi2: Fix clock leak on probe failure Date: Sat, 20 Jun 2026 16:04:06 +0800 Message-ID: <20260620080406.1970447-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit qcom_ebi2_probe() enables the EBI2X and EBI2 clocks before it walks child nodes and populates child devices. If reading a child node's reg property fails, or if of_platform_default_populate() fails, probe returns without disabling either clock. Route those failure paths through the existing clock cleanup labels so a failed probe does not leave the clocks prepared and enabled. Fixes: 335a12754808 ("bus: qcom: add EBI2 driver") Signed-off-by: Ruoyu Wang --- This is a minimal error-path fix for a previously reported leak. A broader devm_clk_get_enabled() conversion was posted in 2023 and reviewed, and a similar cleanup was posted in 2024, but neither appears in current upstream: https://lkml.iu.edu/hypermail/linux/kernel/2305.1/00605.html https://lkml.iu.edu/2408.2/09536.html drivers/bus/qcom-ebi2.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c index be8166565e7c..ab00c75b9e95 100644 --- a/drivers/bus/qcom-ebi2.c +++ b/drivers/bus/qcom-ebi2.c @@ -353,7 +353,7 @@ static int qcom_ebi2_probe(struct platform_device *pdev) /* Figure out the chipselect */ ret = of_property_read_u32(child, "reg", &csindex); if (ret) - return ret; + goto err_disable_clk; if (csindex > 5) { dev_err(dev, @@ -372,8 +372,12 @@ static int qcom_ebi2_probe(struct platform_device *pdev) have_children = true; } - if (have_children) - return of_platform_default_populate(np, NULL, dev); + if (have_children) { + ret = of_platform_default_populate(np, NULL, dev); + if (ret) + goto err_disable_clk; + } + return 0; err_disable_clk: -- git 2.51.0