Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AA1F846F for ; Sat, 20 Jun 2026 22:56:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781996195; cv=none; b=q9WazBflY6FUEElr+7siWxbXZv05Pb2dpBWM2+WsUhsWvsiizTEcti8DQHvUcNqcJy6UjFCK4XUtr/AAZ0V9HJnTFhMFAR5/QMTVugHewyLy5zLIJR+praI/o25+GSrecItvJsC0JF5Nk+4tphs+UWu5DI868oJtwny3B5Upeds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781996195; c=relaxed/simple; bh=xSrV5W6FCVhMVAthvp6iyaiAqSPNNqtYDP65fkDjiCs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZNumCFEbUKAwIyvSlib1SaxJqNcoPHShKzbnwoQpCi8XsMzvromTvEE38obrxciezk2oXcxc5UnKFrnq9OT1sgWemSK7LC6xB83Pst8XslbnNYYcE9Lgoqjag+hDfDYN1pFzjwUozRMKUU8wgAgQMsp2kJ9XqPo4VMOz/crcj0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mA3aht0P; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mA3aht0P" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2c6d4851142so24973445ad.1 for ; Sat, 20 Jun 2026 15:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781996193; x=1782600993; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Rs7b6kK6vyQ8Tj7IknUcX7lymT61ql9jRNgRQ30+eHE=; b=mA3aht0PF6XT+TT30fkIqDC3MXDIr77/CsRQUHCguQA6XPsOLKo7d/x7LT/hYWMbq0 I+Plie/pITKHbCKGAhy0E3CpKx9cHDrnRgxV0PgAp7fjkPJ7nBQ74G8VULwFT3pJTfFG 5IXHc+LQrdz133XJ25Ad1mfk5NCwOkNecbPmu9NHGPk2LvOrEthYE/ZpcJb/t3N6vjLK euQ20Fu1p0XItqZuoT+rjAWMFaGpvt4moQqOpRqXBQvA1MZeyy8NeWA9WHgJozLFbOTH CpzyKjXgM2D8pUMGDVZYUTLyHevBESSgtOQ8HGIFvuN8UnOJ5Fni+x6Ir0SZNgKFaKcN YFnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781996193; x=1782600993; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rs7b6kK6vyQ8Tj7IknUcX7lymT61ql9jRNgRQ30+eHE=; b=ewG57BrDjUoA/8j3AwJHEN9XkvzwDcsVlTRo2x0JfFewb/++E+ZWeAw3K1nQExzC1k AVfZCXOfa7im3Ena3yDVJfd1KU2NuHv4Of1PZ/hmq1jEzqvgQ1xFX84b5lC/yYiKs/Xd pE2QX0wCNvXbz6+VeHlF3n8MzUYH/UltRu/Drw6iIfXpUqbVrlaLoMyPBkxrxd0V8162 HGzPvoK5QXSHnidLZh/lOXzrWdulAlUYhbcIhCnWAgygMopjH+Lyx/DqQD9nFuPHZZq1 jG+lXY0inzS1Jst/lushJDRcl1D/B9wck3kSip7aaUQtUwsctm5pTlKnktma4BDo1LZd 8SIg== X-Forwarded-Encrypted: i=1; AHgh+RohyQ/1J6QMknjXoLuHgFbbl32d8bQqV4kSy39QBdsaPExGttddJuujP+DabX/TAo71RjukPXIrsGbELas=@vger.kernel.org X-Gm-Message-State: AOJu0YzIiznB9jRF2gumuQeJ/Rq2IsPJpv68ZTRc/1W4uz1/7FtbY07N zG/N/WuAw7KWhHw7VXbwZGG1Foued5gSq+O+a8OsCxa/ANK3p5/Ws+Z0 X-Gm-Gg: AfdE7cmwzR5MFcvXKxRFOywk1VNwUImgnSHEW82dmAfojPStpV4Tp4HBymmAvpazzg9 2KJtAJa8RFGzEmX5miLZeEqdIkx/Wnd5L7IenIjdWVRvuzmZoMS6+67i56ULZ1U9n49nH/2VB/Q txMV0hctrHQo7Cxn+sCrbmWYMEoZTAHP9Oa+6qFK5HJjYwvYDcHVXkQG6puvlag9WArjG9wDncd doSZe/dM9QeeglJi7UtmZbwEH5C25b2divtkHLvde7Jup3UQeW52Nw8fTY/PWowSDvTrWxfmx5r 277ybtFQOKSIey4lDIMj0e9EXEPZoy6FRy/hYnOaDR4ZWU/07URKHi6MXa6XkBK1VUEOhB6UVDa grNppA1Erj7zEYfIp5wIy5xtUelG+FeDpiqZlQADA0+shNYwVnYeOjeKD8hvEvOHO75X9ttydXN 3MCPoGqpEYSNrfjeDWwaaif5p1jytAj1nRTrJzu0MJ4K1/kDLMhyUzaEs4+UTV1f7jgc2Ef7sjE KZ6D0s= X-Received: by 2002:a17:903:2ac3:b0:2c6:b429:f100 with SMTP id d9443c01a7336-2c7195c4e8bmr76603445ad.15.1781996193368; Sat, 20 Jun 2026 15:56:33 -0700 (PDT) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:383f:6622:5068:7fd9:7931]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c743bfd9ddsm34254705ad.55.2026.06.20.15.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2026 15:56:32 -0700 (PDT) From: Deepanshu Kartikey To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+3ae80219c633aca5431c@syzkaller.appspotmail.com Subject: [PATCH] mtd: mtdpart: validate partition bounds in mtd_add_partition() Date: Sun, 21 Jun 2026 04:26:25 +0530 Message-ID: <20260620225625.45243-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mtd_add_partition() checks that 'length' is positive but does not validate that 'offset + length' fits within the parent partition's size. A userspace caller using the BLKPG_ADD_PARTITION ioctl can supply a crafted large 'length' value that passes the length <= 0 check, causing add_mtd_device() to fire a WARN_ON() when it detects the oversized partition. Fix this by adding explicit bounds checks before allocate_partition() is called: - Reject negative or out-of-range offsets. - Use u64 arithmetic to safely check offset + length <= parent_size, avoiding potential signed integer overflow. Reported-by: syzbot+3ae80219c633aca5431c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3ae80219c633aca5431c Signed-off-by: Deepanshu Kartikey --- drivers/mtd/mtdpart.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index 795a94e6b482..1a0e2207e440 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -264,6 +264,11 @@ int mtd_add_partition(struct mtd_info *parent, const char *name, if (length <= 0) return -EINVAL; + if (offset < 0 || offset >= (long long)parent_size) + return -EINVAL; + + if ((u64)offset + (u64)length > parent_size) + return -EINVAL; memset(&part, 0, sizeof(part)); part.name = name; part.size = length; -- 2.43.0