Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2EFA369D63 for ; Mon, 22 Jun 2026 12:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782129605; cv=none; b=b/jNiRvT858v/nOcDT1CvAmSxfot6h+Wyi+8SVITOFEBQJ5uRIC8OXgqpJXV+eboihpcs0XepMYsmf6Jy9jcRnR3FhNcx8gEvkhnRhKN2tDBzOtJG10k12eT77DYzsY/KetSTG6LVmU40NjxAvYsDuRN8+6fmQjopfUnvCEMGaA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782129605; c=relaxed/simple; bh=XYOgQSBtHhHgKdbpIUnBnYkjExfYhnIMdfVzWmpyTN4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=RF2bvGRnamyHHwQ5VUBrZ+frlpcQM91JSlkuXLcS4rG9LSRYBOUMDUaJwzTs/LxsjziI2/Ahl5kzOKyo9T2967Qp5fTMGKlsZt557D4z3rJCmAdL2JoMO5Yz5TYQlawX6QDmGW9my5PDkXTetotNIT76xFuaVTzNOYAs61gZH3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ofY/xp31; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ofY/xp31" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-84536ecfc5bso3806033b3a.2 for ; Mon, 22 Jun 2026 05:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782129603; x=1782734403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fVmAyZzkdsq5QbHaMlKMWqoAgtxaBkzODKT7bqBQ0WI=; b=ofY/xp31fTGSvcFOKXV0dsXQ8XHubZuUceq02W7jBZ2wBVgOa8VjOOJHkSyyqQnQWI GVZK2G/Rbzo5bUGpqVcTVbZWvq5bT6tJk4lxln3QR0c/8PH/nslhWBbj1L4jsrtxKm/w CrW2SP5si+I4qXp+Z+ccVUdvroDCyyK0nXdetZH/iEun8LXKN7a6pxTZ3mFV4vwP4Ts3 2vaUuQ/kFD6PjNRQI+Y05v8EM+7mlcFpvhB37tWBU4V9fA0NpKUFtSLgB2c22qDEG/3m XEhf4JAAD9TufzADjmUSajMVChu3HcqhMnThFo6hCRn1VIkAL9laI5oEnVVbGbG0XCJP tqcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782129603; x=1782734403; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fVmAyZzkdsq5QbHaMlKMWqoAgtxaBkzODKT7bqBQ0WI=; b=OQ7lvZVERnJyyuIfTy8G40eNL8hw3+aZwg5aS09goIfC85jSTgmqSoW7JOkviK5x8s h6SyFATHN9gV1TYMyQj7xc+mYkaK3bYGpfn9tP6ZpWuaBCtngK2+88q9lHlmOnq9huUv ngzqjZIGHg23zdvkF+nHxrnx/qXJN1yVERAlNjpnxf8um7VQHnhEANOsN/UQvXjCm7rK X6I7LBmipUL1lVpuOP97sU4fLut56kgpq1DWJxjK+P/6QiCzuBW/Oi866DkhL8G+6CWX eK8bp7ExfPBG/zCL2lXXoZ44GikFhZFvG+SGjeV+Su7GpOf77Tt3rg52N4XLjEPIfXxV WjGg== X-Gm-Message-State: AOJu0YwwpyfYfF0ClEfEtCNlEdNhe5m6hsANSAF1PMZzvKyvsOv7ANjB Z+H+ogoOU8SvEuKmP+y04qL8yKx3Zs2xE4JREro2EeT8WM5KphLODRNK15UruA== X-Gm-Gg: AfdE7cn9GFgmWeBMuNY07tnay1huLHVuis/TXwl8i10QDGeKJJy/khv9YEVGctTTR54 8RXPc39xL04JXbCUZj0uVSCzGKxOj7cy3aIBBjOfU7rESwsVVjcR4VTytq9OxKkkKoaR/k+qjp4 ssV6CfSFsVJuDs/quCl+6Fw90HRBNQVSQJV/KIu6/OryIdG+5cNMaiPf7HwTk11aVYYslK8N4vm tufB4NieEkvRhbNB5CVFiiQ7malQE0FLPnQlr/AgGpIHQVEpJhecoN+htWGnNQljSFcEPOgdvzG 1W74FBCrToIzbcBLB25hUkl0sx3pDtYTlpHOGWkMEzbpdss8A+C0zUMyhXWg1Bmh93rD9C38pgQ Q9MFDekNX9XgywGVr+h8QyKJHrQ8ZMcmsW+aY6JHshQNdGhPqmz9gcwVH5n6V7qRJLLoJeet9md LRfgH/lN6tWNiLBBGdhtQ6uomZlX3ReyM+dc54LuuuaDETakkv X-Received: by 2002:a05:6a00:a80a:b0:842:54e8:bdd with SMTP id d2e1a72fcca58-845508b19ddmr16520534b3a.40.1782129603038; Mon, 22 Jun 2026 05:00:03 -0700 (PDT) Received: from localhost ([2401:4900:884c:96a7:5e49:faae:f0ae:aa71]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564ea22c7sm7259654b3a.44.2026.06.22.05.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 05:00:02 -0700 (PDT) From: Senthilnathan To: linux-kernel@vger.kernel.org Cc: joe@perches.com, Senthilnathan Subject: [PATCH] From: Senthilnathan Subject: [PATCH] checkpatch: remove incorrect IIO_DEV_ATTR_ permission-arg rule Date: Mon, 22 Jun 2026 17:29:34 +0530 Message-Id: <20260622115934.1336588-1-ssenthil1490@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit checkpatch's @mode_permission_funcs table assumes that for any macro matching IIO_DEV_ATTR_[A-Z_]+, the permission/mode value is always argument 1. This is incorrect: the IIO_DEV_ATTR_* macro family, defined in drivers/staging/iio/frequency/dds.h, does not share a consistent argument layout. For example: IIO_DEV_ATTR_FREQ(_channel, _num, _mode, _show, _store, _addr) IIO_DEV_ATTR_FREQSYMBOL(_channel, _mode, _show, _store, _addr) IIO_DEV_ATTR_OUTY_ENABLE(_channel, _output, _mode, _show, _store, _addr) In IIO_DEV_ATTR_FREQ the mode is argument 3, while in IIO_DEV_ATTR_FREQSYMBOL it is argument 2 -- there is no single argument index that is correct for the whole family. As a result, checkpatch.pl --file reports spurious NON_OCTAL_PERMISSIONS errors against drivers/staging/iio/frequency/ad9834.c and ad9832.c, flagging the _channel or _num argument (typically "0" or "1") as if it were a malformed permission value, even though the actual mode arguments (0200) are correctly formatted 4-digit octal values: $ ./scripts/checkpatch.pl --no-tree --file \ drivers/staging/iio/frequency/ad9834.c ERROR: Use 4 digit octal (0777) not decimal permissions #315: FILE: drivers/staging/iio/frequency/ad9834.c:315: +static IIO_DEV_ATTR_FREQ(0, 0, 0200, NULL, ad9834_write, AD9834_REG_FREQ0); [... 8 more identical false positives ...] Since no single fixed argument position is correct for every member of this macro family, remove the rule rather than leave it pointing at the wrong argument. The other entries in @mode_permission_funcs are unaffected, and a genuine decimal-permission misuse (e.g. DEVICE_ATTR(foo, 644, ...)) is still correctly flagged after this change. Signed-off-by: Senthilnathan --- scripts/checkpatch.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2b7a42b..0c6f8b9 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -854,7 +854,6 @@ our @mode_permission_funcs = ( ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2], ["proc_create(?:_data|)", 2], ["(?:CLASS|DEVICE|SENSOR|SENSOR_DEVICE|IIO_DEVICE)_ATTR", 2], - ["IIO_DEV_ATTR_[A-Z_]+", 1], ["SENSOR_(?:DEVICE_|)ATTR_2", 2], ["SENSOR_TEMPLATE(?:_2|)", 3], ["__ATTR", 2], -- 2.43.0 --- scripts/checkpatch.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2b7a42bbdd94..0c6f8b92f168 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -854,7 +854,6 @@ our @mode_permission_funcs = ( ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2], ["proc_create(?:_data|)", 2], ["(?:CLASS|DEVICE|SENSOR|SENSOR_DEVICE|IIO_DEVICE)_ATTR", 2], - ["IIO_DEV_ATTR_[A-Z_]+", 1], ["SENSOR_(?:DEVICE_|)ATTR_2", 2], ["SENSOR_TEMPLATE(?:_2|)", 3], ["__ATTR", 2], -- 2.34.1