Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99049CDB47C for ; Tue, 23 Jun 2026 11:03:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbytv-0006jn-Je; Tue, 23 Jun 2026 07:02:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbytg-0006eN-7r for qemu-arm@nongnu.org; Tue, 23 Jun 2026 07:02:30 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbyte-00067H-GX for qemu-arm@nongnu.org; Tue, 23 Jun 2026 07:02:27 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NAsk2j4152326 for ; Tue, 23 Jun 2026 11:02:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e7ujTj25beCliYcHaN6vgRmeikjh8fOvjTThSDgD3Oo=; b=T6XdZVd3Cle+j51j fEehUceP4dVQ+gWSB/2E5H9I5r0VOWG7Qs1Faa5SZP5Ski0vcY7UekiIbtyjyMPZ 6xYixoI999MRwv2Opldx2AaYtAlwQhNjC3s4clQvwFsAtJdd05pDG1mVlg+kmOD3 9MZL8eqTd5ecc1iVoiChSARgPLsMb3VqBRo/nPQWmQbZ294BOxzEBNUO6FjP7jak yuAn1CwZWRe6AG6bZbiB1cPBpTdNs7KmqCMVhRCIat2oaGeu7IxsfvR9bIDidpP6 L+1R+tqRJ8XGgVvzkkWtIIcVpCfzuDuNuL9iUAazxRdZARbHsrTiH+0jFBKqbhC0 fYCVjg== Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey5n44ean-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:02:25 +0000 (GMT) Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-48e2ce64834so1787711b6e.3 for ; Tue, 23 Jun 2026 04:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782212545; x=1782817345; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e7ujTj25beCliYcHaN6vgRmeikjh8fOvjTThSDgD3Oo=; b=iNpM4Inbloqv9wXA/OA1cFY9eDNeI+UJ9LfxUFSxdV80Umxck1iAjCkYzqp/qTmn/+ kNUYRMpFgmZeH+l3nwE3oMQmcOyvK9EoHO4MfeKvpfqsQ6oafbNIYBelIpynEnMYgF6o zp+X6oECt3Y/otIw6G+AW9EryqVqfqwl+j1blM3zMYWeK2yYati8ngLryNepDrj+Xq4x upp8+cHat1xsVTpcrzMW9CsC/yyJah7gS1MLdnCyrrtcUyznjC2Yn2nLv5wf39avpA1w nvk0h8nn6RuhvzcIRdpKWEfBDG2+BpUpgy2Kd5fntXdzRuWRCseZB1/uvxc6pjz1z6qn QgJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782212545; x=1782817345; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e7ujTj25beCliYcHaN6vgRmeikjh8fOvjTThSDgD3Oo=; b=qUeS5M0sAnh+Y+t/iyaVF5kbS6e0ueHgnRJthhAD1HktvYkXDVwdYsPl5q064vcHkR RMnCb8XLVawhebDy/U8WCwafjhdToe9cSFg0cI0W4aESwIdLNnMrpfFrj07vy0mgUUf5 E7iX2eZwZBwQVPP7WhPnSdHiW1RCn8rWwbOz+14ejcREqVv1YsKj7IB8jpLT0pgHSzEV 8XeQ9eorZ6xOnrmCb4kUub0J+KDee0wNpojxAFGDiJfKTBTGQFhbkHFJ0HtPDJDKT3+3 uzYQvgq+Xq3vUDI9ALFmKBT7QLM2cRRgK88gwq00Shmfq0bfuype+IzdGxeoKKKQxg2S Fo3w== X-Gm-Message-State: AOJu0YwPheVt881AYiI/F771HDwbx+fHIwxw09TGU5jTQukpYjRGsxBD PSEsFAFs1+o0dBYQrJncMASLPLuKU4gGLWYd0uF4ynvD79qkh5PT7TzV8CoMsb2l0mzbZ0LHJDM Z1jDXWJCLgenY0G4cUs1P/AssPvkjO5N/DG9kDUc8C1V7q359KX7uwrI= X-Gm-Gg: AfdE7ckMAKVs+nD72+vcLupliowcWWp/qWAC9kDQou6ghhcbfzuCwAf5oUNF2PXK5bQ Wy1ewnhVosf03AWZtR9FPGaYyZqoIvK0ya1tnncf7EcMSXtbY3PyYMWVSwumwxCgUrf309XEC3K P+vbFT6Kia+l8UZlAw/GRPcK0TVmCjdslHDprdUBTnYvRnOo3tLm5MxO+DSxiYzss9Wm67QAFF9 t1gQWPeF4pAZgl0wIhVsqxs9NKLkqNM2T+V9XeZfTofJ5x7pccle8VX7LbTmgo/rabk8vKvusse ijxOaXwYSXGR1IvzQilPmX4NZoVsehVkwlOrVcmLaqO7KG6us0gl3ucHwSiicSV58aNh1o6RUfa vBWVq2aE+VOE2z39bfFM7p+6uZfOdzklzm1IIdHLuDBj+hgw7AhO2hYDUXpS4RJJw6+ZI X-Received: by 2002:a05:6808:4f25:b0:489:6c24:9d26 with SMTP id 5614622812f47-48f6210a3b3mr1058408b6e.27.1782212543998; Tue, 23 Jun 2026 04:02:23 -0700 (PDT) X-Received: by 2002:a05:6808:4f25:b0:489:6c24:9d26 with SMTP id 5614622812f47-48f6210a3b3mr1058344b6e.27.1782212543522; Tue, 23 Jun 2026 04:02:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd1f886sm344100705e9.4.2026.06.23.04.02.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 04:02:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Song Gao , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo Subject: [RFC PATCH v2 1/4] target/tcg: Rename bitswap() helpers Date: Tue, 23 Jun 2026 13:02:05 +0200 Message-ID: <20260623110209.26861-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623110209.26861-1-philmd@oss.qualcomm.com> References: <20260623110209.26861-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfX9HEMpOWCeb1k bf2d53wv+sChhYrezpPowN+Z7irubD9AzqLxMh7B7h9DVVhLVX+gybEU5m+kMgsIQRkzECxjMnQ 7gKTF+BeKw8zzvUOUqFbaPEDc5xSLIA= X-Authority-Analysis: v=2.4 cv=R8Uz39RX c=1 sm=1 tr=0 ts=6a3a67c1 cx=c_pps a=4ztaESFFfuz8Af0l9swBwA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=Vq8-Eo_8D2-Y-oFXv_MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TPnrazJqx2CeVZ-ItzZ-:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: GgvjExUrbFUlpl3kb4unnsyrttIF-faz X-Proofpoint-GUID: GgvjExUrbFUlpl3kb4unnsyrttIF-faz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfX20M7EZiKZfQC QH7nSs0OF6ExUAQmktPp96kpd+WrzovU/1OLGx21DTEwBDeFAiK2sKghDg02qThJW6LDK75rjP1 wiu8Io4udKzKBFS56o0ER0VhPR7lLAshpZPLxjOasu9rvXkfk3ojw2k2wbIk7tou2AuXJ6LlCB4 KCIWiGO56eKeVZt0hAS6vi5FIBHIHNo4HXTp6NTnMJQC2a1OHQ+qGkC3UNpGwHXh79sS5JqCOYa 0ARLVyk6znouygGphaiTAQpyTP1+7cNzL6GTjvH8lbWjDVyIzlAXWDMzvw4Nwb3lR0IC30xq+SI NpzE5Z/cmUQKddKax0es2CMtKeiBvGBZstdYara4AVhEVE7bz1cCHjp3oYoB139sbd9THI4qUMo SAl44Esw4eoF3/dm1O2D8t9v5F78O6Cm3Pculc/r432ye/Qg38CVdqg2MKyN+2UtCytZejFNtCs 0U4oAcW1xlJgFx8Bd4g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230089 Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org From: Philippe Mathieu-Daudé In order to avoid symbol name clash when building a single binary, rename TCG helpers prefixing with the target name. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Brian Cain Reviewed-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daudé --- target/loongarch/tcg/helper.h | 2 +- target/mips/helper.h | 2 +- target/loongarch/tcg/op_helper.c | 2 +- target/mips/tcg/op_helper.c | 2 +- target/mips/tcg/translate.c | 2 +- target/loongarch/tcg/insn_trans/trans_bit.c.inc | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target/loongarch/tcg/helper.h b/target/loongarch/tcg/helper.h index 8a6c62f1161..e36dd2f5de3 100644 --- a/target/loongarch/tcg/helper.h +++ b/target/loongarch/tcg/helper.h @@ -7,7 +7,7 @@ DEF_HELPER_2(raise_exception, noreturn, env, i32) DEF_HELPER_FLAGS_1(bitrev_w, TCG_CALL_NO_RWG_SE, tl, tl) DEF_HELPER_FLAGS_1(bitrev_d, TCG_CALL_NO_RWG_SE, tl, tl) -DEF_HELPER_FLAGS_1(bitswap, TCG_CALL_NO_RWG_SE, tl, tl) +DEF_HELPER_FLAGS_1(loongarch_bitswap, TCG_CALL_NO_RWG_SE, tl, tl) DEF_HELPER_FLAGS_3(asrtle_d, TCG_CALL_NO_WG, void, env, tl, tl) DEF_HELPER_FLAGS_3(asrtgt_d, TCG_CALL_NO_WG, void, env, tl, tl) diff --git a/target/mips/helper.h b/target/mips/helper.h index e2b83a1d19d..f3d459982cf 100644 --- a/target/mips/helper.h +++ b/target/mips/helper.h @@ -16,7 +16,7 @@ DEF_HELPER_3(lld, tl, env, tl, i32) #endif #endif -DEF_HELPER_FLAGS_1(bitswap, TCG_CALL_NO_RWG_SE, tl, tl) +DEF_HELPER_FLAGS_1(mips_bitswap, TCG_CALL_NO_RWG_SE, tl, tl) #ifdef TARGET_MIPS64 DEF_HELPER_FLAGS_1(dbitswap, TCG_CALL_NO_RWG_SE, tl, tl) #endif diff --git a/target/loongarch/tcg/op_helper.c b/target/loongarch/tcg/op_helper.c index e63ac66daae..35f331ca52c 100644 --- a/target/loongarch/tcg/op_helper.c +++ b/target/loongarch/tcg/op_helper.c @@ -32,7 +32,7 @@ target_ulong helper_bitrev_d(target_ulong rj) return revbit64(rj); } -target_ulong helper_bitswap(target_ulong v) +target_ulong helper_loongarch_bitswap(target_ulong v) { v = ((v >> 1) & (target_ulong)0x5555555555555555ULL) | ((v & (target_ulong)0x5555555555555555ULL) << 1); diff --git a/target/mips/tcg/op_helper.c b/target/mips/tcg/op_helper.c index 4502ae2b5be..83c340e38e0 100644 --- a/target/mips/tcg/op_helper.c +++ b/target/mips/tcg/op_helper.c @@ -45,7 +45,7 @@ target_ulong helper_dbitswap(target_ulong rt) } #endif -target_ulong helper_bitswap(target_ulong rt) +target_ulong helper_mips_bitswap(target_ulong rt) { return (int32_t)bitswap(rt); } diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 123d2c89c3d..811492364a3 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -4842,7 +4842,7 @@ static void gen_bitswap(DisasContext *ctx, int opc, int rd, int rt) gen_load_gpr(t0, rt); switch (opc) { case OPC_BITSWAP: - gen_helper_bitswap(cpu_gpr[rd], t0); + gen_helper_mips_bitswap(cpu_gpr[rd], t0); break; #if defined(TARGET_MIPS64) case OPC_DBITSWAP: diff --git a/target/loongarch/tcg/insn_trans/trans_bit.c.inc b/target/loongarch/tcg/insn_trans/trans_bit.c.inc index ee5fa003ce0..76d6ba742d5 100644 --- a/target/loongarch/tcg/insn_trans/trans_bit.c.inc +++ b/target/loongarch/tcg/insn_trans/trans_bit.c.inc @@ -194,8 +194,8 @@ TRANS(revb_2w, 64, gen_rr, EXT_NONE, EXT_NONE, gen_revb_2w) TRANS(revb_d, 64, gen_rr, EXT_NONE, EXT_NONE, tcg_gen_bswap64_i64) TRANS(revh_2w, 64, gen_rr, EXT_NONE, EXT_NONE, gen_revh_2w) TRANS(revh_d, 64, gen_rr, EXT_NONE, EXT_NONE, gen_revh_d) -TRANS(bitrev_4b, ALL, gen_rr, EXT_ZERO, EXT_SIGN, gen_helper_bitswap) -TRANS(bitrev_8b, 64, gen_rr, EXT_NONE, EXT_NONE, gen_helper_bitswap) +TRANS(bitrev_4b, ALL, gen_rr, EXT_ZERO, EXT_SIGN, gen_helper_loongarch_bitswap) +TRANS(bitrev_8b, 64, gen_rr, EXT_NONE, EXT_NONE, gen_helper_loongarch_bitswap) TRANS(bitrev_w, ALL, gen_rr, EXT_NONE, EXT_SIGN, gen_helper_bitrev_w) TRANS(bitrev_d, 64, gen_rr, EXT_NONE, EXT_NONE, gen_helper_bitrev_d) TRANS(maskeqz, ALL, gen_rrr, EXT_NONE, EXT_NONE, EXT_NONE, gen_maskeqz) -- 2.53.0