Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6991CDB470 for ; Tue, 23 Jun 2026 20:21:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68E5E10EC96; Tue, 23 Jun 2026 20:21:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="hJjaceQf"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAA8F10EC96 for ; Tue, 23 Jun 2026 20:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782246067; x=1813782067; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n3Htdh3STriAkeHY7JIhiAfqBpMIJxOMiNiJ88GlhU4=; b=hJjaceQfS4naZvABUcuY1D2aj5hzxUVJhOcymdIu8uW/rL1YDfRw89ji Ryj6wsvmyEgIm2Dq6f5jsxjzCNEqQTVcxfs5hUv4lHSe2ASJVG8O2P2g5 7ou4EvTf+XlvNgGAZ2qroCdxKdLQRvEiy+qYXTPzKA1Rs/ud+DXosffkA zD5UHmxuEaTJrcishsDba6Yap1cVo2K4JtF6pBmVP40evnriYi7ENe7HD eyqWZovKBZttlct1YMZ3cg5ZDkOKsGXjdu3ZiswDqUE9z/dXn0Ta54/k8 ZsVjB+ZQKfItjr41DRpPH4XD1031J8aSukoFLlR7jGDwcdlXTIa5MtdDj Q==; X-CSE-ConnectionGUID: qVvuSiqvRf+zUJonFUexEw== X-CSE-MsgGUID: tgoE5ZdoSsulL1osuE2UKw== X-IronPort-AV: E=McAfee;i="6800,10657,11826"; a="83001335" X-IronPort-AV: E=Sophos;i="6.24,221,1774335600"; d="scan'208";a="83001335" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 13:21:06 -0700 X-CSE-ConnectionGUID: 95QWp+nHSUeOok5tjk0BbQ== X-CSE-MsgGUID: NOehoXM2RYWcRQTUX//ZKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,221,1774335600"; d="scan'208";a="273308636" Received: from osgc-sh-dragon.sh.intel.com ([10.239.81.44]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 13:21:04 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, michal.wajdeczko@intel.com, raag.jadav@intel.com, andi.shyti@linux.intel.com, jani.nikula@intel.com Subject: [PATCH v5 4/4] drm/xe/i2c: Report i2c irq handler issue Date: Wed, 24 Jun 2026 04:20:53 +0800 Message-ID: <20260623202053.1023598-5-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623202053.1023598-1-jonathan.cavitt@intel.com> References: <20260623202053.1023598-1-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Error logging is expected but not included in xe_i2c_irq_handler() for generic_handle_irq_safe(), so add error logging there. This issue was caught by static analysis. v2: - Reword error message (Wajdeczko) Signed-off-by: Jonathan Cavitt Reviewed-by: Raag Jadav Cc: Raag Jadav Cc: Michal Wajdeczko --- drivers/gpu/drm/xe/xe_i2c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c index 148e82e01ae8..84171021e6ea 100644 --- a/drivers/gpu/drm/xe/xe_i2c.c +++ b/drivers/gpu/drm/xe/xe_i2c.c @@ -177,12 +177,15 @@ static bool xe_i2c_irq_present(struct xe_device *xe) void xe_i2c_irq_handler(struct xe_device *xe, u32 master_ctl) { struct xe_mmio *mmio = xe_root_tile_mmio(xe); + int ret; if (!(master_ctl & I2C_IRQ) || !xe_i2c_irq_present(xe)) return; /* Forward interrupt to I2C adapter */ - generic_handle_irq_safe(xe->i2c->adapter_irq); + ret = generic_handle_irq_safe(xe->i2c->adapter_irq); + if (ret) + xe_err_ratelimited(xe, "I2C: irq handling failure (%pe)\n", ERR_PTR(ret)); /* Deassert after I2C adapter clears the interrupt */ xe_mmio_rmw32(mmio, I2C_CONFIG_CMD, 0, PCI_COMMAND_INTX_DISABLE); -- 2.53.0