Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6218ECDB479 for ; Thu, 25 Jun 2026 12:22:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF68810E12C; Thu, 25 Jun 2026 12:22:49 +0000 (UTC) X-Greylist: delayed 1200 seconds by postgrey-1.36 at gabe; Thu, 25 Jun 2026 12:22:48 UTC Received: from 7.mo550.mail-out.ovh.net (7.mo550.mail-out.ovh.net [87.98.158.110]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DA7710E12C for ; Thu, 25 Jun 2026 12:22:48 +0000 (UTC) Received: from director9.ghost.mail-out.ovh.net (unknown [10.110.54.23]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4gmH6M4RWzz60C2 for ; Thu, 25 Jun 2026 11:44:59 +0000 (UTC) Received: from ghost-submission-7d8d68f679-xfpdk (unknown [10.111.182.62]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id D12D680EFF; Thu, 25 Jun 2026 11:44:58 +0000 (UTC) Received: from etezian.org ([37.59.142.102]) by ghost-submission-7d8d68f679-xfpdk with ESMTPSA id vF+/G7oUPWp1RSYAtJDhiQ (envelope-from ); Thu, 25 Jun 2026 11:44:58 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-102R00415302d01-2a52-45cb-9a42-458e3b3c8a61, 20FD450D999EB22A6E066B2D596748FFE04DB42B) smtp.auth=andi@etezian.org X-OVh-ClientIp: 178.82.31.9 From: Andi Shyti To: dri-devel , intel-gfx Cc: Andi Shyti , Andi Shyti Subject: [PATCH] drm/i915/gt: Return bool values from a boolean helper Date: Thu, 25 Jun 2026 13:44:42 +0200 Message-ID: <20260625114442.2912230-1-andi.shyti@linux.intel.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 1493787704206267421 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: dmFkZTGVaW+6PV9gVfPh92WHYd0KDcfoF5+9nwYDvlaBN3PWZTxNIEUaF2megbst3Y0VmJnlJPFzJmph4fZPnGmTcEfy2DhY9WJK3sgOl62ZKMQEgeCv9CVyjgDjYNSGPW6n5Ug02OFt7eKdfg7L02GfTe0xKZHHQ9quidsSyAKeQm94KnTwaZzQJc0E1V9KJEUD0TIfxX97Fri5cUlWpkAeGf/Zs14NTJBv3m5XH/F4cjF2BF2vCYkZS51o7S6Pu8LpFFoay2d7QoQeHCy4n3nav4Cf7UWwMZHr/8HfUew4b24jU/fgi/lvx457SLslKva5KMKH3o9YUSM4+HCWvwQeEUbXNQOjOfgzDaTlBwDZDF+Ag06oiH9y59iDbXMkvZQT0D5F7DPH/uALK/VO/LUiTKerpZnEw4vnkyoT+NUbDit/TPj8WgkgFTHrPrUlA4m3f+rBP6RbhO+CrA4ioUwibGYbmSvQVTHXmBpWr4rPNnrpgAJu/a5h2qV0RPh026L5dU9LPMy44wBrCif4Ie1Ge7TUDiUmvjY4G6etQ48pVPgRyf36s0QI5R4jDoP59Zl4qG8IxQgx3cAwY3IaRVeOiM5RIUBBFLPnrHD6wenKL1uSAtXr2uguDvsd8t/mn/4j77mFlGUdzWSlY0P4idomTpBxpi1JyySu3k8hkeJZ/JRVYQ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_has_gpu_reset() returns logically correct values by returning a function pointer when GPU reset is supported and NULL otherwise. However, as a boolean helper, it is more appropriate to return explicit true or false values. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_reset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index b2cf672564dd..a3f198646e1d 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.c +++ b/drivers/gpu/drm/i915/gt/intel_reset.c @@ -797,9 +797,9 @@ static int __intel_gt_reset(struct intel_gt *gt, intel_engine_mask_t engine_mask bool intel_has_gpu_reset(const struct intel_gt *gt) { if (!gt->i915->params.reset) - return NULL; + return false; - return intel_get_gpu_reset(gt); + return !!intel_get_gpu_reset(gt); } bool intel_has_reset_engine(const struct intel_gt *gt) -- 2.53.0