Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74090C43458 for ; Wed, 1 Jul 2026 13:04:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1weubR-00042Z-1F; Wed, 01 Jul 2026 09:03:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weubP-00042N-DY for qemu-devel@nongnu.org; Wed, 01 Jul 2026 09:03:43 -0400 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1weubN-0002xE-UV for qemu-devel@nongnu.org; Wed, 01 Jul 2026 09:03:43 -0400 Received: from DESKTOP-TUU1E5L.localdomain (unknown [167.220.208.73]) by linux.microsoft.com (Postfix) with ESMTPSA id 806E520B7166; Wed, 1 Jul 2026 06:03:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 806E520B7166 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1782911019; bh=t0b0kgAwBWjoBzCwbUZlk9sfo6c+G/d89YtQ3t1AOI4=; h=From:To:Cc:Subject:Date:From; b=O2jn8zpI8r0cbxWs5y0MiVSlFWO/bWVLg0wNEACeplmFM19ZUhIs4+LpAaSFO0dAx cs3JNiqJm3SLL+USRQWBGIN+4X6mSqMuO1srHwopjTkWUBWTUA4csCKOQ+1SUe361I CwHA6nZjJ1frTacvfdv5eT/e1e/Y7Y2tB5Y0SkXw= From: Magnus Kulke To: qemu-devel@nongnu.org Cc: Wei Liu , Peter Maydell , =?UTF-8?q?Doru=20Bl=C3=A2nzeanu?= , Magnus Kulke , Paolo Bonzini , =?UTF-8?q?Doru=20Bl=C3=A2nzeanu?= , Magnus Kulke , Wei Liu Subject: [PATCH] accel/mshv: Fix pointer to proc feature bitfield Date: Wed, 1 Jul 2026 15:03:35 +0200 Message-Id: <20260701130335.418156-1-magnuskulke@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=13.77.154.182; envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Processor features are stored in a union containing two "banks": union hv_partition_processor_features { uint64_t as_uint[2]; struct { uint64_t sse3_support:1; ... } } get_proc_features() to retrieve the 2nd bank was passing a pointer that steps over the whole union (+16B) instead of picking the 2nd bank _in_ the union. This manifests in mismatching feature bits for the 2nd bank and possibly other side-effects caused by writing beyond the union. We need to step over the first bank (+8B) by using as_uint64[0/1] to correct this behaviour. Fixes: 2f6da91e8a ("accel/mshv: store partition proc features") Signed-off-by: Magnus Kulke --- accel/mshv/mshv-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index 9452504ac2..c8b7f10294 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -167,7 +167,7 @@ static int get_proc_features(int vm_fd, ret = get_partition_property(vm_fd, HV_PARTITION_PROPERTY_PROCESSOR_FEATURES0, - features[0].as_uint64); + &features->as_uint64[0]); if (ret < 0) { error_report("Failed to get processor features bank 0"); return -1; @@ -175,7 +175,7 @@ static int get_proc_features(int vm_fd, ret = get_partition_property(vm_fd, HV_PARTITION_PROPERTY_PROCESSOR_FEATURES1, - features[1].as_uint64); + &features->as_uint64[1]); if (ret < 0) { error_report("Failed to get processor features bank 1"); return -1; -- 2.34.1