Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 986D2C44501 for ; Tue, 7 Jul 2026 15:42:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C11310EE0A; Tue, 7 Jul 2026 15:42:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="fv8vgTUZ"; dkim-atps=neutral Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010038.outbound.protection.outlook.com [52.101.201.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5ABAB10EE07 for ; Tue, 7 Jul 2026 15:42:23 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qdlRNZuUzLEUbeUngVpxVYXB1/fVrD37cJo83lbE4eps6BFVvZl/nTTB6qggpLO1yFcIJsBGfuY6wFUgLwBZUvD12v0xUOncJQhJGk1+LpFFv1SriRZQu8qi9jzxGDu082rzfZeirTNwJgQndUCop9GooZuID5puK22tfrHDUmRmucV/S6EFc5c4rEMXN5TmJJnerFBbHATX8cmfuqs0ATUoYU10v50RB5ddFCr+BqgyJK+m8WWDqqsoHuRmgQn/AzZEAnaI2DhUNPNlS9snH6dx1+EDUD7o52y1Z6lrovcev8aEUFaZKyWmMt5uq3vhDfTmKDZmnxgXpsMNMy+wdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TbkyVymp6b2X8i3f0LGk46yo8IMZw5rKFPYS6Pt4fMg=; b=AXl2Zej6ZnJIA6m/MT9pOt8FFSFxBNjSmty1tI4SSy1hi67/SkLLiAxvev6mo24sYhEL5kBjzNE/2ARdWphIZ6ppmfC/gAZq9h7R6x7AcHfJILC0PtaTknHpJXWnt+UuKzogwouMJGstsiLu1DH8wHC5uyWuFXfz41pnuWPgW5AKl6cUi+f4C7wu8YGgSrPE6IQ2tJaRzCFM189YgidekAcSK5R48olUi7EtoVqeNqfeYHHdMtrh+/MGkpQU8e6xbPYM7EsdUibDVHjOabWYK8W2TH+S73Dtp01HAdrBzoN9U+0UioeL0MlcKIteLQKaVg29JU/9I5F/zVHAOl8mJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TbkyVymp6b2X8i3f0LGk46yo8IMZw5rKFPYS6Pt4fMg=; b=fv8vgTUZ9jjun6e63/I/6zb/YoPbk+FKBPP55dtn6gvCRY09NvyB9B7KYLMYwtTToET4ysGzQiiiGSWsC59u5KMbQb2YVRWJQCbBL+yrNHzUoMw19493vCQCqS5UEyBwyMPtY2QqZU1Zy0AWMj5dFqt19SygTK0xFsjNUeZRuCs= Received: from BL1PR13CA0089.namprd13.prod.outlook.com (2603:10b6:208:2b8::34) by DS4PR12MB9707.namprd12.prod.outlook.com (2603:10b6:8:278::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Tue, 7 Jul 2026 15:42:19 +0000 Received: from BL02EPF0001A107.namprd05.prod.outlook.com (2603:10b6:208:2b8:cafe::a1) by BL1PR13CA0089.outlook.office365.com (2603:10b6:208:2b8::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.9 via Frontend Transport; Tue, 7 Jul 2026 15:42:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0001A107.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Tue, 7 Jul 2026 15:42:18 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Tue, 7 Jul 2026 10:42:17 -0500 Received: from p8.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Tue, 7 Jul 2026 10:42:17 -0500 From: Alex Deucher To: CC: Alex Deucher Subject: [PATCH 07/30] drm/amdgpu/ucode: WARN() rather than BUG() Date: Tue, 7 Jul 2026 11:41:40 -0400 Message-ID: <20260707154203.2603209-7-alexander.deucher@amd.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260707154203.2603209-1-alexander.deucher@amd.com> References: <20260707154203.2603209-1-alexander.deucher@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A107:EE_|DS4PR12MB9707:EE_ X-MS-Office365-Filtering-Correlation-Id: 988751ae-76bd-413e-8412-08dedc3e5414 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|82310400026|1800799024|36860700016|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 0qsChxFWy0ORLhmW/4spcMcKyAHJIsdUK3WjJglN6yBmEdXpds+tQfppka2YRJ57oc/G0HWaAvxZelnBD+z2dwvCIWcNDpXHPKyLsX3IMrgU/s1mvm91alJ1CUY5RrJpthL5UIYgmCzt7eb5vP7XN1DGBy7S8kUExln3hsMDiag8+UlASIj7Z6QbQH35o388kxW+3AJxhgxWRwtn3uL2NXecVLnTMM6zOhMfzRo5T9EkEsUvqzOp5Y47Aawq4H3q/Zqq+EeEFlksnII94jNWw5tpCt8HIh+ykJrKXJO9UyDzB5rqPYbOvk8nerNXvOe6+B+MUy/s6xHpdJTQnxVyyXmnUro24vJP0facYF5HpKWSmaLkNuMz77oTO8T203ARn8pSU49fgJfLfkcm7Gicjo6QlNbcAE0ml2Wv2HEuHPIHMf5svh7nr4MGFbYOzeTUfJc0mvfzDovpWM+CYcYgeITz/7wVng/gb3nOzCqwGHt9bf+0xTwntIWe2GL7NIFdwhDjG9S31w/OQ8eSgy95KKa+FpoaWJWKlvQb809gpLIWZGPIXcuH++sUvH9JEWPPGwxGKKDZayA60KSFs/QQiU0kyGRALTu4x6no/KqMkedMZ09elXRDrhznbDp7R4ZolC6tQ+O5hRFiNvyS63SwSeoSRcR9q9OxsnxVcSrk269Zsch/pSj92vs6ridDEmqrZp5GleSfOIbnCyQ9jnldAQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(23010399003)(82310400026)(1800799024)(36860700016)(56012099006)(11063799006)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3pos7lTIQAFinELmYQbqohCsnpYutz/LAlKIghcCTxIiNRD3IvKcYi2zjl/01kBhqTRwDOgIFyjrc5GbeAXy6cPXxorERGBXSt5SyxU5MTKSAkKQqIQTmYFGXBYVEp5S3o+GwlE9lKofW964rHzRSvLh5gcv6RRr518vIEvdtzyeEI/yRYY2gTt489y9AhYf9Ell7uPMhtJA5VNeHP83yrEq7wyXnwcvTS/X4MbZdaPoDQ0lHCPfOAxgBsv8TGg9YIxnRoKgpLjTcQb8jpVJ1QfQ0cLDL4XzMSlJUzWU9VlH46XGFWR1HNhhJW2ohcJew1OxbP5ezQmiWVYz/1B767QM89a80T4Bqoj0XnosXqE95Bobd+yCUQ0HsSqx25sbVNtDl9tcWpp06Ua0DA/82dmbSZSooAmIoBwEP/ayunSQE0PrLswlizOxjHqrS1UJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 15:42:18.9464 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 988751ae-76bd-413e-8412-08dedc3e5414 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A107.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR12MB9707 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" There's no need to crash the kernel for this case. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c index 6d9e96fabd581..4f1c711df5bd7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c @@ -1478,7 +1478,8 @@ void amdgpu_ucode_ip_version_decode(struct amdgpu_device *adev, int block_type, ip_name = "isp"; break; default: - BUG(); + WARN(1, "invalid HWIP %d\n", block_type); + return; } maj = IP_VERSION_MAJ(version); -- 2.55.0