Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27D73537FF for ; Mon, 13 Jul 2026 18:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783968253; cv=none; b=RRoibp9DRqeXa9jHfIgvSD4fh4Hq2Vt6nOJjsVCDFW1dvlvqOdxuVVWptRM/f4gC0S8QZVtuFrzQPSx6qCht+nuB2Ws12CldxdnzXfp5E0r/HR+ZBEmJQms5Rj8974Y/hEODeSuV0hHYOEudfO7QphHZkNniuAbdlV48V2Vz190= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783968253; c=relaxed/simple; bh=lLzB0eq5CNByclgtn9/5K4V0FpLS5sGQoaP/z+F1zSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ijUihSm9u8Yuc5ojIlHsMIgSRmcHHJsymrOhFArv3rusu03aeJmQpgsX5vk9ACk/zUyJwZSuU5nNHHixkcymt/WAriTVb2in6z/rvBMn7e79d4erv7tWTiyolVQXzySR61JkV080UDQnn2y+SpgfQ4GtEfoDxMUEsXJlvmi/SB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qlv8nplA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qlv8nplA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0DBD1F00A3A; Mon, 13 Jul 2026 18:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783968252; bh=kfNjCDYAjwKuir62IW0z5/IhyDJmQx9M2zH1rf9AYh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Qlv8nplAwxCddaShXwvGuh3bybfM40jr+wBlCoQ4YiyXcagI5F37qPi2eCzqcSMCJ gQ4hY3rnUCRN8o+WteMM8sv0OsG2XShVY/SCLk7yNWsVGaGbewrfjCpfIyBGjeKOC4 1ul2MEjPS7yXytcr9W/R2TyYLWBql9gO3dsmpJdznEnh9PLyhTPh6zAwyboNGrZ0u0 +tgWgltfmm3h882G0upOpQOPOm1+A2HD7sMn8R6R679w/qcdOzv4ptuLMIzh7wCrVV jXrYXCeZ0moY/a+oqJvrMcCKThFbpcuYHbGhJ/LQ4d1e3Evngji3xPQqMbEggiPFFS dqdePKLpnHlzw== From: Sasha Levin To: stable@vger.kernel.org Cc: Zhang Lixu , Andy Shevchenko , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 5.15.y 2/2] iio: hid-sensor-rotation: Fix stale or zero output when reading raw values Date: Mon, 13 Jul 2026 14:44:09 -0400 Message-ID: <20260713184409.1954470-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260713184409.1954470-1-sashal@kernel.org> References: <2026071307-campus-semester-8833@gregkh> <20260713184409.1954470-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhang Lixu [ Upstream commit 3ce8d099e0afc5a7da75a2007a67f67c4f5a4af1 ] When reading the raw quaternion attribute (in_rot_quaternion_raw), the driver currently returns either all zeros (if the sensor was never enabled) or stale data (if the sensor was previously enabled) because it reads from the internal buffer without explicitly requesting a new sample from the sensor. To fix this, power up the sensor, call sensor_hub_input_attr_read_values() to issue a synchronous GET_REPORT and receive the full quaternion data directly into a local buffer, then decode the four components. Fixes: fc18dddc0625 ("iio: hid-sensors: Added device rotation support") Signed-off-by: Zhang Lixu Reviewed-by: Andy Shevchenko Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/orientation/hid-sensor-rotation.c | 40 ++++++++++++++++++- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c index a033699910e8e0..f124062af383b2 100644 --- a/drivers/iio/orientation/hid-sensor-rotation.c +++ b/drivers/iio/orientation/hid-sensor-rotation.c @@ -69,6 +69,13 @@ static int dev_rot_read_raw(struct iio_dev *indio_dev, long mask) { struct dev_rot_state *rot_state = iio_priv(indio_dev); + struct hid_sensor_hub_device *hsdev = rot_state->common_attributes.hsdev; + struct hid_sensor_hub_attribute_info *info = &rot_state->quaternion; + u32 usage_id = HID_USAGE_SENSOR_ORIENT_QUATERNION; + union { + s16 val16[4]; + s32 val32[4]; + } raw_buf; int ret_type; int i; @@ -78,8 +85,37 @@ static int dev_rot_read_raw(struct iio_dev *indio_dev, switch (mask) { case IIO_CHAN_INFO_RAW: if (size >= 4) { - for (i = 0; i < 4; ++i) - vals[i] = rot_state->scan.sampled_vals[i]; + if (info->size <= 0 || info->size > sizeof(raw_buf)) + return -EINVAL; + + hid_sensor_power_state(&rot_state->common_attributes, true); + + ret_type = sensor_hub_input_attr_read_values(hsdev, + hsdev->usage, + usage_id, + info->report_id, + SENSOR_HUB_SYNC, + info->size, + (u8 *)&raw_buf); + + hid_sensor_power_state(&rot_state->common_attributes, false); + + if (ret_type < 0) + return ret_type; + + switch (info->size) { + case sizeof(raw_buf.val16): + for (i = 0; i < ARRAY_SIZE(raw_buf.val16); i++) + vals[i] = raw_buf.val16[i]; + break; + case sizeof(raw_buf.val32): + for (i = 0; i < ARRAY_SIZE(raw_buf.val32); i++) + vals[i] = raw_buf.val32[i]; + break; + default: + return -EINVAL; + } + ret_type = IIO_VAL_INT_MULTIPLE; *val_len = 4; } else -- 2.53.0