Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1BF9239567 for ; Tue, 14 Jul 2026 13:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784035150; cv=none; b=bZfuk64F/H9tmsmlGNRJTsO1s8LR5BRa1Az6rXpfLlzZ1+uKQ1EEUsoA92iA8toiJPqC4qbaVYq5md0scFicA13da+Jv1hA9eguSFKHt335YLGuxJnZDK5C0Elnmas1TOHb+Q/Sn8IcJpdvxy+p57AEt/2wRJ5fdlASq8RSHd4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784035150; c=relaxed/simple; bh=s6ASnVyrp9MHAsKTlUUWp6yLinbrM3b033f5pc+29D4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VbQKS0kL0sQdBNz3awUpIrfpitQffTIIGVpAl+B4YCiGxP69QJVI9JEtwPYEPL0Gi+RIi9/0eklK7OYMVeFwaAHVeOm2juQQttrDomVst6OcSMszphizEjWXi5CEl0xVWVCUDMnNN9nmqwmXRPvjl0FJkVmXKfLcMVs9lW8a2Ws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 5B8E268B05; Tue, 14 Jul 2026 15:19:05 +0200 (CEST) Date: Tue, 14 Jul 2026 15:19:05 +0200 From: Christoph Hellwig To: guzebing Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Guzebing Subject: Re: [PATCH v2] nvme: reduce firmware activation poll interval Message-ID: <20260714131905.GB31615@lst.de> References: <20260714092846.3381169-1-guzebing1612@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260714092846.3381169-1-guzebing1612@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Jul 14, 2026 at 05:28:46PM +0800, guzebing wrote: > nvme_try_sched_reset(ctrl); > return; > } > - msleep(100); > + usleep_range(1000, 2000); Add a comment that this matches nvme_wait_ready? Or even better add a helper with a name like nvme_busy_wait and add a comment describing the use case?