Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3339C44515 for ; Mon, 20 Jul 2026 09:14:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F93F10E844; Mon, 20 Jul 2026 09:14:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Ti6i0yGF"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0727010E844 for ; Mon, 20 Jul 2026 09:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784538857; x=1816074857; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1l53a6Ku+/K5osMwYOyqovepfCjKTenHPqzTfclXtEY=; b=Ti6i0yGF4cV9lnOGb7RyhqyefEx+WYnDbdyh3VSq6w4qoqrcFkLzCjAA l9E/nMqN8CaTsWOKXpjBiGhZ6cZYLtUozLkbDT8gJXKrIJ3G3cWmZwtHW /0iGFo01wENCd1q00hbZ3MStyUauqdu8rjepbAYL539QRdlKH/Kv7DtvY w2BJTfNJOv/32xR8/ysGg7YGYgH+NVJFtn3DdN8nVdNs2tvvn8pzn4Qhv AlAqL5lgrMKYGlvAjKnYs+8LOrRe5gGoPQrgbBTrYFLWcPNYkMS0Ody6+ Cm00FqB82B+PtHXn1k+jfmSnYF8H/3B7pyC5QE0rwVctaEG6rWzPQ5J3t Q==; X-CSE-ConnectionGUID: 1lYi2GYFRFK92bcluSXS1w== X-CSE-MsgGUID: dljx4I1oTxO/dW3LyElT5A== X-IronPort-AV: E=McAfee;i="6800,10657,11851"; a="84969644" X-IronPort-AV: E=Sophos;i="6.25,174,1779174000"; d="scan'208";a="84969644" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 02:14:16 -0700 X-CSE-ConnectionGUID: EsMwNRLVRvWj/O8TKy/ZtQ== X-CSE-MsgGUID: 5buXfZ4YRIexm5ANxPonqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,174,1779174000"; d="scan'208";a="256830721" Received: from anoopcvi-vm.gar.corp.intel.com ([10.109.80.88]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 02:14:14 -0700 From: "Anoop, Vijay" To: intel-xe@lists.freedesktop.org Cc: umesh.nerlige.ramappa@intel.com, badal.nilawar@intel.com, rodrigo.vivi@intel.com, aravind.iddamsetty@intel.com, riana.tauro@intel.com, anshuman.gupta@intel.com, matthew.d.roper@intel.com, michael.j.ruhl@intel.com, paul.e.luse@intel.com, mohamed.mansoor.v@intel.com, kam.nasim@intel.com, anoop.c.vijay@intel.com Subject: [PATCH v5] drm/xe/sysctrl: Add helper to query application status Date: Mon, 20 Jul 2026 02:14:11 -0700 Message-ID: <20260720091410.4153002-2-anoop.c.vijay@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" From: Anoop Vijay Add xe_sysctrl_check_app_status() to query the state of a System Controller application using get_app_status_by_id mailbox command. The helper maps xe_sysctrl_app_id values to firmware application IDs and returns the reported application state. Add a convenience wrapper to check OOBMSM application readiness. Signed-off-by: Anoop Vijay --- v5: (Anshuman) - Rename OOBMSM status helper to use xe_sysctrl_* prefix - Remove xe_is_diag_fw_ready() helper v4: (Anshuman) - Make xe_sysctrl_check_app_status() internal - Remove unused app identifier v3: (Riana, Badal) - Replace string-based app identifiers with enum xe_sysctrl_app_id - Use get_app_status_by_id (opcode 0x05) - Move mailbox definitions to xe_sysctrl_mailbox_types.h - Return enum xe_sysctrl_fw_status consistently - Map communication failures to COMM_FAILURE - Add INITIALIZED state and status helpers - Fix Diagnostics typo v2: (Badal) - Return SysCtrl firmware application states instead of errno for application lifecycle conditions --- drivers/gpu/drm/xe/xe_sysctrl.c | 70 +++++++++++++++++++ drivers/gpu/drm/xe/xe_sysctrl.h | 1 + drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h | 63 +++++++++++++++++ 3 files changed, 134 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_sysctrl.c b/drivers/gpu/drm/xe/xe_sysctrl.c index 1db20be8158b..9406df029322 100644 --- a/drivers/gpu/drm/xe/xe_sysctrl.c +++ b/drivers/gpu/drm/xe/xe_sysctrl.c @@ -13,9 +13,11 @@ #include "xe_device.h" #include "xe_mmio.h" #include "xe_pm.h" +#include "xe_printk.h" #include "xe_soc_remapper.h" #include "xe_sysctrl.h" #include "xe_sysctrl_mailbox.h" +#include "xe_sysctrl_mailbox_types.h" #include "xe_sysctrl_types.h" /** @@ -130,3 +132,71 @@ void xe_sysctrl_pm_resume(struct xe_device *xe) xe_sysctrl_mailbox_init(sc); } + +static enum xe_sysctrl_fw_status +xe_sysctrl_check_app_status(struct xe_device *xe, enum xe_sysctrl_app_id app_id) +{ + struct xe_sysctrl_get_app_status_by_id_req req = {}; + struct xe_sysctrl_get_app_status_by_id_resp resp = {}; + struct xe_sysctrl_mailbox_command cmd = {}; + size_t out_len = 0; + u32 flags; + int ret; + + if (!xe->info.has_sysctrl) + return XE_SYSCTRL_FIRMWARE_APP_NOTSUPP; + + req.app_id = (u8)app_id; + + cmd.header.data = + FIELD_PREP(APP_HDR_GROUP_ID_MASK, XE_SYSCTRL_GROUP_CORE) | + FIELD_PREP(APP_HDR_COMMAND_MASK, XE_SYSCTRL_CMD_GET_APP_STATUS_BY_ID) | + FIELD_PREP(APP_HDR_VERSION_MASK, 0); + + cmd.data_in = &req; + cmd.data_in_len = sizeof(req); + cmd.data_out = &resp; + cmd.data_out_len = sizeof(resp); + + ret = xe_sysctrl_send_command(&xe->sc, &cmd, &out_len); + if (ret) + return XE_SYSCTRL_FIRMWARE_COMM_FAILURE; + + if (out_len != sizeof(resp)) { + xe_err(xe, "sysctrl: unexpected get app status response length %zu (expected %zu)\n", + out_len, sizeof(resp)); + return XE_SYSCTRL_FIRMWARE_COMM_FAILURE; + } + + flags = resp.flags; + + if (!(flags & XE_SYSCTRL_APP_RESP_VALID)) + return XE_SYSCTRL_FIRMWARE_APP_INVALID; + + if (!(flags & XE_SYSCTRL_APP_RESP_BOOTED)) + return XE_SYSCTRL_FIRMWARE_APP_NOT_LOADED; + + if (!(flags & XE_SYSCTRL_APP_RESP_INITIALIZED)) + return XE_SYSCTRL_FIRMWARE_APP_BOOTED; + + return XE_SYSCTRL_FIRMWARE_APP_INITIALIZED; +} + +/** + * xe_sysctrl_is_oobmsm_fw_ready() - Check if oCode firmware is fully initialized + * @xe: xe device instance + * + * Returns true if oCode firmware has reached the initialized state, indicating + * it is ready to handle requests. Returns true also on platforms without System + * Controller support, as there is no firmware gate to wait on. + * + * Return: true if oCode is initialized or sysctrl is not present, false otherwise + */ +bool xe_sysctrl_is_oobmsm_fw_ready(struct xe_device *xe) +{ + enum xe_sysctrl_fw_status status = + xe_sysctrl_check_app_status(xe, XE_SYSCTRL_APP_OCODE); + + return status == XE_SYSCTRL_FIRMWARE_APP_INITIALIZED || + status == XE_SYSCTRL_FIRMWARE_APP_NOTSUPP; +} diff --git a/drivers/gpu/drm/xe/xe_sysctrl.h b/drivers/gpu/drm/xe/xe_sysctrl.h index 090dffb6d55f..325334509a03 100644 --- a/drivers/gpu/drm/xe/xe_sysctrl.h +++ b/drivers/gpu/drm/xe/xe_sysctrl.h @@ -20,5 +20,6 @@ void xe_sysctrl_event(struct xe_sysctrl *sc); int xe_sysctrl_init(struct xe_device *xe); void xe_sysctrl_irq_handler(struct xe_device *xe, u32 master_ctl); void xe_sysctrl_pm_resume(struct xe_device *xe); +bool xe_sysctrl_is_oobmsm_fw_ready(struct xe_device *xe); #endif diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h b/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h index d0341538ad05..c7ba6d69f4a7 100644 --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h @@ -14,9 +14,11 @@ * enum xe_sysctrl_group - System Controller command groups * * @XE_SYSCTRL_GROUP_GFSP: GFSP group + * @XE_SYSCTRL_GROUP_CORE: Core group */ enum xe_sysctrl_group { XE_SYSCTRL_GROUP_GFSP = 0x01, + XE_SYSCTRL_GROUP_CORE = 0xFF, }; /** @@ -38,6 +40,67 @@ enum xe_sysctrl_gfsp_cmd { XE_SYSCTRL_CMD_SET_HEALTH = 0x0C, }; +/** + * enum xe_sysctrl_core_cmd - Commands supported by Core group + * + * @XE_SYSCTRL_CMD_GET_APP_STATUS_BY_ID: Retrieve application status by ID + */ +enum xe_sysctrl_core_cmd { + XE_SYSCTRL_CMD_GET_APP_STATUS_BY_ID = 0x05, +}; + +/** + * struct xe_sysctrl_get_app_status_by_id_req - Get application status request + * + * @app_id: Application ID for which to retrieve status + */ +struct xe_sysctrl_get_app_status_by_id_req { + u8 app_id; +} __packed; + +/** + * struct xe_sysctrl_get_app_status_by_id_resp - Get application status response + * @flags: Application status flags (see XE_SYSCTRL_APP_RESP_* definitions) + */ +struct xe_sysctrl_get_app_status_by_id_resp { + u32 flags; +} __packed; + +/** XE_SYSCTRL_APP_RESP_VALID - app_id is recognized by System Controller firmware */ +#define XE_SYSCTRL_APP_RESP_VALID BIT(0) +/** XE_SYSCTRL_APP_RESP_BOOTED - application has completed its boot sequence */ +#define XE_SYSCTRL_APP_RESP_BOOTED BIT(1) +/** XE_SYSCTRL_APP_RESP_INITIALIZED - application has completed all post-boot initialization */ +#define XE_SYSCTRL_APP_RESP_INITIALIZED BIT(2) + +/** + * enum xe_sysctrl_fw_status - System Controller firmware application lifecycle states + * + * @XE_SYSCTRL_FIRMWARE_APP_INVALID: app_id is not recognized by firmware + * @XE_SYSCTRL_FIRMWARE_APP_NOT_LOADED: application is known but has not yet booted + * @XE_SYSCTRL_FIRMWARE_APP_BOOTED: boot sequence completed, post-boot init pending + * @XE_SYSCTRL_FIRMWARE_APP_INITIALIZED: application fully operational + * @XE_SYSCTRL_FIRMWARE_APP_NOTSUPP: System Controller not available on this device + * @XE_SYSCTRL_FIRMWARE_COMM_FAILURE: communication with System Controller firmware failed + */ +enum xe_sysctrl_fw_status { + XE_SYSCTRL_FIRMWARE_APP_INVALID, + XE_SYSCTRL_FIRMWARE_APP_NOT_LOADED, + XE_SYSCTRL_FIRMWARE_APP_BOOTED, + XE_SYSCTRL_FIRMWARE_APP_INITIALIZED, + XE_SYSCTRL_FIRMWARE_APP_NOTSUPP, + XE_SYSCTRL_FIRMWARE_COMM_FAILURE, +}; + +/** + * enum xe_sysctrl_app_id - Known System Controller application identifiers + * + * @XE_SYSCTRL_APP_OCODE: oCode application (firmware ID 12) + */ +enum xe_sysctrl_app_id { + XE_SYSCTRL_APP_OCODE = 12, +}; + /** * struct xe_sysctrl_mailbox_command - System Controller mailbox command */ -- 2.43.0