Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39735C44529 for ; Tue, 21 Jul 2026 12:22:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wm9U5-0003Di-8n; Tue, 21 Jul 2026 08:22:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9Tw-0002z5-DV for qemu-arm@nongnu.org; Tue, 21 Jul 2026 08:21:56 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9Tu-0003vr-OG for qemu-arm@nongnu.org; Tue, 21 Jul 2026 08:21:56 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LART7q1455614 for ; Tue, 21 Jul 2026 12:21:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rCdfC/fttUV6f/HWgpjNV1h6VJQ5cWJzdCAYU6K9+cA=; b=p7rTyuMVzfGlYVzF Z8TDBsDs1l7daNU4ZsuL3uBWbySkDzQM1ATSDMPI31+uRba9uQ4MBeiB4T8iIDvA Mify4a+MKnMyHQHIrZJKwMttmfVgca6txxLkM7AmfQebxIMIw7gsAdajY/hFCsSN RQiR5Jotq9H/RsskiipCraUPHZ1qukQxoBLd2LuvZNKtyfbAyZH90Y5qthR33MFY qFIVbnmPGQucRup+0HvpEBxNv/vh+D6mtGwUIDzjoYJWhMueZB7mkjdnhLueaiDw BJd61BtxZauKm7KbLl7G5gonNM3sfLyxpkkPtjG5fMpx8xenic+TLSG+zrrsMOHF +QDctw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1duj83x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 12:21:53 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c01ff996dso88509041cf.2 for ; Tue, 21 Jul 2026 05:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784636513; x=1785241313; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rCdfC/fttUV6f/HWgpjNV1h6VJQ5cWJzdCAYU6K9+cA=; b=gDm8b9DF0O8UtubKeWoRulKymxYExypmaJi962wujLvyzSJg9xfHgaoLj8bNYqBByV Xb4CcEcsVQRAAAzrZUiV2MRafECvbkarml7IJssYDl19acdbY8awLrVbWvEOwZ9U6wK4 /MNz2H9fmcSwUZV5iqvIJzVTBXEBUBKj6VStrT19QXQbw/mq7lQsddc4zo3ZgbSHmiA1 UHGF16zt3BzuTflDIRQWHh/QltLYVv6FgdgJbcmPOoAb9tMqeZlpv+0lt16kCVfrYwze 0gAtihp4uIPUN1+PSBZ8UommTbxB3UcO+uy9DRzqODicqA61r6eKy4eiPLt75vuxu+Aa yKxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784636513; x=1785241313; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rCdfC/fttUV6f/HWgpjNV1h6VJQ5cWJzdCAYU6K9+cA=; b=CQh71t09JV9OeceH2zpObWX/Beba29fTb3z0L8a0RwHRBGnYLvzup3Vyf5YJDraFdi tO1ELfjAx3SN4qdPZgIrafWd0CIZ1k6mZIbm9tyUwrEfyiavwVLACn8o5TIJ2LWS+Ui2 +1Mcir13+dMFy1uyHo500G57tVcJNQpg4bk77AYnJgebjJai+GL7/XAbhdwvqn9p0j/u jzQLTVFeTHuXHn2VDv5YSqfUxecPgoDaAIFQF+I9QIxJtuvQbO97ZLuwJBozxn4zCYMU oCsfrIGqrnvxc30MKZw0URSAA9Zt5Bu0qYaPnRRdp+f3GsicFmQp6F7Fj61NO3HHBRGZ HFGQ== X-Forwarded-Encrypted: i=1; AHgh+RrJGFf88LZNslm6sqFLXI8fFQI4hAhv8cIUcXZMw683H4qGe2qlVT/6sM2hIRyqS8oVRtKbEyhR8Q==@nongnu.org X-Gm-Message-State: AOJu0YxQr9xUG/FaAp3F+7CKHQiX5W02WUgOIN3TLRG1x8FkKWFYEzJo sDR3IiFaBKlp1wmfxVtUwx1drToeb1lyEwUqcmYkHoy6sLvQiwj4QrSuRFl83DI20+CvNAa0N3T nFSOn+sEvRI+My6dUe2TakXOlaU07i0wsT6NkArNrTIPtfbEpIgY51jI= X-Gm-Gg: AfdE7cm06v08OfopiJXzklmFEK7NrjkV1mqtPDu3+3CY1WrCVlXu/bW21oq5/AXZtT+ h/3wfb2BZKpWNamHW1Ecg5MQnZHE3S2DbKvhGAC+2VDqtw9+G/1nuBXpE2usd7L0q+ksNihdadk ERHODq/LuP0d3l+7IIp/qKIxLgrpOUWmw/7UsP25L/CR9gcKBgcLBZT447X9gObZ7Q6xtKAtaSe rwuXUm4e5GDJFXgkt1RDfwpwsbNDAf7q33yEA9EC80BYxECaXiVQ3NzyBGaZD9b3jIBm9xz5hIr G/p0y+p0XeQX6FC2Cobc0Q1FrGoL8KhRRni6KvAtmTUxxyutaM8PYkblAlMk9ySfo68/TxMsWWZ aZYFNqak0LQJV0P/KDAxXfw5VH+EquL88RWIUmekJOqSRcPCNtI6vNaV7zA== X-Received: by 2002:a05:622a:2616:b0:51c:10aa:9ba with SMTP id d75a77b69052e-5213e48b0d0mr161920851cf.46.1784636512780; Tue, 21 Jul 2026 05:21:52 -0700 (PDT) X-Received: by 2002:a05:622a:2616:b0:51c:10aa:9ba with SMTP id d75a77b69052e-5213e48b0d0mr161920411cf.46.1784636512197; Tue, 21 Jul 2026 05:21:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49565373200sm63597595e9.5.2026.07.21.05.21.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Jul 2026 05:21:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/4] target/arm: Add stub for define_gicv5_cpuif_regs() Date: Tue, 21 Jul 2026 14:21:32 +0200 Message-ID: <20260721122135.6288-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260721122135.6288-1-philmd@oss.qualcomm.com> References: <20260721122135.6288-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: rgEuDbmw-Y3QcGH51OTV6sBkpuV_vqaJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX+jZANiSrWNOm 8cLrdW6d3Qv99/sqAG0WHbVMLbfvMcmFo81FV+W2XHpnI08VRAQmVfesXd/jJZUVe2FOMOTlQte 5RuwabY+9m1tBDen8xzRRCNrC8sdru9AXRJWNHXpLL7ynMPqMafQH4yMDG49HSYGJP8+pcrZu2o cgPU3rf1I3AeBiHgmEGVhN8oXGgK4PlbAHyOlRa2RU7f1RNBP4M9YEE3Dn3GwD3vM1K6TVnd/XC o+VJRGf3oHW8/HetxIYtZtf7GYi3zUySyuUkCMtjpjmriXrbMnVU55McC1djQulkXKPJLoOrIxW SVjvVodTl/4o6sqwX5BhdX9xTEMia1bjMLZA6MDCQUtngIEHGJ1x5SccPte/k8U4yMKj+7kMwFL hfSEXOXQ2GmmU6WbXAeRqOpVQltK5Q2Xy3AIxtYWwvVTMuzq3b7MEnGUFqbyQ+sU4GrHv2yio8T VGKZ8cGfr02U+0OCyEA== X-Authority-Analysis: v=2.4 cv=I9JVgtgg c=1 sm=1 tr=0 ts=6a5f6461 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=TAc-z3PBzWRmM4gypW4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: rgEuDbmw-Y3QcGH51OTV6sBkpuV_vqaJ X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX1vY/vmz43jBR YYsjFc5bkXxGS3jsf6uPwdLHZP5q4LUU2W3pCjm22VtPWYv8nWucbT17rnIyaLvtp/PRX+HzpZe 8+Ps3Ra7AiNtkQUaEwRP8TS2wfeKhms= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_01,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210131 Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org The common helper.c file calls define_gicv5_cpuif_regs() which is only defined when TCG is built: $ git grep -w define_gicv5_cpuif_regs target/arm/internals.h:1885:void define_gicv5_cpuif_regs(ARMCPU *cpu); target/arm/helper.c:6334: define_gicv5_cpuif_regs(cpu); target/arm/tcg/gicv5-cpuif.c:923:void define_gicv5_cpuif_regs(ARMCPU *cpu) This fixes when building on macOS with --disable-tcg: Undefined symbols for architecture arm64: "_define_gicv5_cpuif_regs", referenced from: _register_cp_regs_for_features in target_arm_helper.c.o Define the GICv5 stubs in their own compilation unit, otherwise we get the following error: duplicate symbol '_raise_exception_ra' in: libsystem_arm.a.p/target_arm_tcg_op_helper.c.o libstubs_arm.a[4](target_arm_tcg-stubs.c.o) Fixes: ee0f1ce00db ("target/arm: GICv5 cpuif: Initial skeleton and GSB barrier insns") Signed-off-by: Philippe Mathieu-Daudé --- target/arm/gicv5-stubs.c | 17 +++++++++++++++++ target/arm/tcg-stubs.c | 4 ---- target/arm/meson.build | 1 + 3 files changed, 18 insertions(+), 4 deletions(-) create mode 100644 target/arm/gicv5-stubs.c diff --git a/target/arm/gicv5-stubs.c b/target/arm/gicv5-stubs.c new file mode 100644 index 00000000000..845626d7c6b --- /dev/null +++ b/target/arm/gicv5-stubs.c @@ -0,0 +1,17 @@ +/* + * QEMU ARM stubs for GICv5 TCG helper functions + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "internals.h" + +void define_gicv5_cpuif_regs(ARMCPU *cpu) +{ + g_assert_not_reached(); +} + +void gicv5_update_ppi_state(CPUARMState *env, int ppi, bool level) +{ +} diff --git a/target/arm/tcg-stubs.c b/target/arm/tcg-stubs.c index 8d97449cfc6..aeeede80661 100644 --- a/target/arm/tcg-stubs.c +++ b/target/arm/tcg-stubs.c @@ -43,7 +43,3 @@ void vfp_clear_float_status_exc_flags(CPUARMState *env) void vfp_set_fpcr_to_host(CPUARMState *env, uint32_t val, uint32_t mask) { } - -void gicv5_update_ppi_state(CPUARMState *env, int ppi, bool level) -{ -} diff --git a/target/arm/meson.build b/target/arm/meson.build index 4412fde065f..f6ae8934d1b 100644 --- a/target/arm/meson.build +++ b/target/arm/meson.build @@ -37,6 +37,7 @@ arm_system_ss.add(when: 'CONFIG_HVF', if_true: files('hyp_gdbstub.c')) arm_user_ss.add(files('cpu.c')) arm_stubs_ss.add(files( 'cpu32-stubs.c', + 'gicv5-stubs.c', 'kvm-stub.c' )) arm_user_ss.add(files( -- 2.53.0