Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08D0F2EBB8D; Tue, 21 Jul 2026 20:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784667351; cv=none; b=FWQ+5gSDllY4zTDg680dafffNTi68K4nIrov81rtCwOXwEUxY9IZ9Dq/2aoIjtNPsGfFChFaxMFjzPxHtPD8Se3RHOTPPmPUjDoAv8a15KEgU8oXQLSo0yG//et53eAnJmZgydw3+pfjA/N3P+j1NpwE59E9snE/AYLf9j7354s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784667351; c=relaxed/simple; bh=PAoIoZRLnbTOtJbF8+Lue9++HsqkUWjDEYTU3QMigKw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lKteECludonlPvA31uuYjGAuNLa3LEPe3sMXX6vk3jPi6zr/BRa55nfHrO0v9e5JH/FDOV2aDxznrf7KbZTh/yB+/s8iJCSgGqB7m10Bxv684KkZ0hbI1+dSKTenCX1LJy9SXylOKjOcQXGDCxyi6iGBDBwnKDUvIIQNZwLyn6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Iv2p3hB9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Iv2p3hB9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DC861F000E9; Tue, 21 Jul 2026 20:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784667349; bh=8HfSUdE/M22WiKV3y/Tyj/aFRr6KczekWZ5hbMFruoA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Iv2p3hB9kXu3BprBMVeCcQc5+ISHRIrgJa3P+p7FmIR6PYRJwTibPtrkNdYjE17QF j2qBhMTgpp3gD7JJqT0bQRqxcjwCaYVcm9EK9J0OT69P4brmrcphLtl0RhQYxtdYo8 h46RLGbGZ27NvmT46Wujv7iBK2E90eWxj0gdz9Tw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiao Liang , Maoyi Xie , Kuniyuki Iwashima , Jakub Kicinski Subject: [PATCH 6.6 1029/1266] xfrm: xfrm_interface: require CAP_NET_ADMIN in the device netns for changelink Date: Tue, 21 Jul 2026 17:24:26 +0200 Message-ID: <20260721152504.851839074@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit 095515d89b19b6cc19dfcdc846f97403ed1ebce3 upstream. xfrmi_changelink() operates on at most two netns, dev_net(dev) and the interface link netns xi->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in xi->net can rewrite an interface that lives in xi->net. Gate xfrmi_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20260612085941.3158249-8-maoyixie.tju@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/xfrm/xfrm_interface_core.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/xfrm/xfrm_interface_core.c +++ b/net/xfrm/xfrm_interface_core.c @@ -874,6 +874,9 @@ static int xfrmi_changelink(struct net_d struct net *net = xi->net; struct xfrm_if_parms p = {}; + if (!rtnl_dev_link_net_capable(dev, net)) + return -EPERM; + xfrmi_netlink_parms(data, &p); if (!p.if_id) { NL_SET_ERR_MSG(extack, "if_id must be non zero");