Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FEC547044A; Tue, 21 Jul 2026 20:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664046; cv=none; b=iVum1NJz0/FbsVHqW6g2EehOZLCRJ/1yTHaJbPEuHt3T2VL814HwQRQ/C6UjyUQAs+MBYb/MUmGfwcNpGUvzsLjaZZEIz7NHFfvvE+/RHj/hVroPhhyiaQ+J5fwazU4q28EsCD+ci/53D3DyZMvYJqF1pJiQTzife0CjKC6KLFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664046; c=relaxed/simple; bh=aiDyaP4OPhFbjxuASqgPB68vhAGxpU5772RlrkPEyLo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TLZglDOztsLjckptDqxTYOBJMyoF3sBWnB1CRef/xNMbh//WQZ5sXZbBx0Nky6bbefzFPgJ9OEU/vF+RPPpuRvJ0TvNCTn0corchhP4cgbXIbtGsgqyrtnuplhIshVuy/CIKfAKezptrg4bHKvtwS2d76tKlHq7d+tRg72gEIFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WNBNQmKC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WNBNQmKC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E411D1F000E9; Tue, 21 Jul 2026 20:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784664045; bh=FOTZTzidyRZ0eGycRrqc73+ZUCd6iwnIxIKnYGnn7lY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WNBNQmKCFkXN4Uq5kRVOnyFn5EoyWMEPIdcj1mwF49iQtuVhv/WOGjlEoS/+lef5W sMeAhDjpmYHv21s+C7fi1+GMyzzqBZ8iXBZCAoJx/dDl/AX0iOj6R7zRcTcfRYrjB7 LK19ibU9ay7hehmiyUz5m9wRwlONVccM+HXZANbU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiao Liang , Maoyi Xie , Kuniyuki Iwashima , Jakub Kicinski Subject: [PATCH 6.12 1051/1276] net: ip_vti: require CAP_NET_ADMIN in the device netns for changelink Date: Tue, 21 Jul 2026 17:24:54 +0200 Message-ID: <20260721152509.508694278@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152446.065700225@linuxfoundation.org> References: <20260721152446.065700225@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit 95cceadbfd52d7239bd730afdda0655287d77425 upstream. vti_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate vti_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 895de9a3488a ("vti4: Enable namespace changing") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20260612085941.3158249-4-maoyixie.tju@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv4/ip_vti.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ipv4/ip_vti.c +++ b/net/ipv4/ip_vti.c @@ -594,6 +594,9 @@ static int vti_changelink(struct net_dev struct ip_tunnel_parm_kern p; __u32 fwmark = t->fwmark; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + vti_netlink_parms(data, &p, &fwmark); return ip_tunnel_changelink(dev, tb, &p, fwmark); }