Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49CC2471414; Tue, 21 Jul 2026 20:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664618; cv=none; b=uFvF85ZToeyOtk24ShkIjIgOsoO2qnObSF667ICa1j7XKgTEINX0+m2A/dRIT6G2TjqnGIna+Q/8R2AUMA7Jw+wzHJkEUQvUOiFfpClieFUzv2LV9UJREKPKyyRxCRrUYwr8SeUEVI0a+BI5z1ifHwWVDsEbiMTQss+ZwvHxGno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664618; c=relaxed/simple; bh=eIDzOL6rhKwJIokxyN4gYh7GGmtdSXpNuBWhASH60lw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d9yBNqpvfpDT5/gvKRv7CdLosF89POYVo6UGtcx41VFE8KEkA2sXHxZjU7sEh2UrIfpueh44lIIDouV01MyBntpdVPe8ow7kXyDCGaIInMo4RlJmdKz0qR2WN+PESmJ9kfAM5KofwmGxF+W1fJZZo5uXqEzJuqFnqh3NL78Tu6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fdEkRM5q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fdEkRM5q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE4931F00A3A; Tue, 21 Jul 2026 20:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784664617; bh=U+H+vQmv0WdIKX686lTf+t6TmB2OuTupo3Egk1olwyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fdEkRM5qrtLYuZdKj1RPzT32cXgctY5LdNZgfSXWf6DspkPGcw+epCwYQTRjy2hjw Gx8njy6e9/3fj3shy+OhEA1Hf3t8Fi4N1ZGwJlHzz+0EvDKtZCST3Qmq0DrsjmZ8eJ F77Q2EbjYEiAOyAdRXPuyaDE8zy3afDYgXeT2Bb8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mohammad Heib , Aleksandr Loktionov , Paul Menzel , Tony Nguyen , Rinitha S Subject: [PATCH 6.12 1268/1276] i40e: drop udp_tunnel_get_rx_info() call from i40e_open() Date: Tue, 21 Jul 2026 17:28:31 +0200 Message-ID: <20260721152514.464403866@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152446.065700225@linuxfoundation.org> References: <20260721152446.065700225@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mohammad Heib commit 40857194956dcaf3d2b66d6bd113d844c93bef54 upstream. The i40e driver calls udp_tunnel_get_rx_info() during i40e_open(). This is redundant because UDP tunnel RX offload state is preserved across device down/up cycles. The udp_tunnel core handles synchronization automatically when required. Furthermore, recent changes in the udp_tunnel infrastructure require querying RX info while holding the udp_tunnel lock. Calling it directly from the ndo_open path violates this requirement, triggering the following lockdep warning: Call Trace: ? __udp_tunnel_nic_assert_locked+0x39/0x40 [udp_tunnel] i40e_open+0x135/0x14f [i40e] __dev_open+0x121/0x2e0 __dev_change_flags+0x227/0x270 dev_change_flags+0x3d/0xb0 devinet_ioctl+0x56f/0x860 sock_do_ioctl+0x7b/0x130 __x64_sys_ioctl+0x91/0xd0 do_syscall_64+0x90/0x170 ... Remove the redundant and unsafe call to udp_tunnel_get_rx_info() from i40e_open() resolve the locking violation. Fixes: 1ead7501094c ("udp_tunnel: remove rtnl_lock dependency") Signed-off-by: Mohammad Heib Reviewed-by: Aleksandr Loktionov Reviewed-by: Paul Menzel Tested-by: Rinitha S (A Contingent worker at Intel) Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -9110,7 +9110,6 @@ int i40e_open(struct net_device *netdev) TCP_FLAG_FIN | TCP_FLAG_CWR) >> 16); wr32(&pf->hw, I40E_GLLAN_TSOMSK_L, be32_to_cpu(TCP_FLAG_CWR) >> 16); - udp_tunnel_get_rx_info(netdev); return 0; }