Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FBA146D54B; Tue, 21 Jul 2026 18:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659053; cv=none; b=jvict6XoEyg00nXi6a6VKQwj85PVTsOBNe1g5Ny7dbATuDlT2Z0QlUyl1MOz7uG250kpkzcVjKWw5bKy2nZCuqWO2xvPvWX26E3qgTdJGzZkbfa5Qm8Raz4TR81NgVNi1jrgr+ck+pBbP4hjCBDsWr2up/kKqP7Q0Fpw1CBn9N8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659053; c=relaxed/simple; bh=Nm+oV6dWMUZGV8ORgydjy88BchP8RCDiWKn22hdSxUY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fWgrPw/yAuuAv5QdZ1HZaxmLif9KgoXUl6lkCePb8Iod1tsdwLbd6CVXPWVa39BMhk98hECeDNZHjwREAYYgsHBu2xXjcZRU0Vahic8rrZFxHQlLlx4CazkgYhYRnXFczMaH0MmoP3mF0lZoL1OYrFl59MfqRVLgfgjbf5tlEwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=v7E1drFe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="v7E1drFe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 116FB1F000E9; Tue, 21 Jul 2026 18:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784659051; bh=i289mGWT0QPa34XcTGrIqx8RcloPRCR1TTHhn5m/j5o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=v7E1drFey8EpRt4cWRcpdaZfmeVxjWGC48W/S32vmCMv3LkJBruy02KcjiRIeluuc 5W5Ag/3tLECcd9BsmwvFKGO6eq2By3E8h0Q8fBQhTWikCKpJZLoStWzZt4s2IVimx5 nCr+TXeE4tKk9oEo0I0IFptxquRd8ISRj+v3z6B8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko bot , Dmitry Torokhov Subject: [PATCH 6.18 1374/1611] Input: ims-pcu - fix use-after-free and double-free in disconnect Date: Tue, 21 Jul 2026 17:24:50 +0200 Message-ID: <20260721152546.352945835@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Torokhov commit 462a999917755a3bf77448dfd64307963cf0a9f0 upstream. ims_pcu_disconnect() only intended to perform cleanup when the primary (control) interface is unbound. However, it currently relies on the interface class to distinguish between control and data interfaces. A malicious device could present a data interface with the same class as the control interface, leading to premature cleanup and potential use-after-free or double-free. Switch to verifying that the interface being disconnected is indeed the control interface. Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") Cc: stable@vger.kernel.org Reported-by: Sashiko bot Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/ims-pcu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -2051,7 +2051,6 @@ err_free_mem: static void ims_pcu_disconnect(struct usb_interface *intf) { struct ims_pcu *pcu = usb_get_intfdata(intf); - struct usb_host_interface *alt = intf->cur_altsetting; usb_set_intfdata(intf, NULL); @@ -2059,7 +2058,7 @@ static void ims_pcu_disconnect(struct us * See if we are dealing with control or data interface. The cleanup * happens when we unbind primary (control) interface. */ - if (alt->desc.bInterfaceClass != USB_CLASS_COMM) + if (intf != pcu->ctrl_intf) return; ims_pcu_stop_io(pcu);