Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3F1364959; Tue, 21 Jul 2026 18:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659066; cv=none; b=AK5XylOBzItwtvLHWhRkYsqgg3w6ALA+jpEdb5oziO283WDvff3Yn3lyihb4ZCo1aLjgvWvMOItvY6IbaVQaYT4HxP8wdTgimHGiVR3fjxSIzqYwFEuY63voE01tWAfThE8ga6SeusE79nVdB3FHvm6yDx7BPa3yXb8coR4SoEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659066; c=relaxed/simple; bh=JX5LOG5SeljaFNzntpg3wVkRlZ+RY4c+e7lMuLEqbzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mc6DijZGbtg/epVCpAPIWl6jlZz0mmn2+hbaY2tkDbYcNMqPVh5oGQpbzr239xvWJgioyr+X8oZpZGJu//LyYngZ8dvEM7INord+MlC/vopD6efaTNi7wi6WNCfFZEI6NewaDQAWznjvUEsxpY02K01HnqGtMbf9KFV9OISrYyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jKhc09VA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jKhc09VA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C4731F000E9; Tue, 21 Jul 2026 18:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784659064; bh=5mMLCxm2Fd77eD+bdlMLcJdkVNpd2FhdC0d1tbJrbPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jKhc09VA9NNSeq2h8A5NMopEn/14XqPcaWv11jikrvUF93871gBkD6+Rlh5M8NrgT T7te3yPMNM9dm9JfPCWmdiCOJ8RUH2O5Y3acLBf9YxkjWjtLANJH9ArRNSUtEis9bj TuiX+ofM7bsKnDx6MwB0jvFJTqbzrrdbB4UdNaDc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko bot , Dmitry Torokhov Subject: [PATCH 6.18 1379/1611] Input: ims-pcu - fix DMA mapping violation in line setup Date: Tue, 21 Jul 2026 17:24:55 +0200 Message-ID: <20260721152546.461040865@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Torokhov commit 8adf4289d945e8990e4336436a97da71d21d2cae upstream. In ims_pcu_line_setup(), the driver uses pcu->cmd_buf as a transfer buffer for usb_control_msg(). However, pcu->cmd_buf is embedded in the struct ims_pcu allocation, which violates DMA mapping rules regarding cacheline alignment. Use a heap-allocated buffer for the line coding data instead. Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") Cc: stable@vger.kernel.org Reported-by: Sashiko bot Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/ims-pcu.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -1821,11 +1821,16 @@ static void ims_pcu_stop_io(struct ims_p static int ims_pcu_line_setup(struct ims_pcu *pcu) { struct usb_host_interface *interface = pcu->ctrl_intf->cur_altsetting; - struct usb_cdc_line_coding *line = (void *)pcu->cmd_buf; + struct usb_cdc_line_coding *line __free(kfree) = + kmalloc(sizeof(*line), GFP_KERNEL); int error; - memset(line, 0, sizeof(*line)); + if (!line) + return -ENOMEM; + line->dwDTERate = cpu_to_le32(57600); + line->bCharFormat = USB_CDC_1_STOP_BITS; + line->bParityType = USB_CDC_NO_PARITY; line->bDataBits = 8; error = usb_control_msg(pcu->udev, usb_sndctrlpipe(pcu->udev, 0),