Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C98546EF73; Tue, 21 Jul 2026 18:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659095; cv=none; b=jk4mjjzFFP95yWfmoTAVnT6PXnSxwJpZ8QuIduI/c/K/JN6zIi6DzqqG1ViwiuzejeYqjwDvU6Ub/2ZsS5VDfqU7w1MoWDQj9WHPhPw+7EUp0QbBvPYbPSU8+dXSzKMAlJL8/grodaajI1bdr9pItfdqP0gILYKxyzk32JCuK0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659095; c=relaxed/simple; bh=gBmN2xcXFpt+sLqqtupNAnohPymb0wmhINg8eHx6S1w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XsL56aXBX9D22DThXUIs+aWEXukesb2Huupq37lxevsWDzKhKcSvfG0sxfuX4JF90OPD2j0dxIfIK6LYg8dmrCmdwKpMGmloGjh7Yb//mNKCd2IcVS631A1Ayrc7vz4GD3NN/4VOD33t3rIcwLktBMd5eSQOEecOsfAkCn1aawM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=s5rygyVn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="s5rygyVn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A5541F00AC4; Tue, 21 Jul 2026 18:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784659088; bh=bm3aQRPDQ1dfE2RIrsAteqK5VtJp2ikCDZfKxllPY7Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=s5rygyVnbLLC8b9AQtIhWk5TiMnvXmjvC7T1sDbnnuH0iiEV3YKzpTBZTC9IXTlm6 tQdRHvDN5sFTqtVIC7Gw15/iXy9XWADWa00W7/8y79pqDuEyAjsJEXQphhxhND0nLc A8zmAsUd/Ai9m1v99+2v6b8/tckriZe28ZKAIl7s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maoyi Xie , Johannes Berg Subject: [PATCH 6.18 1387/1611] wifi: libertas_tf: fix use-after-free in lbtf_free_adapter() Date: Tue, 21 Jul 2026 17:25:03 +0200 Message-ID: <20260721152546.640055312@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit aa6dcd5c8dd9ba1d7d0f60093bcda41c0d6d438d upstream. lbtf_free_adapter() calls timer_delete(&priv->command_timer), which does not wait for a running command_timer_fn() callback. lbtf_free_adapter() runs on the teardown path right before ieee80211_free_hw() frees priv, both in lbtf_remove_card() and in the probe error path. command_timer is armed by mod_timer() in lbtf_cmd() whenever a firmware command is sent. command_timer_fn() dereferences priv. If a command times out as the device is removed, command_timer_fn() runs concurrently with teardown and dereferences priv after it has been freed. This is the same use-after-free that commit 03cc8f90d053 ("wifi: libertas: fix use-after-free in lbs_free_adapter()") fixed in the sibling libertas driver. The libertas_tf variant has the identical pattern and was left unchanged. Use timer_delete_sync() so any in-flight callback completes before priv is freed. Fixes: 06b16ae53192 ("libertas_tf: main.c, data paths and mac80211 handlers") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Link: https://patch.msgid.link/178211481807.2212567.8773346114561900100@maoyixie.com Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/marvell/libertas_tf/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/marvell/libertas_tf/main.c +++ b/drivers/net/wireless/marvell/libertas_tf/main.c @@ -174,7 +174,7 @@ static void lbtf_free_adapter(struct lbt { lbtf_deb_enter(LBTF_DEB_MAIN); lbtf_free_cmd_buffer(priv); - timer_delete(&priv->command_timer); + timer_delete_sync(&priv->command_timer); lbtf_deb_leave(LBTF_DEB_MAIN); }