Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8F3E2DF3EA; Tue, 21 Jul 2026 18:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659134; cv=none; b=KNcPMUczd7Du3/Hvg3Xc/DdJKRCDUTftTsRuA4fHOG5RaSP7hdUFlXhrW3T2hseKWPeXljsQFayjfddpQIVO/oA0ttlK/MQ7TlVGMuRPcbUpi83W43+GlEjhsCHERVG8Jj7LEbGMxBDsUDmjdipI1JQknLEc0LB5egDeFBeAscE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659134; c=relaxed/simple; bh=+uHPqpLsmS/mJwjbiVe3uQ8NhvxbAG7YQcPHSLuZoZQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qex/hrgT2xysgTk47mjz7XWNTJzRiDJYk3HzdCnhDXvdRtzaxGuoHydadXm2uQ3SRx8NhAlqt7VJcl99mvSYHP2Z9YT9wJ6ST7T6+rrmSWOS1892QcJ/1oNZMJoYPeiLSgUR9Gq/bgm9IsNr9YXqOmRQXiG9025cYvvhJyG8nNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dK0A1d1w; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dK0A1d1w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B9141F000E9; Tue, 21 Jul 2026 18:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784659133; bh=2evccwlbyDPWbsNcxvCHmMKCcYwnWL++X9KoUbbTRbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dK0A1d1wNWlMgAjaZQT44XQL/mIxI9uaIjL5CJlhszsXqpLTUN5VM2TaH6Bt12RTw 1NuU2GvELSZHKyTcp8ug+j1nXXhy65p9YrmoMLKDHrBMvlNzxPzySkQR1x+jIVpbJG 8aRfhn32tpQWZKeWgHRVtpgWuecn4yY4bWdmnn3U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiao Liang , Maoyi Xie , Kuniyuki Iwashima , Jakub Kicinski Subject: [PATCH 6.18 1407/1611] net: ip_vti: require CAP_NET_ADMIN in the device netns for changelink Date: Tue, 21 Jul 2026 17:25:23 +0200 Message-ID: <20260721152547.090482401@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit 95cceadbfd52d7239bd730afdda0655287d77425 upstream. vti_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate vti_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 895de9a3488a ("vti4: Enable namespace changing") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20260612085941.3158249-4-maoyixie.tju@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv4/ip_vti.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ipv4/ip_vti.c +++ b/net/ipv4/ip_vti.c @@ -596,6 +596,9 @@ static int vti_changelink(struct net_dev struct ip_tunnel_parm_kern p; __u32 fwmark = t->fwmark; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + vti_netlink_parms(data, &p, &fwmark); return ip_tunnel_changelink(dev, tb, &p, fwmark); }