Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AED547125D; Tue, 21 Jul 2026 18:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659217; cv=none; b=NjIiHSxWzxfMo5lZ3LeRUuQ9ZZCb0iHePV2S6esXEua7v7GMEPYcSt0DsNpYGpNi5NPp9bkcbHy6SxeXGprcJt3mnBSZYY2uXUt1PXww/dAf9JByM/7yO6vDEERZxLNaK2BornYMZpgcmsykyORIXBvGaeoIcyTr3/8spnN2jTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659217; c=relaxed/simple; bh=ByFFD8V3XabK3B2XZUOye1kNZKrpvihxWKrQVwsXEIA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BHGEL5W7xtECEx9WWDGluYgT6FN5D/a2ULSNv5m4HPpwU2Ttr0tW9O7DoT3sUpSbRtAKzqO9RyaORN+ENDvCcmWf8RDNvSJxyh0k9ml93gLzhvh0lC8DDO/NOUY196uyClF03psyoKZCx7V0e00KiLuUDkGERUYLS6moayQZo+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HxkBhKhV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HxkBhKhV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B3C11F000E9; Tue, 21 Jul 2026 18:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784659216; bh=GhLD3IhBDX10GOTcxvDr6rQZ/5rko0E5/Ur6i8o0NuU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HxkBhKhV4xd19BpogQ6bcwWQA3nRGhIYix7REK6ZgyyuoV595/kssRFdYdcp7/AlG 6Ea+buoc6+pCbRvr3gY6VbFOlkZiHL8t0t/1UpQR4SoSN4L6AX4fGoI5Ba25GDTG1B v7O63Uyy3JsxvERHux+RCMITr/raszznc4T/ICtg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Haoxiang Li , Pavan Chebbi , Breno Leitao , Paolo Abeni Subject: [PATCH 6.18 1435/1611] fsl/fman: Free init resources on KeyGen failure in fman_init() Date: Tue, 21 Jul 2026 17:25:51 +0200 Message-ID: <20260721152547.719566712@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li commit d288efa2b94abc2e45a061fceb156b4f4e5b37be upstream. fman_muram_alloc() allocates initialization resources before initializing the KeyGen block. If keygen_init() fails, the function returns -EINVAL directly and leaves those resources allocated. Free the initialization resources before returning from the KeyGen failure path. Fixes: 7472f4f281d0 ("fsl/fman: enable FMan Keygen") Cc: stable@kernel.org Signed-off-by: Haoxiang Li Reviewed-by: Pavan Chebbi Reviewed-by: Breno Leitao Link: https://patch.msgid.link/20260625004834.3394389-1-haoxiang_li2024@163.com Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/fman/fman.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/freescale/fman/fman.c +++ b/drivers/net/ethernet/freescale/fman/fman.c @@ -1995,8 +1995,10 @@ static int fman_init(struct fman *fman) /* Init KeyGen */ fman->keygen = keygen_init(fman->kg_regs); - if (!fman->keygen) + if (!fman->keygen) { + free_init_resources(fman); return -EINVAL; + } err = enable(fman, cfg); if (err != 0)