Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E175411691; Tue, 21 Jul 2026 19:07:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660828; cv=none; b=IbB8j873NShMVx0pJgvYiMLFN8lxf1AbJ3KHq5WkIZOzNoLsAsfPbpnXJk7e0P96mE/2EfaYSloO5ijdBSLT9r2oHCQ837H+bV+3kfpmSh3S7M4fQkotcuZcQo8bzVgqI+rTcV8GLuERDdrdbRFihWKK/Qo46nspYJadr8xbqt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660828; c=relaxed/simple; bh=SzlydQ3hQGYgapVLiMYf9eyvgW3n1aL7s7pfvpctSdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eV0u+Ugsfx8EPap1VlJRjIhJ3zPEQY8Y2FBOegQTKmskkN183pDeyPNG3ktnRLUYkgTIAmT1tj5JubitnVaK3h6vCOL3J6c28a7qnibanUevQeZheoy8kIeG3WoF582Tx2190eTOBzEFEGMKOVMk68l2s+SlrzJaJu4eyXnld2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Ygot6QtE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ygot6QtE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDA911F00A3A; Tue, 21 Jul 2026 19:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784660827; bh=sVPi2ekNqf36Vp3yO9Kx39qopMeWzardStBJV4yzjbM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Ygot6QtEPHCawKe4xXnQQaavKpJc/ixm7IooTwP3fNSo0rAKJzHwx8oB1s33yCl5k 5G6BjlRxEMqfFjPbW72ZQFtKbEjXtJD24yoeHyVkQLKfuKb3kLC/jt4ifcfC9BwZPZ HpDfzHdZYIUxDUTwBovFEAFh5z1bz//OcyWF8Rgo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jakub Kicinski , Ido Schimmel , Nikolay Aleksandrov , Petr Machata , Sasha Levin Subject: [PATCH 7.1 1127/2077] selftests: vlan_bridge_binding: Fix flaky operational state check Date: Tue, 21 Jul 2026 17:13:20 +0200 Message-ID: <20260721152619.399905061@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ido Schimmel [ Upstream commit 4045f1c3d68ef4b589ae2587e6ff66ce8017daf2 ] check_operstate() busy waits for up to one second for the operational state to change to the expected state. This is not enough since carrier loss events can be delayed by the kernel for up to one second (see __linkwatch_run_queue()), leading to sporadic failures. Fix by increasing the busy wait period to two seconds. Fixes: dca12e9ab760 ("selftests: net: Add a VLAN bridge binding selftest") Reported-by: Jakub Kicinski Closes: https://lore.kernel.org/netdev/20260616092733.3a31be4d@kernel.org/ Signed-off-by: Ido Schimmel Reviewed-by: Nikolay Aleksandrov Reviewed-by: Petr Machata Link: https://patch.msgid.link/20260617104323.1069457-1-idosch@nvidia.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- tools/testing/selftests/net/vlan_bridge_binding.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/vlan_bridge_binding.sh b/tools/testing/selftests/net/vlan_bridge_binding.sh index e8c02c64e03a47..d04caa14202d03 100755 --- a/tools/testing/selftests/net/vlan_bridge_binding.sh +++ b/tools/testing/selftests/net/vlan_bridge_binding.sh @@ -64,7 +64,7 @@ check_operstate() local expect=$1; shift local operstate - operstate=$(busywait 1000 \ + operstate=$(busywait 2000 \ operstate_is "$dev" "$expect") check_err $? "Got operstate of $operstate, expected $expect" } -- 2.53.0