Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9C8E388E40; Tue, 21 Jul 2026 19:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660876; cv=none; b=LOu2WHkPREqFovH/DNCMrPI3oz6UYNgk8DAu4M5ZlKCBzGmb7RgaQJYhlYiKT95x9ibk92TQ8siHOtJRaONBnNnifDFoGWYuHcAmx6vryAt5dO1uvGrUQ/MdQXbdThJYcOXuu7LM3JTcWnX2Q4bjkEFs/w2FGykP/flgDeSefK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660876; c=relaxed/simple; bh=3IYq8KRIkcj9pVL/+hO1pXFw9403xak1m857hsljHes=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sTHOpTyz0r59jGNZOdVpORt8E+Ajok1Q7yA0qZ++xNrDJdThDbIssady8GpqWKzBZFhfMtQLsvGWXc3TJSE/BE1sfNrwNVFB+Bz/XI5Z3WZXzO6Yi7LK9Eb9WxI2YSftU+bdlbbhcVt2pjllRAKePAFtEjbpOk9TUKR+mHB9LAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2bX+YJ2M; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2bX+YJ2M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B9981F00A3A; Tue, 21 Jul 2026 19:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784660874; bh=LOSwzCMEcR8SM5sEeLKM9qL8mAIeQH5qFf1vlP06Wwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2bX+YJ2MH+MmaYjtBvE93z2uV36MBgg9aKXBDdqi8XrxBPiv3UkzsXBnHzoSoCUR3 K4DfyVtq767amLb4dNrk9x7GS+BbQFLTIxpc7O0rjeL9BP+nxFIAfz5l7YvXNWiQyb TSdx/W+9RmsBNxN9welQAeVRGwSR5qSlN4uwxTSs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abd-Alrhman Masalkhi , Yu Kuai , Sasha Levin Subject: [PATCH 7.1 1143/2077] md/raid10: fix writes_pending and barrier reference leaks on discard failures Date: Tue, 21 Jul 2026 17:13:36 +0200 Message-ID: <20260721152619.781493123@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abd-Alrhman Masalkhi [ Upstream commit 393d687131d8aa8c7e4de2cb494438e145d20fc2 ] raid10_make_request() acquires a writes_pending reference with md_write_start() before calling raid10_handle_discard(). Several failure paths in raid10_handle_discard() complete the bio and return without releasing the corresponding reference, causing md_write_end() to be skipped. Call md_write_end() before returning from these failure paths to keep writes_pending accounting balanced. Additionally, discard split allocation failures can occur after wait_barrier() succeeds. Those paths return without calling allow_barrier(), leaking the associated barrier reference. Release the barrier before returning from those paths. Fixes: c9aa889b035f ("md: raid10 add nowait support") Fixes: 4cf58d952909 ("md/raid10: Handle bio_split() errors") Signed-off-by: Abd-Alrhman Masalkhi Link: https://patch.msgid.link/20260613182810.1317258-4-abd.masalkhi@gmail.com Signed-off-by: Yu Kuai Signed-off-by: Sasha Levin --- drivers/md/raid10.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 5ad1b0c6207a72..aacf160ee9f209 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1639,6 +1639,7 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio) if (!wait_barrier(conf, bio->bi_opf & REQ_NOWAIT)) { bio_wouldblock_error(bio); + md_write_end(mddev); return 0; } @@ -1681,6 +1682,8 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio) if (IS_ERR(split)) { bio->bi_status = errno_to_blk_status(PTR_ERR(split)); bio_endio(bio); + md_write_end(mddev); + allow_barrier(conf); return 0; } @@ -1698,6 +1701,8 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio) if (IS_ERR(split)) { bio->bi_status = errno_to_blk_status(PTR_ERR(split)); bio_endio(bio); + md_write_end(mddev); + allow_barrier(conf); return 0; } -- 2.53.0