Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB07D471252; Tue, 21 Jul 2026 19:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784661037; cv=none; b=HDXCxQv33p1cdOJnCp5XFk3YMXPN9uyzgPJUp4K5WsDtZQTtZvijYylBv2XJaxhJVibLSFf4zAtrOhDwgSoPpHHDFR9M+MHMGhdrJbuytGSPx5BoPLDanlV/qPBPMD4V0oY7b1teFTDGA3mw25F+2eYFN/pcT2di5twgjElCn1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784661037; c=relaxed/simple; bh=Jg04IobN6C2rL7phzVH5EXWIL09YOCc4m44+3IEhZI8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iU9wvPvHt3YEwplp6ArWASP3Ew/rUPZ73PPt8hhsLDZ3gRJcj+ja+bqKAQKSkCfczxbZY1Oq8HuoDEd8k9i8xcv8VIjva6KvlOtV3fAsWtJ+gDVsM9pcbFr8Vs1KRO/+t+feKgpiB2pvsA7pMswMMWXJf29XW0oaKzGj54Ai/is= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=m/bPls+N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m/bPls+N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4263D1F000E9; Tue, 21 Jul 2026 19:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784661036; bh=HCSAOf8P6/wnIV6XE3ynHagzV7wSGzslfwGwsPzu2Lo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=m/bPls+NQ1MaF2O+/PGkSIHe3749V4D2Ho5gvxk2AJbF4sI5jPWVMAHL9z3vP+FVb su8gciqK/GBj4dNcIgOLkisIfc3izlVE0x8uLUYC9QA1V7WDtALpYUOQX1jDFV9Stl /uEmnzjBW93unB/L5z9jxVYhdfcxi+y8sNZLEr8g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dawid Osuchowski , Aleksandr Loktionov , Simon Horman , Rafal Romanowski , Tony Nguyen , Sasha Levin Subject: [PATCH 7.1 1208/2077] ice: fix FDIR CTRL VSI resource leak in ice_reset_all_vfs() Date: Tue, 21 Jul 2026 17:14:41 +0200 Message-ID: <20260721152621.307238983@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dawid Osuchowski [ Upstream commit ebbe8868cf473f698e0fbaf436d2618b2bcda806 ] Resetting all VFs causes resource leak on VFs with FDIR filters enabled as CTRL VSIs are only invalidated and not freed. Fix by using ice_vf_ctrl_vsi_release() instead of ice_vf_ctrl_invalidate_vsi() which aligns behavior with the ice_reset_vf() function. Reproduction: echo 1 > /sys/class/net/$pf/device/sriov_numvfs ethtool -N $vf flow-type ether proto 0x9000 action 0 echo 1 > /sys/class/net/$pf/device/reset Fixes: da62c5ff9dcd ("ice: Add support for per VF ctrl VSI enabling") Signed-off-by: Dawid Osuchowski Signed-off-by: Aleksandr Loktionov Reviewed-by: Simon Horman Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c b/drivers/net/ethernet/intel/ice/ice_vf_lib.c index b1f46707dcc004..27e4acb1620f0c 100644 --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c @@ -801,7 +801,7 @@ void ice_reset_all_vfs(struct ice_pf *pf) * setup only when VF creates its first FDIR rule. */ if (vf->ctrl_vsi_idx != ICE_NO_VSI) - ice_vf_ctrl_invalidate_vsi(vf); + ice_vf_ctrl_vsi_release(vf); ice_vf_pre_vsi_rebuild(vf); if (ice_vf_rebuild_vsi(vf)) { -- 2.53.0