Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3588411691; Tue, 21 Jul 2026 19:12:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784661181; cv=none; b=q8v98qhFfRtOvgByQsnwfIjy6zEq8ZlQzGnArYa/gVFKh+mevXO9L89CGNSLvR7QgWGtqqWRSTeWXx4IBW15uTjLdVGh4fsxZYPN92N9qat1jGUbDzaFkAjB0ub8K2XMn+cmU3R899g9Eb7LrI+/FKAPGY3Jg6kEjvLET+dswKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784661181; c=relaxed/simple; bh=4F0ij4gEi3eMNDbhsePeKO3voUlNk1FumE+gQAB+EOg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=upkfJVfWZoEcAN5tCitaEHEj1fZB5C+6AoljAxaaax2faWgWUvWsKqDLmaQ+DAidrnw2ITNDSQQKrNgA4qBh67WDuRXkEHGjmIxsQ7TBlMflEMV4/uV5bnoVa4muAMkSjXbou/i7tN3EGtlr6cxqvhP5S/OLwXhb8xholVcM/88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=S/4lwJq5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="S/4lwJq5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B1EB1F00A3A; Tue, 21 Jul 2026 19:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784661179; bh=nTCAik8+GZRJtBgITqz9/rH73srJBGb/Cmk4EIymfgY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=S/4lwJq5dwmjhCHZYeenc1ML3C2FKR6PhiBKp6McphhE4q+pxWI99DZ+euAE93gst Kl+V8AicPSiGmcQu/IiYEbbqZrOK31JzkN5zPQqArAOtdg1wlqJcHycnqOeKh5Zjo+ 5Zr32AHkwmkjH79tG+62kgS1o3eYPRjBB08Jlfmg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Koichiro Den , Manivannan Sadhasivam , Bjorn Helgaas , Frank Li , Dave Jiang , Sasha Levin Subject: [PATCH 7.1 1244/2077] NTB: epf: Make db_valid_mask cover only real doorbell bits Date: Tue, 21 Jul 2026 17:15:17 +0200 Message-ID: <20260721152622.156529097@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Koichiro Den [ Upstream commit 6eb7e28f1f24a28234add38755687a7ed8bc2654 ] ndev->db_count includes an unused doorbell slot due to the legacy extra offset in the peer doorbell path. db_valid_mask must cover only the real doorbell bits and exclude the unused slot. Set db_valid_mask to BIT_ULL(db_count - 1) - 1. Fixes: 812ce2f8d14e ("NTB: Add support for EPF PCI Non-Transparent Bridge") Signed-off-by: Koichiro Den Signed-off-by: Manivannan Sadhasivam Signed-off-by: Bjorn Helgaas Reviewed-by: Frank Li Reviewed-by: Dave Jiang Link: https://patch.msgid.link/20260513024923.451765-10-den@valinux.co.jp Signed-off-by: Sasha Levin --- drivers/ntb/hw/epf/ntb_hw_epf.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_epf.c index 15d99d08f84f9a..051af2a45c6f98 100644 --- a/drivers/ntb/hw/epf/ntb_hw_epf.c +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c @@ -560,7 +560,11 @@ static int ntb_epf_init_dev(struct ntb_epf_dev *ndev) return ret; } - ndev->db_valid_mask = BIT_ULL(ndev->db_count) - 1; + /* + * ndev->db_count includes an extra skipped slot due to the legacy + * doorbell layout, hence -1. + */ + ndev->db_valid_mask = BIT_ULL(ndev->db_count - 1) - 1; ndev->mw_count = readl(ndev->ctrl_reg + NTB_EPF_MW_COUNT); ndev->spad_count = readl(ndev->ctrl_reg + NTB_EPF_SPAD_COUNT); -- 2.53.0